* [PATCH] f2fs: should unset atomic flag after successful commit
@ 2016-01-10 1:10 Jaegeuk Kim
2016-01-11 7:25 ` [f2fs-dev] " Chao Yu
0 siblings, 1 reply; 4+ messages in thread
From: Jaegeuk Kim @ 2016-01-10 1:10 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, linux-f2fs-devel; +Cc: Jaegeuk Kim
If there is an error during commit, we should keep the flag in order to
abort it.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index dfaed51..db0b2cb 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1374,10 +1374,10 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)
return ret;
if (f2fs_is_atomic_file(inode)) {
- clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
ret = commit_inmem_pages(inode, false);
if (ret)
goto err_out;
+ clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
}
ret = f2fs_sync_file(filp, 0, LLONG_MAX, 0);
--
2.6.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful commit
2016-01-10 1:10 [PATCH] f2fs: should unset atomic flag after successful commit Jaegeuk Kim
@ 2016-01-11 7:25 ` Chao Yu
2016-01-11 23:32 ` Jaegeuk Kim
0 siblings, 1 reply; 4+ messages in thread
From: Chao Yu @ 2016-01-11 7:25 UTC (permalink / raw)
To: 'Jaegeuk Kim'; +Cc: linux-kernel, linux-fsdevel, linux-f2fs-devel
Hi Jaegeuk,
> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Sunday, January 10, 2016 9:10 AM
> To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful commit
>
> If there is an error during commit, we should keep the flag in order to
> abort it.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index dfaed51..db0b2cb 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1374,10 +1374,10 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)
> return ret;
>
> if (f2fs_is_atomic_file(inode)) {
> - clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
It was added in 6282adbf932c ("f2fs: call set_page_dirty to attach i_wb for
cgroup ") to avoid panic in kernel with writeback supported cgroup. We
should keep it here.
> ret = commit_inmem_pages(inode, false);
> if (ret)
> goto err_out;
> + clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
How about setting atomic flag if there occurs an error during committing.
Thanks,
> }
>
> ret = f2fs_sync_file(filp, 0, LLONG_MAX, 0);
> --
> 2.6.3
>
>
> ------------------------------------------------------------------------------
> Site24x7 APM Insight: Get Deep Visibility into Application Performance
> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> Monitor end-to-end web transactions and take corrective actions now
> Troubleshoot faster and improve end-user experience. Signup Now!
> http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful commit
2016-01-11 7:25 ` [f2fs-dev] " Chao Yu
@ 2016-01-11 23:32 ` Jaegeuk Kim
0 siblings, 0 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2016-01-11 23:32 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-kernel, linux-fsdevel, linux-f2fs-devel
Hi Chao,
On Mon, Jan 11, 2016 at 03:25:11PM +0800, Chao Yu wrote:
> Hi Jaegeuk,
>
> > -----Original Message-----
> > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> > Sent: Sunday, January 10, 2016 9:10 AM
> > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> > linux-f2fs-devel@lists.sourceforge.net
> > Cc: Jaegeuk Kim
> > Subject: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful commit
> >
> > If there is an error during commit, we should keep the flag in order to
> > abort it.
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/file.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index dfaed51..db0b2cb 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -1374,10 +1374,10 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)
> > return ret;
> >
> > if (f2fs_is_atomic_file(inode)) {
> > - clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
>
> It was added in 6282adbf932c ("f2fs: call set_page_dirty to attach i_wb for
> cgroup ") to avoid panic in kernel with writeback supported cgroup. We
> should keep it here.
>
> > ret = commit_inmem_pages(inode, false);
> > if (ret)
> > goto err_out;
> > + clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
>
> How about setting atomic flag if there occurs an error during committing.
Got your point.
Thanks,
>
> Thanks,
>
> > }
> >
> > ret = f2fs_sync_file(filp, 0, LLONG_MAX, 0);
> > --
> > 2.6.3
> >
> >
> > ------------------------------------------------------------------------------
> > Site24x7 APM Insight: Get Deep Visibility into Application Performance
> > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> > Monitor end-to-end web transactions and take corrective actions now
> > Troubleshoot faster and improve end-user experience. Signup Now!
> > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] f2fs: should unset atomic flag after successful commit
@ 2016-01-11 23:32 ` Jaegeuk Kim
0 siblings, 0 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2016-01-11 23:32 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-fsdevel, linux-kernel, linux-f2fs-devel
Hi Chao,
On Mon, Jan 11, 2016 at 03:25:11PM +0800, Chao Yu wrote:
> Hi Jaegeuk,
>
> > -----Original Message-----
> > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> > Sent: Sunday, January 10, 2016 9:10 AM
> > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> > linux-f2fs-devel@lists.sourceforge.net
> > Cc: Jaegeuk Kim
> > Subject: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful commit
> >
> > If there is an error during commit, we should keep the flag in order to
> > abort it.
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/file.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index dfaed51..db0b2cb 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -1374,10 +1374,10 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)
> > return ret;
> >
> > if (f2fs_is_atomic_file(inode)) {
> > - clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
>
> It was added in 6282adbf932c ("f2fs: call set_page_dirty to attach i_wb for
> cgroup ") to avoid panic in kernel with writeback supported cgroup. We
> should keep it here.
>
> > ret = commit_inmem_pages(inode, false);
> > if (ret)
> > goto err_out;
> > + clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE);
>
> How about setting atomic flag if there occurs an error during committing.
Got your point.
Thanks,
>
> Thanks,
>
> > }
> >
> > ret = f2fs_sync_file(filp, 0, LLONG_MAX, 0);
> > --
> > 2.6.3
> >
> >
> > ------------------------------------------------------------------------------
> > Site24x7 APM Insight: Get Deep Visibility into Application Performance
> > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> > Monitor end-to-end web transactions and take corrective actions now
> > Troubleshoot faster and improve end-user experience. Signup Now!
> > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-11 23:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-10 1:10 [PATCH] f2fs: should unset atomic flag after successful commit Jaegeuk Kim
2016-01-11 7:25 ` [f2fs-dev] " Chao Yu
2016-01-11 23:32 ` Jaegeuk Kim
2016-01-11 23:32 ` Jaegeuk Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.