From: Andy Gross <andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Srinivas Kandagatla
<srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
Date: Tue, 12 Jan 2016 16:25:56 -0600 [thread overview]
Message-ID: <20160112222556.GB4125@hector.attlocal.net> (raw)
In-Reply-To: <56950B4D.3030707-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Tue, Jan 12, 2016 at 02:18:53PM +0000, Srinivas Kandagatla wrote:
>
>
> On 12/01/16 14:00, Arnd Bergmann wrote:
> >On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >>To be consistent with other nodes move sdhci node under the soc node,
> >>rather than using lable references.
> >>
> >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >>
> >
> >Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
>
> >
> My understanding so far was qcom specific dt want to use hierarchical dt
> nodes in the board files, but this brings the question of should we delete
> all the unused labels.
>
> IMO, some unused labels are harmless and would give more consistency to the
> reader, removing them might not add great value.
>
> Andy/Stephen, any comments?
I tend to lean towards leaving the labels in. But at the same time we don't
want to get cluttered with unused labels. That said, perhaps If the label
makes things more understandable, then leave them in. Otherwise, they really
have no use.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andy Gross <andy.gross@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
Date: Tue, 12 Jan 2016 16:25:56 -0600 [thread overview]
Message-ID: <20160112222556.GB4125@hector.attlocal.net> (raw)
In-Reply-To: <56950B4D.3030707@linaro.org>
On Tue, Jan 12, 2016 at 02:18:53PM +0000, Srinivas Kandagatla wrote:
>
>
> On 12/01/16 14:00, Arnd Bergmann wrote:
> >On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >>To be consistent with other nodes move sdhci node under the soc node,
> >>rather than using lable references.
> >>
> >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>
> >
> >Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
>
> >
> My understanding so far was qcom specific dt want to use hierarchical dt
> nodes in the board files, but this brings the question of should we delete
> all the unused labels.
>
> IMO, some unused labels are harmless and would give more consistency to the
> reader, removing them might not add great value.
>
> Andy/Stephen, any comments?
I tend to lean towards leaving the labels in. But at the same time we don't
want to get cluttered with unused labels. That said, perhaps If the label
makes things more understandable, then leave them in. Otherwise, they really
have no use.
WARNING: multiple messages have this Message-ID (diff)
From: andy.gross@linaro.org (Andy Gross)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
Date: Tue, 12 Jan 2016 16:25:56 -0600 [thread overview]
Message-ID: <20160112222556.GB4125@hector.attlocal.net> (raw)
In-Reply-To: <56950B4D.3030707@linaro.org>
On Tue, Jan 12, 2016 at 02:18:53PM +0000, Srinivas Kandagatla wrote:
>
>
> On 12/01/16 14:00, Arnd Bergmann wrote:
> >On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >>To be consistent with other nodes move sdhci node under the soc node,
> >>rather than using lable references.
> >>
> >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>
> >
> >Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
>
> >
> My understanding so far was qcom specific dt want to use hierarchical dt
> nodes in the board files, but this brings the question of should we delete
> all the unused labels.
>
> IMO, some unused labels are harmless and would give more consistency to the
> reader, removing them might not add great value.
>
> Andy/Stephen, any comments?
I tend to lean towards leaving the labels in. But at the same time we don't
want to get cluttered with unused labels. That said, perhaps If the label
makes things more understandable, then leave them in. Otherwise, they really
have no use.
next prev parent reply other threads:[~2016-01-12 22:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 13:45 [PATCH 0/5] arm64: dts: apq8016-sbc dt patches Srinivas Kandagatla
2016-01-12 13:45 ` Srinivas Kandagatla
2016-01-12 13:46 ` [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support Srinivas Kandagatla
2016-01-12 13:46 ` Srinivas Kandagatla
2016-01-12 13:59 ` Arnd Bergmann
2016-01-12 13:59 ` Arnd Bergmann
2016-01-12 14:30 ` Srinivas Kandagatla
2016-01-12 14:30 ` Srinivas Kandagatla
2016-01-12 22:22 ` Andy Gross
2016-01-12 22:22 ` Andy Gross
2016-01-12 13:46 ` [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node Srinivas Kandagatla
2016-01-12 13:46 ` Srinivas Kandagatla
2016-01-12 14:00 ` Arnd Bergmann
2016-01-12 14:00 ` Arnd Bergmann
2016-01-12 14:18 ` Srinivas Kandagatla
2016-01-12 14:18 ` Srinivas Kandagatla
2016-01-12 14:49 ` Arnd Bergmann
2016-01-12 14:49 ` Arnd Bergmann
[not found] ` <56950B4D.3030707-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-01-12 22:25 ` Andy Gross [this message]
2016-01-12 22:25 ` Andy Gross
2016-01-12 22:25 ` Andy Gross
2016-01-12 13:47 ` [PATCH 3/5] arm64: dts: remove s2 regulator from smd regulators Srinivas Kandagatla
2016-01-12 13:47 ` Srinivas Kandagatla
2016-01-12 13:47 ` [PATCH 4/5] arm64: dts: apq8016-sbc: make 1.8v available on LS expansion Srinivas Kandagatla
2016-01-12 13:47 ` Srinivas Kandagatla
2016-01-12 13:47 ` [PATCH 5/5] arm64: dts: apq8016-sbc: Add real regulators and pinctrl for sdhc Srinivas Kandagatla
2016-01-12 13:47 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112222556.GB4125@hector.attlocal.net \
--to=andy.gross-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.