From: Arnd Bergmann <arnd@arndb.de> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, andy.gross@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org> Subject: Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node Date: Tue, 12 Jan 2016 15:49:52 +0100 [thread overview] Message-ID: <5301475.Pt8xa8PKiv@wuerfel> (raw) In-Reply-To: <56950B4D.3030707@linaro.org> On Tuesday 12 January 2016 14:18:53 Srinivas Kandagatla wrote: > On 12/01/16 14:00, Arnd Bergmann wrote: > > On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote: > >> To be consistent with other nodes move sdhci node under the soc node, > >> rather than using lable references. > >> > >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > >> > > > > Maybe remove the label as well if you are no longer using it? > Label "sdhc_1" in this case is used in aliases node. > Ok, nevermind then. > My understanding so far was qcom specific dt want to use hierarchical dt > nodes in the board files, but this brings the question of should we > delete all the unused labels. > > IMO, some unused labels are harmless and would give more consistency to > the reader, removing them might not add great value. Fair enough. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node Date: Tue, 12 Jan 2016 15:49:52 +0100 [thread overview] Message-ID: <5301475.Pt8xa8PKiv@wuerfel> (raw) In-Reply-To: <56950B4D.3030707@linaro.org> On Tuesday 12 January 2016 14:18:53 Srinivas Kandagatla wrote: > On 12/01/16 14:00, Arnd Bergmann wrote: > > On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote: > >> To be consistent with other nodes move sdhci node under the soc node, > >> rather than using lable references. > >> > >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > >> > > > > Maybe remove the label as well if you are no longer using it? > Label "sdhc_1" in this case is used in aliases node. > Ok, nevermind then. > My understanding so far was qcom specific dt want to use hierarchical dt > nodes in the board files, but this brings the question of should we > delete all the unused labels. > > IMO, some unused labels are harmless and would give more consistency to > the reader, removing them might not add great value. Fair enough. Arnd
next prev parent reply other threads:[~2016-01-12 14:49 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-12 13:45 [PATCH 0/5] arm64: dts: apq8016-sbc dt patches Srinivas Kandagatla 2016-01-12 13:45 ` Srinivas Kandagatla 2016-01-12 13:46 ` [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support Srinivas Kandagatla 2016-01-12 13:46 ` Srinivas Kandagatla 2016-01-12 13:59 ` Arnd Bergmann 2016-01-12 13:59 ` Arnd Bergmann 2016-01-12 14:30 ` Srinivas Kandagatla 2016-01-12 14:30 ` Srinivas Kandagatla 2016-01-12 22:22 ` Andy Gross 2016-01-12 22:22 ` Andy Gross 2016-01-12 13:46 ` [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node Srinivas Kandagatla 2016-01-12 13:46 ` Srinivas Kandagatla 2016-01-12 14:00 ` Arnd Bergmann 2016-01-12 14:00 ` Arnd Bergmann 2016-01-12 14:18 ` Srinivas Kandagatla 2016-01-12 14:18 ` Srinivas Kandagatla 2016-01-12 14:49 ` Arnd Bergmann [this message] 2016-01-12 14:49 ` Arnd Bergmann [not found] ` <56950B4D.3030707-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-01-12 22:25 ` Andy Gross 2016-01-12 22:25 ` Andy Gross 2016-01-12 22:25 ` Andy Gross 2016-01-12 13:47 ` [PATCH 3/5] arm64: dts: remove s2 regulator from smd regulators Srinivas Kandagatla 2016-01-12 13:47 ` Srinivas Kandagatla 2016-01-12 13:47 ` [PATCH 4/5] arm64: dts: apq8016-sbc: make 1.8v available on LS expansion Srinivas Kandagatla 2016-01-12 13:47 ` Srinivas Kandagatla 2016-01-12 13:47 ` [PATCH 5/5] arm64: dts: apq8016-sbc: Add real regulators and pinctrl for sdhc Srinivas Kandagatla 2016-01-12 13:47 ` Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5301475.Pt8xa8PKiv@wuerfel \ --to=arnd@arndb.de \ --cc=andy.gross@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=srinivas.kandagatla@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.