From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Romain Izard <romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Yang Wenyou <Wenyou.Yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>, Josh Wu <rainyfeeling-1ViLX0X+lBJBDgjK7y7TUQ@public.gmane.org>, Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Subject: Re: [PATCH v1 2/5] mtd: atmel_nand: Support variable RB_EDGE interrupts Date: Wed, 13 Jan 2016 19:19:24 -0600 [thread overview] Message-ID: <20160114011924.GA31786@rob-hp-laptop> (raw) In-Reply-To: <1452702857-2240-3-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> On Wed, Jan 13, 2016 at 05:34:14PM +0100, Romain Izard wrote: > The NFC controller used to accelerate the NAND transfers on SAMA5 chips > can use either RB_EDGE0 or RB_EDGE3 as its ready/busy interrupt bit. > > Use the controller's compatible string to select the correct bit. > > Signed-off-by: Romain Izard <romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > Reviewed-by: Wenyou Yang <Wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> > --- > .../devicetree/bindings/mtd/atmel-nand.txt | 2 +- > drivers/mtd/nand/atmel_nand.c | 39 +++++++++++++++++----- > drivers/mtd/nand/atmel_nand_nfc.h | 5 ++- > 3 files changed, 36 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > index 7d4c8eb775a5..89b0db9801b0 100644 > --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt > +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > @@ -34,7 +34,7 @@ Optional properties: > - nand-on-flash-bbt: boolean to enable on flash bbt option if not present false > - Nand Flash Controller(NFC) is a slave driver under Atmel nand flash > - Required properties: > - - compatible : "atmel,sama5d3-nfc". > + - compatible : "atmel,sama5d3-nfc" or "atmel,sama5d4-nfc". > - reg : should specify the address and size used for NFC command registers, > NFC registers and NFC Sram. NFC Sram address and size can be absent > if don't want to use it. For the binding: Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [...] > @@ -2352,6 +2360,12 @@ static int atmel_nand_nfc_probe(struct platform_device *pdev) > } > } > > + priv = of_match_device(atmel_nand_nfc_match, &pdev->dev)->data; Use of_device_get_match_data > + if (NULL == priv) > + return -ENODEV; > + > + nfc->rb_edge = priv->rb_edge; > + > nfc_writel(nfc->hsmc_regs, IDR, 0xffffffff); > nfc_readl(nfc->hsmc_regs, SR); /* clear the NFC_SR */ > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Romain Izard <romain.izard.pro@gmail.com> Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, Yang Wenyou <Wenyou.Yang@atmel.com>, Josh Wu <rainyfeeling@outlook.com>, Nicolas Ferre <nicolas.ferre@atmel.com> Subject: Re: [PATCH v1 2/5] mtd: atmel_nand: Support variable RB_EDGE interrupts Date: Wed, 13 Jan 2016 19:19:24 -0600 [thread overview] Message-ID: <20160114011924.GA31786@rob-hp-laptop> (raw) In-Reply-To: <1452702857-2240-3-git-send-email-romain.izard.pro@gmail.com> On Wed, Jan 13, 2016 at 05:34:14PM +0100, Romain Izard wrote: > The NFC controller used to accelerate the NAND transfers on SAMA5 chips > can use either RB_EDGE0 or RB_EDGE3 as its ready/busy interrupt bit. > > Use the controller's compatible string to select the correct bit. > > Signed-off-by: Romain Izard <romain.izard.pro@gmail.com> > Reviewed-by: Wenyou Yang <Wenyou.yang@atmel.com> > --- > .../devicetree/bindings/mtd/atmel-nand.txt | 2 +- > drivers/mtd/nand/atmel_nand.c | 39 +++++++++++++++++----- > drivers/mtd/nand/atmel_nand_nfc.h | 5 ++- > 3 files changed, 36 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > index 7d4c8eb775a5..89b0db9801b0 100644 > --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt > +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > @@ -34,7 +34,7 @@ Optional properties: > - nand-on-flash-bbt: boolean to enable on flash bbt option if not present false > - Nand Flash Controller(NFC) is a slave driver under Atmel nand flash > - Required properties: > - - compatible : "atmel,sama5d3-nfc". > + - compatible : "atmel,sama5d3-nfc" or "atmel,sama5d4-nfc". > - reg : should specify the address and size used for NFC command registers, > NFC registers and NFC Sram. NFC Sram address and size can be absent > if don't want to use it. For the binding: Acked-by: Rob Herring <robh@kernel.org> [...] > @@ -2352,6 +2360,12 @@ static int atmel_nand_nfc_probe(struct platform_device *pdev) > } > } > > + priv = of_match_device(atmel_nand_nfc_match, &pdev->dev)->data; Use of_device_get_match_data > + if (NULL == priv) > + return -ENODEV; > + > + nfc->rb_edge = priv->rb_edge; > + > nfc_writel(nfc->hsmc_regs, IDR, 0xffffffff); > nfc_readl(nfc->hsmc_regs, SR); /* clear the NFC_SR */ >
next prev parent reply other threads:[~2016-01-14 1:19 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-13 16:34 [PATCH v1 0/5] mtd: atmel_nand: Add support for NAND Flash on SAMA5D2 Romain Izard 2016-01-13 16:34 ` Romain Izard [not found] ` <1452702857-2240-1-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2016-01-13 16:34 ` [PATCH v1 1/5] mtd: atmel_nand: Do not warn on bitflips Romain Izard 2016-01-13 16:34 ` Romain Izard [not found] ` <1452702857-2240-2-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2016-01-13 17:54 ` Boris Brezillon 2016-01-13 17:54 ` Boris Brezillon 2016-01-23 20:44 ` Brian Norris 2016-01-23 20:44 ` Brian Norris 2016-01-13 16:34 ` [PATCH v1 2/5] mtd: atmel_nand: Support variable RB_EDGE interrupts Romain Izard 2016-01-13 16:34 ` Romain Izard [not found] ` <1452702857-2240-3-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2016-01-13 18:14 ` Boris Brezillon 2016-01-13 18:14 ` Boris Brezillon 2016-01-14 10:16 ` Romain Izard 2016-01-14 10:16 ` Romain Izard [not found] ` <CAGkQfmMQTBVzOoE3BTyvg73NKjtGD_0veV_zb_jLutk-6bcqGw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-01-14 10:41 ` Boris Brezillon 2016-01-14 10:41 ` Boris Brezillon 2016-01-14 1:19 ` Rob Herring [this message] 2016-01-14 1:19 ` Rob Herring 2016-01-13 16:34 ` [PATCH v1 3/5] mtd: atmel_nand: Support PMECC on SAMA5D2 Romain Izard 2016-01-13 16:34 ` Romain Izard [not found] ` <1452702857-2240-4-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2016-01-14 1:12 ` Rob Herring 2016-01-14 1:12 ` Rob Herring 2016-01-14 1:17 ` Yang, Wenyou 2016-01-14 1:17 ` Yang, Wenyou 2016-01-14 13:14 ` Rob Herring 2016-01-14 13:14 ` Rob Herring [not found] ` <CAL_JsqL9kbNYrGYeqT7QCsbMneJbPgoXfaHhCvL8S=t97YaCbg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-01-15 1:17 ` Yang, Wenyou 2016-01-15 1:17 ` Yang, Wenyou 2016-01-15 8:54 ` Romain Izard 2016-01-15 8:54 ` Romain Izard [not found] ` <CAGkQfmO94gQ61prZvF52=B_UtOTkbYxd5nnTmDhJam4q-n3T7g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-01-17 4:05 ` Rob Herring 2016-01-17 4:05 ` Rob Herring 2016-01-14 9:19 ` Boris Brezillon 2016-01-14 9:19 ` Boris Brezillon 2016-01-15 10:06 ` romain izard 2016-01-15 10:06 ` romain izard 2016-01-13 16:34 ` [PATCH v1 4/5] mtd: atmel_nand: Support 32-bit ECC strength Romain Izard 2016-01-13 16:34 ` Romain Izard [not found] ` <1452702857-2240-5-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2016-01-14 1:09 ` Rob Herring 2016-01-14 1:09 ` Rob Herring 2016-01-14 9:26 ` Boris Brezillon 2016-01-14 9:26 ` Boris Brezillon 2016-01-13 16:34 ` [PATCH v1 5/5] ARM: at91/dt: sama5d2: add nand0 and nfc0 nodes Romain Izard 2016-01-13 16:34 ` Romain Izard [not found] ` <1452702857-2240-6-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2016-01-13 17:04 ` Nicolas Ferre 2016-01-13 17:04 ` Nicolas Ferre 2016-01-13 17:04 ` Nicolas Ferre
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160114011924.GA31786@rob-hp-laptop \ --to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \ --cc=Wenyou.Yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \ --cc=rainyfeeling-1ViLX0X+lBJBDgjK7y7TUQ@public.gmane.org \ --cc=romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.