From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-s390@vger.kernel.org, x86@kernel.org,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
davej@codemonkey.org.uk
Subject: Re: [PATCH v2 3/3] s390: query dynamic DEBUG_PAGEALLOC setting
Date: Wed, 27 Jan 2016 10:55:43 +0100 [thread overview]
Message-ID: <20160127095543.GB4439@osiris> (raw)
In-Reply-To: <1453884618-33852-4-git-send-email-borntraeger@de.ibm.com>
On Wed, Jan 27, 2016 at 09:50:18AM +0100, Christian Borntraeger wrote:
> We can use debug_pagealloc_enabled() to check if we can map
> the identity mapping with 1MB/2GB pages as well as to print
> the current setting in dump_stack.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> arch/s390/kernel/dumpstack.c | 8 ++++----
> arch/s390/mm/vmem.c | 10 ++++------
> 2 files changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/arch/s390/kernel/dumpstack.c b/arch/s390/kernel/dumpstack.c
> index dc8e204..3f352e9 100644
> --- a/arch/s390/kernel/dumpstack.c
> +++ b/arch/s390/kernel/dumpstack.c
> @@ -11,6 +11,7 @@
> #include <linux/export.h>
> #include <linux/kdebug.h>
> #include <linux/ptrace.h>
> +#include <linux/mm.h>
> #include <linux/module.h>
> #include <linux/sched.h>
> #include <asm/processor.h>
> @@ -184,10 +185,9 @@ void die(struct pt_regs *regs, const char *str)
> #endif
> #ifdef CONFIG_SMP
> printk("SMP ");
> -#endif
> -#ifdef CONFIG_DEBUG_PAGEALLOC
> - printk("DEBUG_PAGEALLOC");
> -#endif
> +#endif
> +if (debug_pagealloc_enabled())
> + printk("DEBUG_PAGEALLOC");
> printk("\n");
Indentation is broken ("if").
Besides that
Reviewed-by: Heiko Carstens <heiko.carstens@de.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-s390@vger.kernel.org, x86@kernel.org,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
davej@codemonkey.org.uk
Subject: Re: [PATCH v2 3/3] s390: query dynamic DEBUG_PAGEALLOC setting
Date: Wed, 27 Jan 2016 10:55:43 +0100 [thread overview]
Message-ID: <20160127095543.GB4439@osiris> (raw)
In-Reply-To: <1453884618-33852-4-git-send-email-borntraeger@de.ibm.com>
On Wed, Jan 27, 2016 at 09:50:18AM +0100, Christian Borntraeger wrote:
> We can use debug_pagealloc_enabled() to check if we can map
> the identity mapping with 1MB/2GB pages as well as to print
> the current setting in dump_stack.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> arch/s390/kernel/dumpstack.c | 8 ++++----
> arch/s390/mm/vmem.c | 10 ++++------
> 2 files changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/arch/s390/kernel/dumpstack.c b/arch/s390/kernel/dumpstack.c
> index dc8e204..3f352e9 100644
> --- a/arch/s390/kernel/dumpstack.c
> +++ b/arch/s390/kernel/dumpstack.c
> @@ -11,6 +11,7 @@
> #include <linux/export.h>
> #include <linux/kdebug.h>
> #include <linux/ptrace.h>
> +#include <linux/mm.h>
> #include <linux/module.h>
> #include <linux/sched.h>
> #include <asm/processor.h>
> @@ -184,10 +185,9 @@ void die(struct pt_regs *regs, const char *str)
> #endif
> #ifdef CONFIG_SMP
> printk("SMP ");
> -#endif
> -#ifdef CONFIG_DEBUG_PAGEALLOC
> - printk("DEBUG_PAGEALLOC");
> -#endif
> +#endif
> +if (debug_pagealloc_enabled())
> + printk("DEBUG_PAGEALLOC");
> printk("\n");
Indentation is broken ("if").
Besides that
Reviewed-by: Heiko Carstens <heiko.carstens@de.ibm.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-01-27 9:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 8:50 [PATCH v2 0/3] Optimize CONFIG_DEBUG_PAGEALLOC Christian Borntraeger
2016-01-27 8:50 ` Christian Borntraeger
2016-01-27 8:50 ` [PATCH v2 1/3] mm: provide debug_pagealloc_enabled() without CONFIG_DEBUG_PAGEALLOC Christian Borntraeger
2016-01-27 8:50 ` Christian Borntraeger
2016-01-27 9:15 ` Thomas Gleixner
2016-01-27 9:15 ` Thomas Gleixner
2016-01-27 8:50 ` [PATCH v2 2/3] x86: query dynamic DEBUG_PAGEALLOC setting Christian Borntraeger
2016-01-27 8:50 ` Christian Borntraeger
2016-01-27 9:16 ` Thomas Gleixner
2016-01-27 9:16 ` Thomas Gleixner
2016-01-27 8:50 ` [PATCH v2 3/3] s390: " Christian Borntraeger
2016-01-27 8:50 ` Christian Borntraeger
2016-01-27 9:55 ` Heiko Carstens [this message]
2016-01-27 9:55 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127095543.GB4439@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.