From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
nm@ti.com
Subject: Re: [PATCH V2 00/16] PM / OPP: Introduce APIs to transition OPPs
Date: Fri, 29 Jan 2016 17:48:42 -0800 [thread overview]
Message-ID: <20160130014842.GI4848@codeaurora.org> (raw)
In-Reply-To: <cover.1453965717.git.viresh.kumar@linaro.org>
On 01/28, Viresh Kumar wrote:
> Hi Guys,
>
> This patchset add APIs in OPP layer to allow OPPs transitioning from
> within OPP layer. Currently all OPP users need to replicate the same
> code to switch between OPPs. While the same can be handled easily by
> OPP-core.
>
> The first 7 patches update the OPP core to introduce the new APIs and
> the next Nine patches update cpufreq-dt for the same.
>
> 11 out of 17 are already Reviewed by Stephen, only few are left :)
I'll look at this early next week.
Just a note for future work, I think we're going to need to add
some sort of enable/disable into the OPP layer. At least in qcom
designs, if a clock is off we don't want the voltage requirement
for that clock to factor into the final voltage on the regulator.
Furthermore, we want to disable the regulator with
regulator_disable() if all the clocks are off.
This is also a problem with cpufreq-dt. The regulators and clocks
are assumed to be enabled out of the bootloader, which may not
even be true. Now that OPP layer is managing all the clocks and
regulators here we're going to need to do something to make sure
they're on and controllable.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-01-30 1:48 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 8:20 [PATCH V2 00/16] PM / OPP: Introduce APIs to transition OPPs Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 01/16] PM / OPP: get/put regulators from OPP core Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-02-02 2:29 ` Stephen Boyd
2016-02-02 3:23 ` Viresh Kumar
2016-02-08 22:52 ` Stephen Boyd
2016-02-09 3:53 ` Viresh Kumar
2016-02-09 3:54 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 02/16] PM / OPP: Disable OPPs that aren't supported by the regulator Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 03/16] PM / OPP: Introduce dev_pm_opp_get_max_volt_latency() Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-02-02 2:30 ` Stephen Boyd
2016-01-28 8:20 ` [PATCH V2 04/16] PM / OPP: Introduce dev_pm_opp_get_max_transition_latency() Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 05/16] PM / OPP: Parse clock-latency and voltage-tolerance for v1 bindings Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 06/16] PM / OPP: Manage device clk Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 07/16] PM / OPP: Add dev_pm_opp_set_rate() Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-02-02 2:10 ` Stephen Boyd
2016-02-02 3:38 ` Viresh Kumar
2016-02-02 20:46 ` Stephen Boyd
2016-01-28 8:20 ` [PATCH V2 08/16] cpufreq: dt: Convert few pr_debug/err() calls to dev_dbg/err() Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 09/16] cpufreq: dt: Rename 'need_update' to 'opp_v1' Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 10/16] cpufreq: dt: OPP layers handles clock-latency for V1 bindings as well Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 11/16] cpufreq: dt: Pass regulator name to the OPP core Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-02-02 2:34 ` Stephen Boyd
2016-02-02 6:10 ` Viresh Kumar
2016-02-08 22:55 ` Stephen Boyd
2016-02-09 4:10 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 12/16] cpufreq: dt: Unsupported OPPs are already disabled Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 13/16] cpufreq: dt: Reuse dev_pm_opp_get_max_transition_latency() Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 14/16] cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 15/16] cpufreq: dt: drop references to DT node Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-02-02 6:11 ` Viresh Kumar
2016-02-08 22:56 ` Stephen Boyd
2016-02-09 4:22 ` Viresh Kumar
2016-01-28 8:20 ` [PATCH V2 16/16] cpufreq: dt: No need to allocate resources anymore Viresh Kumar
2016-01-28 8:20 ` Viresh Kumar
2016-02-02 6:12 ` Viresh Kumar
2016-02-08 22:58 ` Stephen Boyd
2016-01-30 1:48 ` Stephen Boyd [this message]
2016-02-01 4:08 ` [PATCH V2 00/16] PM / OPP: Introduce APIs to transition OPPs Viresh Kumar
2016-02-01 19:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160130014842.GI4848@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.