From: Viresh Kumar <viresh.kumar@linaro.org> To: Rafael Wysocki <rjw@rjwysocki.net> Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>, nm@ti.com, Viresh Kumar <viresh.kumar@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Len Brown <len.brown@intel.com>, linux-kernel@vger.kernel.org (open list), Pavel Machek <pavel@ucw.cz>, Viresh Kumar <vireshk@kernel.org> Subject: [PATCH V2 02/16] PM / OPP: Disable OPPs that aren't supported by the regulator Date: Thu, 28 Jan 2016 13:50:31 +0530 [thread overview] Message-ID: <16ba415d52ce9c967201f9fca1385014334e1be3.1453965717.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1453965717.git.viresh.kumar@linaro.org> In-Reply-To: <cover.1453965717.git.viresh.kumar@linaro.org> Disable any OPPs where the connected regulator isn't able to provide the specified voltage. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/base/power/opp/core.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c index 1e22b71abf1e..71545becfca1 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -687,6 +687,22 @@ static struct dev_pm_opp *_allocate_opp(struct device *dev, return opp; } +static bool _opp_supported_by_regulators(struct dev_pm_opp *opp, + struct device_opp *dev_opp) +{ + struct regulator *reg = dev_opp->regulator; + + if (!IS_ERR(reg) && + !regulator_is_supported_voltage(reg, opp->u_volt_min, + opp->u_volt_max)) { + pr_warn("%s: OPP minuV: %lu maxuV: %lu, not supported by regulator\n", + __func__, opp->u_volt_min, opp->u_volt_max); + return false; + } + + return true; +} + static int _opp_add(struct device *dev, struct dev_pm_opp *new_opp, struct device_opp *dev_opp) { @@ -728,6 +744,12 @@ static int _opp_add(struct device *dev, struct dev_pm_opp *new_opp, dev_err(dev, "%s: Failed to register opp to debugfs (%d)\n", __func__, ret); + if (!_opp_supported_by_regulators(new_opp, dev_opp)) { + new_opp->available = false; + dev_warn(dev, "%s: OPP not supported by regulators (%lu)\n", + __func__, new_opp->rate); + } + return 0; } -- 2.7.0.79.gdc08a19
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org> To: Rafael Wysocki <rjw@rjwysocki.net> Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>, nm@ti.com, Viresh Kumar <viresh.kumar@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Len Brown <len.brown@intel.com>, open list <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>, Viresh Kumar <vireshk@kernel.org> Subject: [PATCH V2 02/16] PM / OPP: Disable OPPs that aren't supported by the regulator Date: Thu, 28 Jan 2016 13:50:31 +0530 [thread overview] Message-ID: <16ba415d52ce9c967201f9fca1385014334e1be3.1453965717.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1453965717.git.viresh.kumar@linaro.org> In-Reply-To: <cover.1453965717.git.viresh.kumar@linaro.org> Disable any OPPs where the connected regulator isn't able to provide the specified voltage. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/base/power/opp/core.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c index 1e22b71abf1e..71545becfca1 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -687,6 +687,22 @@ static struct dev_pm_opp *_allocate_opp(struct device *dev, return opp; } +static bool _opp_supported_by_regulators(struct dev_pm_opp *opp, + struct device_opp *dev_opp) +{ + struct regulator *reg = dev_opp->regulator; + + if (!IS_ERR(reg) && + !regulator_is_supported_voltage(reg, opp->u_volt_min, + opp->u_volt_max)) { + pr_warn("%s: OPP minuV: %lu maxuV: %lu, not supported by regulator\n", + __func__, opp->u_volt_min, opp->u_volt_max); + return false; + } + + return true; +} + static int _opp_add(struct device *dev, struct dev_pm_opp *new_opp, struct device_opp *dev_opp) { @@ -728,6 +744,12 @@ static int _opp_add(struct device *dev, struct dev_pm_opp *new_opp, dev_err(dev, "%s: Failed to register opp to debugfs (%d)\n", __func__, ret); + if (!_opp_supported_by_regulators(new_opp, dev_opp)) { + new_opp->available = false; + dev_warn(dev, "%s: OPP not supported by regulators (%lu)\n", + __func__, new_opp->rate); + } + return 0; } -- 2.7.0.79.gdc08a19
next prev parent reply other threads:[~2016-01-28 8:21 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-28 8:20 [PATCH V2 00/16] PM / OPP: Introduce APIs to transition OPPs Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 01/16] PM / OPP: get/put regulators from OPP core Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 2:29 ` Stephen Boyd 2016-02-02 3:23 ` Viresh Kumar 2016-02-08 22:52 ` Stephen Boyd 2016-02-09 3:53 ` Viresh Kumar 2016-02-09 3:54 ` Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar [this message] 2016-01-28 8:20 ` [PATCH V2 02/16] PM / OPP: Disable OPPs that aren't supported by the regulator Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 03/16] PM / OPP: Introduce dev_pm_opp_get_max_volt_latency() Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 2:30 ` Stephen Boyd 2016-01-28 8:20 ` [PATCH V2 04/16] PM / OPP: Introduce dev_pm_opp_get_max_transition_latency() Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 05/16] PM / OPP: Parse clock-latency and voltage-tolerance for v1 bindings Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 06/16] PM / OPP: Manage device clk Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 07/16] PM / OPP: Add dev_pm_opp_set_rate() Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 2:10 ` Stephen Boyd 2016-02-02 3:38 ` Viresh Kumar 2016-02-02 20:46 ` Stephen Boyd 2016-01-28 8:20 ` [PATCH V2 08/16] cpufreq: dt: Convert few pr_debug/err() calls to dev_dbg/err() Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 09/16] cpufreq: dt: Rename 'need_update' to 'opp_v1' Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 10/16] cpufreq: dt: OPP layers handles clock-latency for V1 bindings as well Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 11/16] cpufreq: dt: Pass regulator name to the OPP core Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 2:34 ` Stephen Boyd 2016-02-02 6:10 ` Viresh Kumar 2016-02-08 22:55 ` Stephen Boyd 2016-02-09 4:10 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 12/16] cpufreq: dt: Unsupported OPPs are already disabled Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 13/16] cpufreq: dt: Reuse dev_pm_opp_get_max_transition_latency() Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 14/16] cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 15/16] cpufreq: dt: drop references to DT node Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 6:11 ` Viresh Kumar 2016-02-08 22:56 ` Stephen Boyd 2016-02-09 4:22 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 16/16] cpufreq: dt: No need to allocate resources anymore Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 6:12 ` Viresh Kumar 2016-02-08 22:58 ` Stephen Boyd 2016-01-30 1:48 ` [PATCH V2 00/16] PM / OPP: Introduce APIs to transition OPPs Stephen Boyd 2016-02-01 4:08 ` Viresh Kumar 2016-02-01 19:41 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=16ba415d52ce9c967201f9fca1385014334e1be3.1453965717.git.viresh.kumar@linaro.org \ --to=viresh.kumar@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=len.brown@intel.com \ --cc=linaro-kernel@lists.linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=nm@ti.com \ --cc=pavel@ucw.cz \ --cc=rjw@rjwysocki.net \ --cc=sboyd@codeaurora.org \ --cc=vireshk@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.