From: Viresh Kumar <viresh.kumar@linaro.org> To: Rafael Wysocki <rjw@rjwysocki.net> Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>, nm@ti.com, Viresh Kumar <viresh.kumar@linaro.org>, linux-kernel@vger.kernel.org (open list) Subject: [PATCH V2 15/16] cpufreq: dt: drop references to DT node Date: Thu, 28 Jan 2016 13:50:44 +0530 [thread overview] Message-ID: <b0f0134c9d2488db1971d7be4b8bcdc27356eee4.1453965717.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1453965717.git.viresh.kumar@linaro.org> In-Reply-To: <cover.1453965717.git.viresh.kumar@linaro.org> We don't need to get reference to DT node now, lets drop it. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/cpufreq/cpufreq-dt.c | 20 +++----------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index 13338365f24e..5ea41518df63 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -33,7 +33,6 @@ struct private_data { struct device *cpu_dev; struct regulator *cpu_reg; struct thermal_cooling_device *cdev; - unsigned int voltage_tolerance; /* in percentage */ const char *reg_name; }; @@ -166,7 +165,6 @@ static int allocate_resources(int cpu, struct device **cdev, static int cpufreq_init(struct cpufreq_policy *policy) { struct cpufreq_frequency_table *freq_table; - struct device_node *np; struct private_data *priv; struct device *cpu_dev; struct regulator *cpu_reg; @@ -183,13 +181,6 @@ static int cpufreq_init(struct cpufreq_policy *policy) return ret; } - np = of_node_get(cpu_dev->of_node); - if (!np) { - dev_err(cpu_dev, "failed to find cpu%d node\n", policy->cpu); - ret = -ENOENT; - goto out_put_reg_clk; - } - /* Get OPP-sharing information from "operating-points-v2" bindings */ ret = dev_pm_opp_of_get_sharing_cpus(cpu_dev, policy->cpus); if (ret) { @@ -200,7 +191,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) if (ret == -ENOENT) opp_v1 = true; else - goto out_node_put; + goto out_put_reg_clk; } /* @@ -210,7 +201,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) name = find_supply_name(cpu_dev); if (IS_ERR(name)) { ret = PTR_ERR(name); - goto out_node_put; + goto out_put_reg_clk; } if (name) { @@ -218,7 +209,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) if (ret) { dev_err(cpu_dev, "Failed to set regulator for cpu%d: %d\n", policy->cpu, ret); - goto out_node_put; + goto out_put_reg_clk; } } @@ -268,7 +259,6 @@ static int cpufreq_init(struct cpufreq_policy *policy) } priv->reg_name = name; - of_property_read_u32(np, "voltage-tolerance", &priv->voltage_tolerance); ret = dev_pm_opp_init_cpufreq_table(cpu_dev, &freq_table); if (ret) { @@ -310,8 +300,6 @@ static int cpufreq_init(struct cpufreq_policy *policy) policy->cpuinfo.transition_latency = transition_latency; - of_node_put(np); - return 0; out_free_cpufreq_table: @@ -322,8 +310,6 @@ static int cpufreq_init(struct cpufreq_policy *policy) dev_pm_opp_of_cpumask_remove_table(policy->cpus); if (name) dev_pm_opp_put_regulator(cpu_dev); -out_node_put: - of_node_put(np); out_put_reg_clk: clk_put(cpu_clk); if (!IS_ERR(cpu_reg)) -- 2.7.0.79.gdc08a19
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org> To: Rafael Wysocki <rjw@rjwysocki.net> Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>, nm@ti.com, Viresh Kumar <viresh.kumar@linaro.org>, open list <linux-kernel@vger.kernel.org> Subject: [PATCH V2 15/16] cpufreq: dt: drop references to DT node Date: Thu, 28 Jan 2016 13:50:44 +0530 [thread overview] Message-ID: <b0f0134c9d2488db1971d7be4b8bcdc27356eee4.1453965717.git.viresh.kumar@linaro.org> (raw) In-Reply-To: <cover.1453965717.git.viresh.kumar@linaro.org> In-Reply-To: <cover.1453965717.git.viresh.kumar@linaro.org> We don't need to get reference to DT node now, lets drop it. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/cpufreq/cpufreq-dt.c | 20 +++----------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index 13338365f24e..5ea41518df63 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -33,7 +33,6 @@ struct private_data { struct device *cpu_dev; struct regulator *cpu_reg; struct thermal_cooling_device *cdev; - unsigned int voltage_tolerance; /* in percentage */ const char *reg_name; }; @@ -166,7 +165,6 @@ static int allocate_resources(int cpu, struct device **cdev, static int cpufreq_init(struct cpufreq_policy *policy) { struct cpufreq_frequency_table *freq_table; - struct device_node *np; struct private_data *priv; struct device *cpu_dev; struct regulator *cpu_reg; @@ -183,13 +181,6 @@ static int cpufreq_init(struct cpufreq_policy *policy) return ret; } - np = of_node_get(cpu_dev->of_node); - if (!np) { - dev_err(cpu_dev, "failed to find cpu%d node\n", policy->cpu); - ret = -ENOENT; - goto out_put_reg_clk; - } - /* Get OPP-sharing information from "operating-points-v2" bindings */ ret = dev_pm_opp_of_get_sharing_cpus(cpu_dev, policy->cpus); if (ret) { @@ -200,7 +191,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) if (ret == -ENOENT) opp_v1 = true; else - goto out_node_put; + goto out_put_reg_clk; } /* @@ -210,7 +201,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) name = find_supply_name(cpu_dev); if (IS_ERR(name)) { ret = PTR_ERR(name); - goto out_node_put; + goto out_put_reg_clk; } if (name) { @@ -218,7 +209,7 @@ static int cpufreq_init(struct cpufreq_policy *policy) if (ret) { dev_err(cpu_dev, "Failed to set regulator for cpu%d: %d\n", policy->cpu, ret); - goto out_node_put; + goto out_put_reg_clk; } } @@ -268,7 +259,6 @@ static int cpufreq_init(struct cpufreq_policy *policy) } priv->reg_name = name; - of_property_read_u32(np, "voltage-tolerance", &priv->voltage_tolerance); ret = dev_pm_opp_init_cpufreq_table(cpu_dev, &freq_table); if (ret) { @@ -310,8 +300,6 @@ static int cpufreq_init(struct cpufreq_policy *policy) policy->cpuinfo.transition_latency = transition_latency; - of_node_put(np); - return 0; out_free_cpufreq_table: @@ -322,8 +310,6 @@ static int cpufreq_init(struct cpufreq_policy *policy) dev_pm_opp_of_cpumask_remove_table(policy->cpus); if (name) dev_pm_opp_put_regulator(cpu_dev); -out_node_put: - of_node_put(np); out_put_reg_clk: clk_put(cpu_clk); if (!IS_ERR(cpu_reg)) -- 2.7.0.79.gdc08a19
next prev parent reply other threads:[~2016-01-28 8:22 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-28 8:20 [PATCH V2 00/16] PM / OPP: Introduce APIs to transition OPPs Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 01/16] PM / OPP: get/put regulators from OPP core Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 2:29 ` Stephen Boyd 2016-02-02 3:23 ` Viresh Kumar 2016-02-08 22:52 ` Stephen Boyd 2016-02-09 3:53 ` Viresh Kumar 2016-02-09 3:54 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 02/16] PM / OPP: Disable OPPs that aren't supported by the regulator Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 03/16] PM / OPP: Introduce dev_pm_opp_get_max_volt_latency() Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 2:30 ` Stephen Boyd 2016-01-28 8:20 ` [PATCH V2 04/16] PM / OPP: Introduce dev_pm_opp_get_max_transition_latency() Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 05/16] PM / OPP: Parse clock-latency and voltage-tolerance for v1 bindings Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 06/16] PM / OPP: Manage device clk Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 07/16] PM / OPP: Add dev_pm_opp_set_rate() Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 2:10 ` Stephen Boyd 2016-02-02 3:38 ` Viresh Kumar 2016-02-02 20:46 ` Stephen Boyd 2016-01-28 8:20 ` [PATCH V2 08/16] cpufreq: dt: Convert few pr_debug/err() calls to dev_dbg/err() Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 09/16] cpufreq: dt: Rename 'need_update' to 'opp_v1' Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 10/16] cpufreq: dt: OPP layers handles clock-latency for V1 bindings as well Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 11/16] cpufreq: dt: Pass regulator name to the OPP core Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 2:34 ` Stephen Boyd 2016-02-02 6:10 ` Viresh Kumar 2016-02-08 22:55 ` Stephen Boyd 2016-02-09 4:10 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 12/16] cpufreq: dt: Unsupported OPPs are already disabled Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 13/16] cpufreq: dt: Reuse dev_pm_opp_get_max_transition_latency() Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 14/16] cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar [this message] 2016-01-28 8:20 ` [PATCH V2 15/16] cpufreq: dt: drop references to DT node Viresh Kumar 2016-02-02 6:11 ` Viresh Kumar 2016-02-08 22:56 ` Stephen Boyd 2016-02-09 4:22 ` Viresh Kumar 2016-01-28 8:20 ` [PATCH V2 16/16] cpufreq: dt: No need to allocate resources anymore Viresh Kumar 2016-01-28 8:20 ` Viresh Kumar 2016-02-02 6:12 ` Viresh Kumar 2016-02-08 22:58 ` Stephen Boyd 2016-01-30 1:48 ` [PATCH V2 00/16] PM / OPP: Introduce APIs to transition OPPs Stephen Boyd 2016-02-01 4:08 ` Viresh Kumar 2016-02-01 19:41 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b0f0134c9d2488db1971d7be4b8bcdc27356eee4.1453965717.git.viresh.kumar@linaro.org \ --to=viresh.kumar@linaro.org \ --cc=linaro-kernel@lists.linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=nm@ti.com \ --cc=rjw@rjwysocki.net \ --cc=sboyd@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.