All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
Cc: Brian Norris
	<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Graham Moore
	<grmoore-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
	Alan Tull
	<atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Dinh Nguyen
	<dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
	Yves Vandervennet
	<yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver.
Date: Mon, 8 Feb 2016 16:27:57 +0100	[thread overview]
Message-ID: <201602081627.57666.marex@denx.de> (raw)
In-Reply-To: <56B879BD.2070608-l0cyMroinI0@public.gmane.org>

On Monday, February 08, 2016 at 12:19:25 PM, Vignesh R wrote:
> On 02/06/2016 01:12 PM, Marek Vasut wrote:
> > On Thursday, February 04, 2016 at 06:30:27 PM, R, Vignesh wrote:
> >> On 2/4/2016 4:55 PM, Marek Vasut wrote:
> [...]
> 
> >> Yeah, there is delay(of few ns) required between writing to
> >> INDIRECTWR_START bit and actually writing data to flash(i.e writesl()
> >> call). This is specific to TI K2G SoC and needs to be tied to the new
> >> binding.
> > 
> > Can't you somehow poll the hardware to check whether or not it's ready
> > instead of adding some random delay ?
> 
> There is no dedicated register to poll as such.
> 
> According to TRM:
> "Wait for couple of cycles of QSPI_REF_CLK(functional clock of QSPI
> @384MHz) until CQSPI_REG_INDIRECTWR[0] bit is internally synchronized by
> the QSPI module before writing to flash".
> 
> So, a few ns(~6ns @384MHz) delay is needed (or accessing a QSPI module
> register should be sufficient as it will take more than 2 clock cycles).
> I believe this delay is specific to TI K2G SoC and maybe needs to be
> tied to the binding.

OK, got it. Dinh/Graham, can you check if this might be needed on SoCFPGA too 
please?

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Vignesh R <vigneshr@ti.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
	Rob Herring <robh@kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Graham Moore <grmoore@opensource.altera.com>,
	Alan Tull <atull@opensource.altera.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Dinh Nguyen <dinguyen@opensource.altera.com>,
	Yves Vandervennet <yvanderv@opensource.altera.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver.
Date: Mon, 8 Feb 2016 16:27:57 +0100	[thread overview]
Message-ID: <201602081627.57666.marex@denx.de> (raw)
In-Reply-To: <56B879BD.2070608@ti.com>

On Monday, February 08, 2016 at 12:19:25 PM, Vignesh R wrote:
> On 02/06/2016 01:12 PM, Marek Vasut wrote:
> > On Thursday, February 04, 2016 at 06:30:27 PM, R, Vignesh wrote:
> >> On 2/4/2016 4:55 PM, Marek Vasut wrote:
> [...]
> 
> >> Yeah, there is delay(of few ns) required between writing to
> >> INDIRECTWR_START bit and actually writing data to flash(i.e writesl()
> >> call). This is specific to TI K2G SoC and needs to be tied to the new
> >> binding.
> > 
> > Can't you somehow poll the hardware to check whether or not it's ready
> > instead of adding some random delay ?
> 
> There is no dedicated register to poll as such.
> 
> According to TRM:
> "Wait for couple of cycles of QSPI_REF_CLK(functional clock of QSPI
> @384MHz) until CQSPI_REG_INDIRECTWR[0] bit is internally synchronized by
> the QSPI module before writing to flash".
> 
> So, a few ns(~6ns @384MHz) delay is needed (or accessing a QSPI module
> register should be sufficient as it will take more than 2 clock cycles).
> I believe this delay is specific to TI K2G SoC and maybe needs to be
> tied to the binding.

OK, got it. Dinh/Graham, can you check if this might be needed on SoCFPGA too 
please?

Best regards,
Marek Vasut

  parent reply	other threads:[~2016-02-08 15:27 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11  4:34 [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver Marek Vasut
2016-01-11  4:34 ` Marek Vasut
2016-01-11 16:06 ` Dinh Nguyen
2016-01-11 16:06   ` Dinh Nguyen
     [not found]   ` <5693D306.9070001-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-01-11 16:32     ` Marek Vasut
2016-01-11 16:32       ` Marek Vasut
     [not found]       ` <201601111732.23954.marex-ynQEQJNshbs@public.gmane.org>
2016-01-11 17:03         ` Dinh Nguyen
2016-01-11 17:03           ` Dinh Nguyen
     [not found]           ` <5693E079.3050301-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-01-11 17:27             ` Marek Vasut
2016-01-11 17:27               ` Marek Vasut
     [not found] ` <1452486886-8049-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2016-01-11  4:34   ` [PATCH V10 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller Marek Vasut
2016-01-11  4:34     ` Marek Vasut
2016-01-11 16:09     ` Dinh Nguyen
2016-01-11 16:09       ` Dinh Nguyen
     [not found]       ` <5693D3B4.2090304-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-01-11 16:32         ` Marek Vasut
2016-01-11 16:32           ` Marek Vasut
2016-01-12  4:41         ` Vignesh R
2016-01-12  4:41           ` Vignesh R
     [not found]           ` <569483DE.4070901-l0cyMroinI0@public.gmane.org>
2016-01-12 13:49             ` Marek Vasut
2016-01-12 13:49               ` Marek Vasut
     [not found]     ` <1452486886-8049-2-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2016-04-06 16:55       ` R, Vignesh
2016-04-06 16:55         ` R, Vignesh
     [not found]         ` <57053F81.70204-l0cyMroinI0@public.gmane.org>
2016-04-06 19:30           ` Marek Vasut
2016-04-06 19:30             ` Marek Vasut
     [not found]             ` <570563D3.9080704-ynQEQJNshbs@public.gmane.org>
2016-04-07  4:55               ` Vignesh R
2016-04-07  4:55                 ` Vignesh R
     [not found]                 ` <5705E858.3050700-l0cyMroinI0@public.gmane.org>
2016-04-13 10:27                   ` Marek Vasut
2016-04-13 10:27                     ` Marek Vasut
2016-04-13 15:06                   ` Marek Vasut
2016-04-13 15:06                     ` Marek Vasut
     [not found]                     ` <570E608C.1030901-ynQEQJNshbs@public.gmane.org>
2016-04-14 16:41                       ` R, Vignesh
2016-04-14 16:41                         ` R, Vignesh
     [not found]                         ` <570FC843.9010403-l0cyMroinI0@public.gmane.org>
2016-04-14 17:46                           ` Marek Vasut
2016-04-14 17:46                             ` Marek Vasut
2016-05-13  0:00       ` Trent Piepho
2016-05-13  0:00         ` Trent Piepho
     [not found]         ` <1463097635.9103.301.camel-dVGoCQn2UwS33l2LyG1otL1RWLrjA2wiZkel5v8DVj8@public.gmane.org>
2016-05-13  0:24           ` Marek Vasut
2016-05-13  0:24             ` Marek Vasut
     [not found]             ` <57351ECE.2020009-ynQEQJNshbs@public.gmane.org>
2016-05-13 20:43               ` Trent Piepho
2016-05-13 20:43                 ` Trent Piepho
     [not found]                 ` <1463172208.9103.313.camel-dVGoCQn2UwS33l2LyG1otL1RWLrjA2wiZkel5v8DVj8@public.gmane.org>
2016-05-25 23:08                   ` Marek Vasut
2016-05-25 23:08                     ` Marek Vasut
2016-05-25 23:02           ` Marek Vasut
2016-05-25 23:02             ` Marek Vasut
2016-01-13  2:26   ` [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver Rob Herring
2016-01-13  2:26     ` Rob Herring
2016-01-13  2:39     ` Marek Vasut
2016-01-13  2:39       ` Marek Vasut
     [not found]       ` <201601130339.17520.marex-ynQEQJNshbs@public.gmane.org>
2016-02-01 21:03         ` Brian Norris
2016-02-01 21:03           ` Brian Norris
     [not found]           ` <20160201210335.GM19540-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-02-01 21:13             ` Marek Vasut
2016-02-01 21:13               ` Marek Vasut
     [not found]               ` <201602012213.46740.marex-ynQEQJNshbs@public.gmane.org>
2016-02-04  7:38                 ` Vignesh R
2016-02-04  7:38                   ` Vignesh R
     [not found]                   ` <56B30007.1010305-l0cyMroinI0@public.gmane.org>
2016-02-04 11:25                     ` Marek Vasut
2016-02-04 11:25                       ` Marek Vasut
     [not found]                       ` <201602041225.11679.marex-ynQEQJNshbs@public.gmane.org>
2016-02-04 17:04                         ` Dinh Nguyen
2016-02-04 17:04                           ` Dinh Nguyen
     [not found]                           ` <56B38488.2000502-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-02-06  7:42                             ` Marek Vasut
2016-02-06  7:42                               ` Marek Vasut
2016-02-04 17:30                         ` R, Vignesh
2016-02-04 17:30                           ` R, Vignesh
     [not found]                           ` <56B38AB3.3070801-l0cyMroinI0@public.gmane.org>
2016-02-06  7:42                             ` Marek Vasut
2016-02-06  7:42                               ` Marek Vasut
     [not found]                               ` <201602060842.38290.marex-ynQEQJNshbs@public.gmane.org>
2016-02-08 11:19                                 ` Vignesh R
2016-02-08 11:19                                   ` Vignesh R
     [not found]                                   ` <56B879BD.2070608-l0cyMroinI0@public.gmane.org>
2016-02-08 15:27                                     ` Marek Vasut [this message]
2016-02-08 15:27                                       ` Marek Vasut
2016-02-10 16:10                                       ` Graham Moore
2016-02-10 16:10                                         ` Graham Moore
     [not found]                                         ` <56BB60F1.9070306-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-02-10 16:17                                           ` Marek Vasut
2016-02-10 16:17                                             ` Marek Vasut
     [not found]                                             ` <56BB629D.2040209-ynQEQJNshbs@public.gmane.org>
2016-03-10 20:55                                               ` Graham Moore
2016-03-10 20:55                                                 ` Graham Moore
     [not found]                                                 ` <56E1DF45.901-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-03-10 21:10                                                   ` Marek Vasut
2016-03-10 21:10                                                     ` Marek Vasut
2016-03-14 18:17                                                     ` Graham Moore
2016-03-14 18:17                                                       ` Graham Moore
     [not found]                                                       ` <56E70024.3080205-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2016-03-14 22:47                                                         ` Marek Vasut
2016-03-14 22:47                                                           ` Marek Vasut
  -- strict thread matches above, loose matches on Subject: below --
2016-06-04  0:39 Marek Vasut
2016-06-04  0:39 ` Marek Vasut
     [not found] ` <1465000774-7762-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2016-06-07 14:00   ` Rob Herring
2016-06-07 14:00     ` Rob Herring
2016-07-18 17:00     ` Brian Norris
2016-07-18 17:00       ` Brian Norris
2015-08-21  9:20 Marek Vasut
2015-08-21  9:20 ` Marek Vasut
     [not found] ` <1440148851-14621-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2015-08-27 17:44   ` vikas
2015-08-27 17:44     ` vikas
     [not found]     ` <55DF4C82.3070708-qxv4g6HH51o@public.gmane.org>
2015-08-27 18:12       ` Marek Vasut
2015-08-27 18:12         ` Marek Vasut
     [not found]         ` <201508272012.51185.marex-ynQEQJNshbs@public.gmane.org>
2015-08-27 20:18           ` vikas
2015-08-27 20:18             ` vikas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201602081627.57666.marex@denx.de \
    --to=marex-ynqeqjnshbs@public.gmane.org \
    --cc=atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
    --cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=grmoore-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
    --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=vigneshr-l0cyMroinI0@public.gmane.org \
    --cc=yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.