From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> To: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>, "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org> Cc: Graham Moore <grmoore-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>, Alan Tull <atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>, Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Dinh Nguyen <dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>, Yves Vandervennet <yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH V10 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller. Date: Wed, 13 Apr 2016 12:27:55 +0200 [thread overview] Message-ID: <570E1F2B.2080003@denx.de> (raw) In-Reply-To: <5705E858.3050700-l0cyMroinI0@public.gmane.org> On 04/07/2016 06:55 AM, Vignesh R wrote: > > > On 04/07/2016 01:00 AM, Marek Vasut wrote: >> On 04/06/2016 06:55 PM, R, Vignesh wrote: >>> Hi Marek, >> >> Hi! >> >>> I encountered a issue with this driver while testing. >> >> Try with the attached patches, I am planning to use them for V11 >> submission. I think you're hitting the problem with missing buslock. >> > > Thanks for the patches. > But I am pretty sure that's not the problem at my end, because I have > only one flash device on QSPI bus. OK, sorry for the delayed reply. I will go through the rest of the QSPI mail later, probably this week. > The problem is cqspi_switch_cs() is called only once ie when JEDEC ID is > being read(during autodetect of chip), but at that instance, > nor->page_size and nor->mtd.erasesize are not yet initialized (They are > initialized only after JEDEC ID is looked up in the table and page_size > and erasesize are known). > Therefore if nor->page_size is printed during cqspi_switch_cs() then its > zero. But nor->page_size reports 256 when printed in cqspi_flash_setup() > after spi_nor_scan(). Therefore CQSPI_REG_SIZE register has to be > configured only after spi_nor struct is fully populated (i.e after > spi_nor_scan() has recognized the slave after JEDEC ID read). > > -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de> To: Vignesh R <vigneshr@ti.com>, "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org> Cc: Graham Moore <grmoore@opensource.altera.com>, Alan Tull <atull@opensource.altera.com>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Dinh Nguyen <dinguyen@opensource.altera.com>, Yves Vandervennet <yvanderv@opensource.altera.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH V10 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller. Date: Wed, 13 Apr 2016 12:27:55 +0200 [thread overview] Message-ID: <570E1F2B.2080003@denx.de> (raw) In-Reply-To: <5705E858.3050700@ti.com> On 04/07/2016 06:55 AM, Vignesh R wrote: > > > On 04/07/2016 01:00 AM, Marek Vasut wrote: >> On 04/06/2016 06:55 PM, R, Vignesh wrote: >>> Hi Marek, >> >> Hi! >> >>> I encountered a issue with this driver while testing. >> >> Try with the attached patches, I am planning to use them for V11 >> submission. I think you're hitting the problem with missing buslock. >> > > Thanks for the patches. > But I am pretty sure that's not the problem at my end, because I have > only one flash device on QSPI bus. OK, sorry for the delayed reply. I will go through the rest of the QSPI mail later, probably this week. > The problem is cqspi_switch_cs() is called only once ie when JEDEC ID is > being read(during autodetect of chip), but at that instance, > nor->page_size and nor->mtd.erasesize are not yet initialized (They are > initialized only after JEDEC ID is looked up in the table and page_size > and erasesize are known). > Therefore if nor->page_size is printed during cqspi_switch_cs() then its > zero. But nor->page_size reports 256 when printed in cqspi_flash_setup() > after spi_nor_scan(). Therefore CQSPI_REG_SIZE register has to be > configured only after spi_nor struct is fully populated (i.e after > spi_nor_scan() has recognized the slave after JEDEC ID read). > > -- Best regards, Marek Vasut
next prev parent reply other threads:[~2016-04-13 10:27 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-11 4:34 [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver Marek Vasut 2016-01-11 4:34 ` Marek Vasut 2016-01-11 16:06 ` Dinh Nguyen 2016-01-11 16:06 ` Dinh Nguyen [not found] ` <5693D306.9070001-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-01-11 16:32 ` Marek Vasut 2016-01-11 16:32 ` Marek Vasut [not found] ` <201601111732.23954.marex-ynQEQJNshbs@public.gmane.org> 2016-01-11 17:03 ` Dinh Nguyen 2016-01-11 17:03 ` Dinh Nguyen [not found] ` <5693E079.3050301-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-01-11 17:27 ` Marek Vasut 2016-01-11 17:27 ` Marek Vasut [not found] ` <1452486886-8049-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org> 2016-01-11 4:34 ` [PATCH V10 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller Marek Vasut 2016-01-11 4:34 ` Marek Vasut 2016-01-11 16:09 ` Dinh Nguyen 2016-01-11 16:09 ` Dinh Nguyen [not found] ` <5693D3B4.2090304-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-01-11 16:32 ` Marek Vasut 2016-01-11 16:32 ` Marek Vasut 2016-01-12 4:41 ` Vignesh R 2016-01-12 4:41 ` Vignesh R [not found] ` <569483DE.4070901-l0cyMroinI0@public.gmane.org> 2016-01-12 13:49 ` Marek Vasut 2016-01-12 13:49 ` Marek Vasut [not found] ` <1452486886-8049-2-git-send-email-marex-ynQEQJNshbs@public.gmane.org> 2016-04-06 16:55 ` R, Vignesh 2016-04-06 16:55 ` R, Vignesh [not found] ` <57053F81.70204-l0cyMroinI0@public.gmane.org> 2016-04-06 19:30 ` Marek Vasut 2016-04-06 19:30 ` Marek Vasut [not found] ` <570563D3.9080704-ynQEQJNshbs@public.gmane.org> 2016-04-07 4:55 ` Vignesh R 2016-04-07 4:55 ` Vignesh R [not found] ` <5705E858.3050700-l0cyMroinI0@public.gmane.org> 2016-04-13 10:27 ` Marek Vasut [this message] 2016-04-13 10:27 ` Marek Vasut 2016-04-13 15:06 ` Marek Vasut 2016-04-13 15:06 ` Marek Vasut [not found] ` <570E608C.1030901-ynQEQJNshbs@public.gmane.org> 2016-04-14 16:41 ` R, Vignesh 2016-04-14 16:41 ` R, Vignesh [not found] ` <570FC843.9010403-l0cyMroinI0@public.gmane.org> 2016-04-14 17:46 ` Marek Vasut 2016-04-14 17:46 ` Marek Vasut 2016-05-13 0:00 ` Trent Piepho 2016-05-13 0:00 ` Trent Piepho [not found] ` <1463097635.9103.301.camel-dVGoCQn2UwS33l2LyG1otL1RWLrjA2wiZkel5v8DVj8@public.gmane.org> 2016-05-13 0:24 ` Marek Vasut 2016-05-13 0:24 ` Marek Vasut [not found] ` <57351ECE.2020009-ynQEQJNshbs@public.gmane.org> 2016-05-13 20:43 ` Trent Piepho 2016-05-13 20:43 ` Trent Piepho [not found] ` <1463172208.9103.313.camel-dVGoCQn2UwS33l2LyG1otL1RWLrjA2wiZkel5v8DVj8@public.gmane.org> 2016-05-25 23:08 ` Marek Vasut 2016-05-25 23:08 ` Marek Vasut 2016-05-25 23:02 ` Marek Vasut 2016-05-25 23:02 ` Marek Vasut 2016-01-13 2:26 ` [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver Rob Herring 2016-01-13 2:26 ` Rob Herring 2016-01-13 2:39 ` Marek Vasut 2016-01-13 2:39 ` Marek Vasut [not found] ` <201601130339.17520.marex-ynQEQJNshbs@public.gmane.org> 2016-02-01 21:03 ` Brian Norris 2016-02-01 21:03 ` Brian Norris [not found] ` <20160201210335.GM19540-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> 2016-02-01 21:13 ` Marek Vasut 2016-02-01 21:13 ` Marek Vasut [not found] ` <201602012213.46740.marex-ynQEQJNshbs@public.gmane.org> 2016-02-04 7:38 ` Vignesh R 2016-02-04 7:38 ` Vignesh R [not found] ` <56B30007.1010305-l0cyMroinI0@public.gmane.org> 2016-02-04 11:25 ` Marek Vasut 2016-02-04 11:25 ` Marek Vasut [not found] ` <201602041225.11679.marex-ynQEQJNshbs@public.gmane.org> 2016-02-04 17:04 ` Dinh Nguyen 2016-02-04 17:04 ` Dinh Nguyen [not found] ` <56B38488.2000502-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-02-06 7:42 ` Marek Vasut 2016-02-06 7:42 ` Marek Vasut 2016-02-04 17:30 ` R, Vignesh 2016-02-04 17:30 ` R, Vignesh [not found] ` <56B38AB3.3070801-l0cyMroinI0@public.gmane.org> 2016-02-06 7:42 ` Marek Vasut 2016-02-06 7:42 ` Marek Vasut [not found] ` <201602060842.38290.marex-ynQEQJNshbs@public.gmane.org> 2016-02-08 11:19 ` Vignesh R 2016-02-08 11:19 ` Vignesh R [not found] ` <56B879BD.2070608-l0cyMroinI0@public.gmane.org> 2016-02-08 15:27 ` Marek Vasut 2016-02-08 15:27 ` Marek Vasut 2016-02-10 16:10 ` Graham Moore 2016-02-10 16:10 ` Graham Moore [not found] ` <56BB60F1.9070306-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-02-10 16:17 ` Marek Vasut 2016-02-10 16:17 ` Marek Vasut [not found] ` <56BB629D.2040209-ynQEQJNshbs@public.gmane.org> 2016-03-10 20:55 ` Graham Moore 2016-03-10 20:55 ` Graham Moore [not found] ` <56E1DF45.901-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-03-10 21:10 ` Marek Vasut 2016-03-10 21:10 ` Marek Vasut 2016-03-14 18:17 ` Graham Moore 2016-03-14 18:17 ` Graham Moore [not found] ` <56E70024.3080205-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-03-14 22:47 ` Marek Vasut 2016-03-14 22:47 ` Marek Vasut
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=570E1F2B.2080003@denx.de \ --to=marex-ynqeqjnshbs@public.gmane.org \ --cc=atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \ --cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \ --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \ --cc=grmoore-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \ --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=vigneshr-l0cyMroinI0@public.gmane.org \ --cc=yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.