All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Valentin <edubezval@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Zhang Rui <rui.zhang@intel.com>,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	spear-devel@list.st.com, Linus Walleij <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] thermal: allow u8500-thermal driver to be a module
Date: Tue, 9 Feb 2016 14:10:27 -0800	[thread overview]
Message-ID: <20160209221026.GD28102@localhost.localdomain> (raw)
In-Reply-To: <20160127073300.GJ3368@x1>

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

On Wed, Jan 27, 2016 at 07:33:00AM +0000, Lee Jones wrote:
> On Mon, 25 Jan 2016, Arnd Bergmann wrote:
> 
> > When the thermal subsystem is a loadable module, the u8500 driver
> > fails to build:
> > 
> > drivers/thermal/built-in.o: In function `db8500_thermal_probe':
> > db8500_thermal.c:(.text+0x96c): undefined reference to `thermal_zone_device_register'
> > drivers/thermal/built-in.o: In function `db8500_thermal_work':
> > db8500_thermal.c:(.text+0xab4): undefined reference to `thermal_zone_device_update'
> > 
> > This changes the symbol to a tristate, so Kconfig can track the
> > dependency correctly.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  drivers/mfd/db8500-prcmu.c | 3 +++
> >  drivers/thermal/Kconfig    | 4 ++--
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> As this touches a core Thermal file, I think it's better off going in
> via that tree.  If that's a problem, I can take it with the relevant
> Acks.
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>


Thanks, I am adding to linux-next to see how it goes.



[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: edubezval@gmail.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] thermal: allow u8500-thermal driver to be a module
Date: Tue, 9 Feb 2016 14:10:27 -0800	[thread overview]
Message-ID: <20160209221026.GD28102@localhost.localdomain> (raw)
In-Reply-To: <20160127073300.GJ3368@x1>

On Wed, Jan 27, 2016 at 07:33:00AM +0000, Lee Jones wrote:
> On Mon, 25 Jan 2016, Arnd Bergmann wrote:
> 
> > When the thermal subsystem is a loadable module, the u8500 driver
> > fails to build:
> > 
> > drivers/thermal/built-in.o: In function `db8500_thermal_probe':
> > db8500_thermal.c:(.text+0x96c): undefined reference to `thermal_zone_device_register'
> > drivers/thermal/built-in.o: In function `db8500_thermal_work':
> > db8500_thermal.c:(.text+0xab4): undefined reference to `thermal_zone_device_update'
> > 
> > This changes the symbol to a tristate, so Kconfig can track the
> > dependency correctly.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  drivers/mfd/db8500-prcmu.c | 3 +++
> >  drivers/thermal/Kconfig    | 4 ++--
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> As this touches a core Thermal file, I think it's better off going in
> via that tree.  If that's a problem, I can take it with the relevant
> Acks.
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>


Thanks, I am adding to linux-next to see how it goes.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160209/3f8a8e06/attachment.sig>

  reply	other threads:[~2016-02-09 22:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 16:44 [PATCH 0/3] randconfig warning fixes for thermal Arnd Bergmann
2016-01-25 16:44 ` Arnd Bergmann
2016-01-25 16:44 ` [PATCH 1/3] thermal: spear: use __maybe_unused for PM functions Arnd Bergmann
2016-01-25 16:44   ` Arnd Bergmann
2016-01-25 16:44 ` [PATCH 2/3] thermal: allow spear-thermal driver to be a module Arnd Bergmann
2016-01-25 16:44   ` Arnd Bergmann
2016-01-25 16:44 ` [PATCH 3/3] thermal: allow u8500-thermal " Arnd Bergmann
2016-01-25 16:44   ` Arnd Bergmann
2016-01-27  7:33   ` Lee Jones
2016-01-27  7:33     ` Lee Jones
2016-02-09 22:10     ` Eduardo Valentin [this message]
2016-02-09 22:10       ` Eduardo Valentin
2016-02-05 14:44   ` Linus Walleij
2016-02-05 14:44     ` Linus Walleij
2016-02-05 14:44     ` Linus Walleij
2016-02-09 22:18 ` [PATCH 0/3] randconfig warning fixes for thermal Eduardo Valentin
2016-02-09 22:18   ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160209221026.GD28102@localhost.localdomain \
    --to=edubezval@gmail.com \
    --cc=arnd@arndb.de \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=spear-devel@list.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.