From: Linus Walleij <linus.walleij@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
spear-devel <spear-devel@list.st.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] thermal: allow u8500-thermal driver to be a module
Date: Fri, 5 Feb 2016 15:44:42 +0100 [thread overview]
Message-ID: <CACRpkdYUERZwbEi6cP=heVk+nzcsrG=evE=AsrOL7onf7bYX-A@mail.gmail.com> (raw)
In-Reply-To: <1453740264-1972562-4-git-send-email-arnd@arndb.de>
On Mon, Jan 25, 2016 at 5:44 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> When the thermal subsystem is a loadable module, the u8500 driver
> fails to build:
>
> drivers/thermal/built-in.o: In function `db8500_thermal_probe':
> db8500_thermal.c:(.text+0x96c): undefined reference to `thermal_zone_device_register'
> drivers/thermal/built-in.o: In function `db8500_thermal_work':
> db8500_thermal.c:(.text+0xab4): undefined reference to `thermal_zone_device_update'
>
> This changes the symbol to a tristate, so Kconfig can track the
> dependency correctly.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] thermal: allow u8500-thermal driver to be a module
Date: Fri, 5 Feb 2016 15:44:42 +0100 [thread overview]
Message-ID: <CACRpkdYUERZwbEi6cP=heVk+nzcsrG=evE=AsrOL7onf7bYX-A@mail.gmail.com> (raw)
In-Reply-To: <1453740264-1972562-4-git-send-email-arnd@arndb.de>
On Mon, Jan 25, 2016 at 5:44 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> When the thermal subsystem is a loadable module, the u8500 driver
> fails to build:
>
> drivers/thermal/built-in.o: In function `db8500_thermal_probe':
> db8500_thermal.c:(.text+0x96c): undefined reference to `thermal_zone_device_register'
> drivers/thermal/built-in.o: In function `db8500_thermal_work':
> db8500_thermal.c:(.text+0xab4): undefined reference to `thermal_zone_device_update'
>
> This changes the symbol to a tristate, so Kconfig can track the
> dependency correctly.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-02-05 14:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 16:44 [PATCH 0/3] randconfig warning fixes for thermal Arnd Bergmann
2016-01-25 16:44 ` Arnd Bergmann
2016-01-25 16:44 ` [PATCH 1/3] thermal: spear: use __maybe_unused for PM functions Arnd Bergmann
2016-01-25 16:44 ` Arnd Bergmann
2016-01-25 16:44 ` [PATCH 2/3] thermal: allow spear-thermal driver to be a module Arnd Bergmann
2016-01-25 16:44 ` Arnd Bergmann
2016-01-25 16:44 ` [PATCH 3/3] thermal: allow u8500-thermal " Arnd Bergmann
2016-01-25 16:44 ` Arnd Bergmann
2016-01-27 7:33 ` Lee Jones
2016-01-27 7:33 ` Lee Jones
2016-02-09 22:10 ` Eduardo Valentin
2016-02-09 22:10 ` Eduardo Valentin
2016-02-05 14:44 ` Linus Walleij [this message]
2016-02-05 14:44 ` Linus Walleij
2016-02-05 14:44 ` Linus Walleij
2016-02-09 22:18 ` [PATCH 0/3] randconfig warning fixes for thermal Eduardo Valentin
2016-02-09 22:18 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYUERZwbEi6cP=heVk+nzcsrG=evE=AsrOL7onf7bYX-A@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=edubezval@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=spear-devel@list.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.