* [PATCH] staging: octeon: Add spaces around operators
@ 2016-02-10 2:26 Janani Ravichandran
2016-02-10 6:21 ` [Outreachy kernel] " Sudip Mukherjee
0 siblings, 1 reply; 3+ messages in thread
From: Janani Ravichandran @ 2016-02-10 2:26 UTC (permalink / raw)
To: outreachy-kernel
Add spaces around operators for better readability. Change suggested by
checkpatch.
Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
---
drivers/staging/octeon/ethernet-tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
index 82abaec..a08ea3f 100644
--- a/drivers/staging/octeon/ethernet-tx.c
+++ b/drivers/staging/octeon/ethernet-tx.c
@@ -419,7 +419,7 @@ dont_put_skbuff_in_hw:
cvmx_fau_fetch_and_add32(FAU_NUM_PACKET_BUFFERS_TO_FREE, 0);
}
- skb_to_free = cvm_oct_adjust_skb_to_free(skb_to_free, priv->fau+qos*4);
+ skb_to_free = cvm_oct_adjust_skb_to_free(skb_to_free, priv->fau + qos * 4);
/*
* If we're sending faster than the receive can free them then
@@ -430,7 +430,7 @@ dont_put_skbuff_in_hw:
if (pko_command.s.dontfree) {
queue_type = QUEUE_CORE;
- pko_command.s.reg0 = priv->fau+qos*4;
+ pko_command.s.reg0 = priv->fau + qos * 4;
} else {
queue_type = QUEUE_HW;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: octeon: Add spaces around operators
2016-02-10 2:26 [PATCH] staging: octeon: Add spaces around operators Janani Ravichandran
@ 2016-02-10 6:21 ` Sudip Mukherjee
2016-02-10 8:44 ` Janani Ravichandran
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2016-02-10 6:21 UTC (permalink / raw)
To: Janani Ravichandran; +Cc: outreachy-kernel
On Tue, Feb 09, 2016 at 09:26:16PM -0500, Janani Ravichandran wrote:
> Add spaces around operators for better readability. Change suggested by
> checkpatch.
>
> Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
> ---
> drivers/staging/octeon/ethernet-tx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
> index 82abaec..a08ea3f 100644
> --- a/drivers/staging/octeon/ethernet-tx.c
> +++ b/drivers/staging/octeon/ethernet-tx.c
> @@ -419,7 +419,7 @@ dont_put_skbuff_in_hw:
> cvmx_fau_fetch_and_add32(FAU_NUM_PACKET_BUFFERS_TO_FREE, 0);
> }
>
> - skb_to_free = cvm_oct_adjust_skb_to_free(skb_to_free, priv->fau+qos*4);
> + skb_to_free = cvm_oct_adjust_skb_to_free(skb_to_free, priv->fau + qos * 4);
oops.. some thing went wrong here. why so much space before 4?
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: octeon: Add spaces around operators
2016-02-10 6:21 ` [Outreachy kernel] " Sudip Mukherjee
@ 2016-02-10 8:44 ` Janani Ravichandran
0 siblings, 0 replies; 3+ messages in thread
From: Janani Ravichandran @ 2016-02-10 8:44 UTC (permalink / raw)
To: outreachy-kernel; +Cc: janani.rvchndrn
[-- Attachment #1.1: Type: text/plain, Size: 146 bytes --]
>
> oops.. some thing went wrong here. why so much space before 4?
>
Sorry, will send version 2 of this now!
Janani.
>
> regards
> sudip
>
[-- Attachment #1.2: Type: text/html, Size: 451 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-10 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-10 2:26 [PATCH] staging: octeon: Add spaces around operators Janani Ravichandran
2016-02-10 6:21 ` [Outreachy kernel] " Sudip Mukherjee
2016-02-10 8:44 ` Janani Ravichandran
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.