All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: rutu.shah.26@gmail.com
Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, mst@redhat.com,
	jasowang@redhat.com, mark.cave-ayland@ilande.co.uk,
	qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com,
	qemu-block@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com,
	samuel.thibault@ens-lyon.org, balrogg@gmail.com,
	alistair.francis@xilinx.com, qemu-arm@nongnu.org,
	pbonzini@redhat.com, cornelia.huck@de.ibm.com, rth@twiddle.net,
	kwolf@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com,
	blauwirbel@gmail.co, qemu-ppc@nongnu.org, imammedo@redhat.com
Subject: Re: [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
Date: Fri, 11 Mar 2016 11:01:47 +0000	[thread overview]
Message-ID: <20160311110147.GE6523@stefanha-x1.localdomain> (raw)
In-Reply-To: <1457638209-14218-1-git-send-email-rutu.shah.26@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

On Fri, Mar 11, 2016 at 01:00:09AM +0530, rutu.shah.26@gmail.com wrote:
> From: Rutuja Shah <rutu.shah.26@gmail.com>

Hi Rutuja,
In addition to the commit message/description issue that Eric raised,
please use scripts/checkpatch.pl to check if your changes cause lines to
exceed 80 characters.

QEMU coding style is 80 characters per line max.  Patches should not
introduce new violations in existing code that follows the coding style.

It might be simplest to address all 80 character line warnings from
checkpatch.pl, even if the existing code already exceeded 80 characters.

Thanks,
Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: rutu.shah.26@gmail.com
Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, mst@redhat.com,
	jasowang@redhat.com, mark.cave-ayland@ilande.co.uk,
	qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com,
	qemu-block@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com,
	samuel.thibault@ens-lyon.org, alistair.francis@xilinx.com,
	qemu-arm@nongnu.org, pbonzini@redhat.com,
	cornelia.huck@de.ibm.com, jsnow@redhat.com, rth@twiddle.net,
	kwolf@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com,
	blauwirbel@gmail.co, qemu-ppc@nongnu.org, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
Date: Fri, 11 Mar 2016 11:01:47 +0000	[thread overview]
Message-ID: <20160311110147.GE6523@stefanha-x1.localdomain> (raw)
In-Reply-To: <1457638209-14218-1-git-send-email-rutu.shah.26@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

On Fri, Mar 11, 2016 at 01:00:09AM +0530, rutu.shah.26@gmail.com wrote:
> From: Rutuja Shah <rutu.shah.26@gmail.com>

Hi Rutuja,
In addition to the commit message/description issue that Eric raised,
please use scripts/checkpatch.pl to check if your changes cause lines to
exceed 80 characters.

QEMU coding style is 80 characters per line max.  Patches should not
introduce new violations in existing code that follows the coding style.

It might be simplest to address all 80 character line warnings from
checkpatch.pl, even if the existing code already exceeded 80 characters.

Thanks,
Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  parent reply	other threads:[~2016-03-11 11:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 19:30 [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com> rutu.shah.26
2016-03-10 19:30 ` [Qemu-devel] " rutu.shah.26
2016-03-10 21:10 ` Eric Blake
2016-03-10 21:10   ` Eric Blake
2016-03-11  6:57   ` rutuja shah
2016-03-11  6:57     ` rutuja shah
2016-03-11 11:01 ` Stefan Hajnoczi [this message]
2016-03-11 11:01   ` Stefan Hajnoczi
2016-03-11 11:44 ` Christian Borntraeger
2016-03-11 11:44   ` [Qemu-devel] " Christian Borntraeger
2016-03-11 12:07   ` Paolo Bonzini
2016-03-11 12:07     ` [Qemu-devel] " Paolo Bonzini
2016-03-11 12:12     ` Christian Borntraeger
2016-03-11 12:12       ` [Qemu-devel] " Christian Borntraeger
2016-03-11 12:26       ` Paolo Bonzini
2016-03-11 12:26         ` [Qemu-devel] " Paolo Bonzini
2016-03-11 13:22         ` Christian Borntraeger
2016-03-11 13:22           ` [Qemu-devel] " Christian Borntraeger
2016-03-12 16:20 ` rutuja shah
2016-03-12 16:20   ` [Qemu-devel] " rutuja shah
2016-03-15 10:08 ` [Qemu-ppc] " Laurent Vivier
2016-03-15 10:08   ` [Qemu-devel] " Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160311110147.GE6523@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=agraf@suse.de \
    --cc=alistair.francis@xilinx.com \
    --cc=armbru@redhat.com \
    --cc=balrogg@gmail.com \
    --cc=blauwirbel@gmail.co \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=rutu.shah.26@gmail.com \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.