All of lore.kernel.org
 help / color / mirror / Atom feed
From: rutuja shah <rutu.shah.26@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com,
	qemu-block@nongnu.org, armbru@redhat.com, borntraeger@de.ibm.com,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	alistair.francis@xilinx.com, qemu-arm@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	imammedo@redhat.com, cornelia.huck@de.ibm.com, rth@twiddle.net,
	kwolf@redhat.com, Alexander Graf <agraf@suse.de>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	blauwirbel@gmail.co, qemu-ppc@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
Date: Fri, 11 Mar 2016 12:27:41 +0530	[thread overview]
Message-ID: <CAFE_T+SHzULT1N14dp_hO=YAe0vhMd2eUK1gMwF1ecWtRGQTjQ@mail.gmail.com> (raw)
In-Reply-To: <56E1E2DB.1020603@redhat.com>

Thanks Eric. I will keep these points in mind while sending patches.
Regards
Rutuja Shah


On Fri, Mar 11, 2016 at 2:40 AM, Eric Blake <eblake@redhat.com> wrote:
> On 03/10/2016 12:30 PM, rutu.shah.26@gmail.com wrote:
>> From: Rutuja Shah <rutu.shah.26@gmail.com>
>>
>
> Your commit message body was botched, cramming everything into the
> subject line.  Be sure you have a one-line summary (preferably shorter
> than 60 characters), then a blank line, before the rest of your
> description and S-o-b.  Also, it's good to say "why" in the commit body,
> not just "what".  Something like:
>
> maint: Drop unused get_ticks_per_sec()
>
> Replace the use of get_ticks_per_sec() with NANOSECONDS_PER_SECOND,
> because...
>
> Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>

WARNING: multiple messages have this Message-ID (diff)
From: rutuja shah <rutu.shah.26@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com,
	qemu-block@nongnu.org, armbru@redhat.com, borntraeger@de.ibm.com,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	alistair.francis@xilinx.com, qemu-arm@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	imammedo@redhat.com, cornelia.huck@de.ibm.com, jsnow@redhat.com,
	rth@twiddle.net, kwolf@redhat.com, Alexander Graf <agraf@suse.de>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	blauwirbel@gmail.co, qemu-ppc@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
Date: Fri, 11 Mar 2016 12:27:41 +0530	[thread overview]
Message-ID: <CAFE_T+SHzULT1N14dp_hO=YAe0vhMd2eUK1gMwF1ecWtRGQTjQ@mail.gmail.com> (raw)
In-Reply-To: <56E1E2DB.1020603@redhat.com>

Thanks Eric. I will keep these points in mind while sending patches.
Regards
Rutuja Shah


On Fri, Mar 11, 2016 at 2:40 AM, Eric Blake <eblake@redhat.com> wrote:
> On 03/10/2016 12:30 PM, rutu.shah.26@gmail.com wrote:
>> From: Rutuja Shah <rutu.shah.26@gmail.com>
>>
>
> Your commit message body was botched, cramming everything into the
> subject line.  Be sure you have a one-line summary (preferably shorter
> than 60 characters), then a blank line, before the rest of your
> description and S-o-b.  Also, it's good to say "why" in the commit body,
> not just "what".  Something like:
>
> maint: Drop unused get_ticks_per_sec()
>
> Replace the use of get_ticks_per_sec() with NANOSECONDS_PER_SECOND,
> because...
>
> Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>

  reply	other threads:[~2016-03-11  6:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 19:30 [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com> rutu.shah.26
2016-03-10 19:30 ` [Qemu-devel] " rutu.shah.26
2016-03-10 21:10 ` Eric Blake
2016-03-10 21:10   ` Eric Blake
2016-03-11  6:57   ` rutuja shah [this message]
2016-03-11  6:57     ` rutuja shah
2016-03-11 11:01 ` Stefan Hajnoczi
2016-03-11 11:01   ` [Qemu-devel] " Stefan Hajnoczi
2016-03-11 11:44 ` Christian Borntraeger
2016-03-11 11:44   ` [Qemu-devel] " Christian Borntraeger
2016-03-11 12:07   ` Paolo Bonzini
2016-03-11 12:07     ` [Qemu-devel] " Paolo Bonzini
2016-03-11 12:12     ` Christian Borntraeger
2016-03-11 12:12       ` [Qemu-devel] " Christian Borntraeger
2016-03-11 12:26       ` Paolo Bonzini
2016-03-11 12:26         ` [Qemu-devel] " Paolo Bonzini
2016-03-11 13:22         ` Christian Borntraeger
2016-03-11 13:22           ` [Qemu-devel] " Christian Borntraeger
2016-03-12 16:20 ` rutuja shah
2016-03-12 16:20   ` [Qemu-devel] " rutuja shah
2016-03-15 10:08 ` [Qemu-ppc] " Laurent Vivier
2016-03-15 10:08   ` [Qemu-devel] " Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFE_T+SHzULT1N14dp_hO=YAe0vhMd2eUK1gMwF1ecWtRGQTjQ@mail.gmail.com' \
    --to=rutu.shah.26@gmail.com \
    --cc=agraf@suse.de \
    --cc=alistair.francis@xilinx.com \
    --cc=armbru@redhat.com \
    --cc=blauwirbel@gmail.co \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=eblake@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.