All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoffer Dall <christoffer.dall@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Andre Przywara <andre.przywara@arm.com>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	arm-mail-list <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 00/16] KVM: arm64: GICv3 ITS emulation
Date: Fri, 18 Mar 2016 10:38:19 +0100	[thread overview]
Message-ID: <20160318093819.GB10806@cbox> (raw)
In-Reply-To: <CAFEAcA8r5LDbNG0XVnHnsoYcrfcpfnR3FQ_u=-L7Dop1HFVgxw@mail.gmail.com>

On Mon, Mar 14, 2016 at 05:29:44PM +0000, Peter Maydell wrote:
> On 14 March 2016 at 11:13, Andre Przywara <andre.przywara@arm.com> wrote:
> > So I see two ways to fix this:
> > 1.) we find a KVM specific way of letting userland save and restore the
> > ITS tables directly
> > 2.) we implement the BASER<n> registers, but still use our "cache" for
> > normal operations. On demand we would serialize KVM's virtual ITS data
> > structures and put them into the guest's memory, so they could be
> > saved/restored from there.
> 
> I feel like we're rehashing a bunch of design choices we talked
> through way back in the last-but-one Connect. I don't suppose
> anybody wrote down our rationales from back then?

Someone (not me) had the task to write it down, I don't recall if that
happened or not :)

> 
> (In particular I forget whether we decided the ITS tables were
> large enough to need to allow some sort of before-the-VM-stops
> migration of the data, which would be relatively doable with
> option 2 but painful under option 1.)

I think we concluded that it's not so much data that applying dirty
bitmaps stuff on there is strictly necessary, but that being able to do
this was probably a plus, and not very hard to do.

I am quite sure that we dismissed option 1, and were decided on option 2
though.

-Christoffer

WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 00/16] KVM: arm64: GICv3 ITS emulation
Date: Fri, 18 Mar 2016 10:38:19 +0100	[thread overview]
Message-ID: <20160318093819.GB10806@cbox> (raw)
In-Reply-To: <CAFEAcA8r5LDbNG0XVnHnsoYcrfcpfnR3FQ_u=-L7Dop1HFVgxw@mail.gmail.com>

On Mon, Mar 14, 2016 at 05:29:44PM +0000, Peter Maydell wrote:
> On 14 March 2016 at 11:13, Andre Przywara <andre.przywara@arm.com> wrote:
> > So I see two ways to fix this:
> > 1.) we find a KVM specific way of letting userland save and restore the
> > ITS tables directly
> > 2.) we implement the BASER<n> registers, but still use our "cache" for
> > normal operations. On demand we would serialize KVM's virtual ITS data
> > structures and put them into the guest's memory, so they could be
> > saved/restored from there.
> 
> I feel like we're rehashing a bunch of design choices we talked
> through way back in the last-but-one Connect. I don't suppose
> anybody wrote down our rationales from back then?

Someone (not me) had the task to write it down, I don't recall if that
happened or not :)

> 
> (In particular I forget whether we decided the ITS tables were
> large enough to need to allow some sort of before-the-VM-stops
> migration of the data, which would be relatively doable with
> option 2 but painful under option 1.)

I think we concluded that it's not so much data that applying dirty
bitmaps stuff on there is strictly necessary, but that being able to do
this was probably a plus, and not very hard to do.

I am quite sure that we dismissed option 1, and were decided on option 2
though.

-Christoffer

  parent reply	other threads:[~2016-03-18  9:38 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 14:55 [PATCH v3 00/16] KVM: arm64: GICv3 ITS emulation Andre Przywara
2015-10-07 14:55 ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 01/16] KVM: arm/arm64: VGIC: don't track used LRs in the distributor Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 02/16] KVM: arm/arm64: remove now unused code after stay-in-LR rework Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 03/16] KVM: extend struct kvm_msi to hold a 32-bit device ID Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 04/16] KVM: arm/arm64: add emulation model specific destroy function Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 05/16] KVM: arm/arm64: extend arch CAP checks to allow per-VM capabilities Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 06/16] KVM: arm/arm64: make GIC frame address initialization model specific Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 07/16] KVM: arm64: Introduce new MMIO region for the ITS base address Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 08/16] KVM: arm64: handle ITS related GICv3 redistributor registers Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-22 15:46   ` Pavel Fedin
2015-10-22 15:46     ` Pavel Fedin
2015-10-22 15:55     ` Pavel Fedin
2015-10-22 15:55       ` Pavel Fedin
2015-10-07 14:55 ` [PATCH v3 09/16] KVM: arm64: introduce ITS emulation file with stub functions Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 10/16] KVM: arm64: implement basic ITS register handlers Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 11/16] KVM: arm64: add data structures to model ITS interrupt translation Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 12/16] KVM: arm64: handle pending bit for LPIs in ITS emulation Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 15:10   ` Pavel Fedin
2015-10-07 15:10     ` Pavel Fedin
2015-10-07 15:35     ` Marc Zyngier
2015-10-07 15:35       ` Marc Zyngier
2015-10-07 15:46       ` Pavel Fedin
2015-10-07 15:46         ` Pavel Fedin
2015-10-07 15:49         ` Marc Zyngier
2015-10-07 15:49           ` Marc Zyngier
2015-10-12  7:40   ` Pavel Fedin
2015-10-12  7:40     ` Pavel Fedin
2015-10-12 11:39     ` Pavel Fedin
2015-10-12 11:39       ` Pavel Fedin
2015-10-12 14:17     ` Andre Przywara
2015-10-12 14:17       ` Andre Przywara
2015-10-07 14:55 ` [PATCH v3 13/16] KVM: arm64: sync LPI configuration and pending tables Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-21 11:29   ` Pavel Fedin
2015-10-21 11:29     ` Pavel Fedin
2015-10-07 14:55 ` [PATCH v3 14/16] KVM: arm64: implement ITS command queue command handlers Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-14 12:26   ` Pavel Fedin
2015-10-14 12:26     ` Pavel Fedin
2015-10-07 14:55 ` [PATCH v3 15/16] KVM: arm64: implement MSI injection in ITS emulation Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-11-25 13:28   ` Pavel Fedin
2015-11-25 13:28     ` Pavel Fedin
2015-10-07 14:55 ` [PATCH v3 16/16] KVM: arm64: enable ITS emulation as a virtual MSI controller Andre Przywara
2015-10-07 14:55   ` Andre Przywara
2015-10-07 16:05 ` [PATCH v3 00/16] KVM: arm64: GICv3 ITS emulation Pavel Fedin
2015-10-07 16:05   ` Pavel Fedin
2015-10-07 16:22   ` Marc Zyngier
2015-10-07 16:22     ` Marc Zyngier
2015-10-07 18:09     ` Pavel Fedin
2015-10-07 18:09       ` Pavel Fedin
2015-10-07 19:48       ` Marc Zyngier
2015-10-07 19:48         ` Marc Zyngier
2015-10-07 19:48         ` Marc Zyngier
2015-10-08  8:41         ` Pavel Fedin
2015-10-08  8:41           ` Pavel Fedin
2015-10-10 15:37 ` Christoffer Dall
2015-10-10 15:37   ` Christoffer Dall
2015-10-12 14:12   ` Andre Przywara
2015-10-12 14:12     ` Andre Przywara
2015-10-12 15:18     ` Pavel Fedin
2015-10-12 15:18       ` Pavel Fedin
2015-10-14  8:48       ` Eric Auger
2015-10-14  8:48         ` Eric Auger
2015-10-14  8:50         ` Pavel Fedin
2015-10-14  8:50           ` Pavel Fedin
2015-10-13 15:46 ` Pavel Fedin
2015-10-13 15:46   ` Pavel Fedin
2016-03-09 11:35 ` Tomasz Nowicki
2016-03-09 11:35   ` Tomasz Nowicki
2016-03-13 18:16   ` Christoffer Dall
2016-03-13 18:16     ` Christoffer Dall
2016-03-14 11:13     ` Andre Przywara
2016-03-14 11:13       ` Andre Przywara
2016-03-14 17:29       ` Peter Maydell
2016-03-14 17:29         ` Peter Maydell
2016-03-14 17:54         ` Marc Zyngier
2016-03-14 17:54           ` Marc Zyngier
2016-03-14 18:20           ` Andre Przywara
2016-03-14 18:20             ` Andre Przywara
2016-03-14 18:36             ` Marc Zyngier
2016-03-14 18:36               ` Marc Zyngier
2016-03-18  9:40             ` Christoffer Dall
2016-03-18  9:40               ` Christoffer Dall
2016-03-18 17:14               ` Peter Maydell
2016-03-18 17:14                 ` Peter Maydell
2016-03-18  9:38         ` Christoffer Dall [this message]
2016-03-18  9:38           ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160318093819.GB10806@cbox \
    --to=christoffer.dall@linaro.org \
    --cc=andre.przywara@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=peter.maydell@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.