All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	sergey.senozhatsky@gmail.com, sergey.senozhatsky.work@gmail.com,
	eunb.song@samsung.com, minchan@kernel.org, chanho.min@lge.com,
	kyungsik.lee@lge.com, stable@vger.kernel.org
Subject: Re: [PATCH] lib: lz4: fixed zram with lz4 on big endian machines
Date: Fri, 8 Apr 2016 09:50:51 -0700	[thread overview]
Message-ID: <20160408165051.GB16346@kroah.com> (raw)
In-Reply-To: <1460129004-2011-1-git-send-email-rsalvaterra@gmail.com>

On Fri, Apr 08, 2016 at 04:23:24PM +0100, Rui Salvaterra wrote:
> Based on Sergey's test patch [1], this fixes zram with lz4 compression on big endian cpus. Tested on ppc64 with no regression on x86_64.

Please wrap your text at 72 columns in a changelog comment.

> 
> [1] http://marc.info/?l=linux-kernel&m=145994470805853&w=4
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>

Please attribute Sergey here in the signed-off-by area with a
"Suggested-by:" type mark

> ---
>  lib/lz4/lz4defs.h | 29 +++++++++++++++--------------
>  1 file changed, 15 insertions(+), 14 deletions(-)
> 
> diff --git a/lib/lz4/lz4defs.h b/lib/lz4/lz4defs.h
> index abcecdc..a98c08c 100644
> --- a/lib/lz4/lz4defs.h
> +++ b/lib/lz4/lz4defs.h
> @@ -11,8 +11,7 @@
>  /*
>   * Detects 64 bits mode
>   */
> -#if (defined(__x86_64__) || defined(__x86_64) || defined(__amd64__) \
> -	|| defined(__ppc64__) || defined(__LP64__))
> +#if defined(CONFIG_64BIT)

This patch seems to do two different things, clean up the #if tests, and
change the endian of some calls.  Can you break this up into 2 different
patches?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	sergey.senozhatsky@gmail.com, sergey.senozhatsky.work@gmail.com,
	eunb.song@samsung.com, minchan@kernel.org, chanho.min@lge.com,
	kyungsik.lee@lge.com, stable@vger.kernel.org
Subject: Re: [PATCH] lib: lz4: fixed zram with lz4 on big endian machines
Date: Fri, 8 Apr 2016 09:50:51 -0700	[thread overview]
Message-ID: <20160408165051.GB16346@kroah.com> (raw)
In-Reply-To: <1460129004-2011-1-git-send-email-rsalvaterra@gmail.com>

On Fri, Apr 08, 2016 at 04:23:24PM +0100, Rui Salvaterra wrote:
> Based on Sergey's test patch [1], this fixes zram with lz4 compression on big endian cpus. Tested on ppc64 with no regression on x86_64.

Please wrap your text at 72 columns in a changelog comment.

> 
> [1] http://marc.info/?l=linux-kernel&m=145994470805853&w=4
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>

Please attribute Sergey here in the signed-off-by area with a
"Suggested-by:" type mark

> ---
>  lib/lz4/lz4defs.h | 29 +++++++++++++++--------------
>  1 file changed, 15 insertions(+), 14 deletions(-)
> 
> diff --git a/lib/lz4/lz4defs.h b/lib/lz4/lz4defs.h
> index abcecdc..a98c08c 100644
> --- a/lib/lz4/lz4defs.h
> +++ b/lib/lz4/lz4defs.h
> @@ -11,8 +11,7 @@
>  /*
>   * Detects 64 bits mode
>   */
> -#if (defined(__x86_64__) || defined(__x86_64) || defined(__amd64__) \
> -	|| defined(__ppc64__) || defined(__LP64__))
> +#if defined(CONFIG_64BIT)

This patch seems to do two different things, clean up the #if tests, and
change the endian of some calls.  Can you break this up into 2 different
patches?

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-04-08 16:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 15:23 [PATCH] lib: lz4: fixed zram with lz4 on big endian machines Rui Salvaterra
2016-04-08 15:23 ` Rui Salvaterra
2016-04-08 16:50 ` Greg KH [this message]
2016-04-08 16:50   ` Greg KH
2016-04-08 19:51   ` Rui Salvaterra
2016-04-08 20:05     ` Greg KH
2016-04-08 20:05       ` Greg KH
2016-04-08 20:05       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160408165051.GB16346@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chanho.min@lge.com \
    --cc=eunb.song@samsung.com \
    --cc=kyungsik.lee@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=rsalvaterra@gmail.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.