* [LTP] [PATCH] ptrace/ptrace05: preventing kill other processes if fork failed
@ 2016-04-12 3:07 Han Pingtian
2016-04-12 10:08 ` Cyril Hrubis
0 siblings, 1 reply; 4+ messages in thread
From: Han Pingtian @ 2016-04-12 3:07 UTC (permalink / raw)
To: ltp
If fork failed, we should try next signum. Or the kill(-1, 9) on line
196 will kill a lot of processes.
Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
---
testcases/kernel/syscalls/ptrace/ptrace05.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/ptrace/ptrace05.c b/testcases/kernel/syscalls/ptrace/ptrace05.c
index d610cc0..e717319 100644
--- a/testcases/kernel/syscalls/ptrace/ptrace05.c
+++ b/testcases/kernel/syscalls/ptrace/ptrace05.c
@@ -99,7 +99,7 @@ int main(int argc, char **argv)
switch (child = fork()) {
case -1:
tst_resm(TBROK | TERRNO, "Failed to fork properly.");
- break;
+ continue;
case 0:
if (ptrace(PTRACE_TRACEME, 0, NULL, NULL) != -1) {
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [LTP] [PATCH] ptrace/ptrace05: preventing kill other processes if fork failed
2016-04-12 3:07 [LTP] [PATCH] ptrace/ptrace05: preventing kill other processes if fork failed Han Pingtian
@ 2016-04-12 10:08 ` Cyril Hrubis
2016-04-12 13:19 ` Han Pingtian
0 siblings, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2016-04-12 10:08 UTC (permalink / raw)
To: ltp
Hi!
> If fork failed, we should try next signum. Or the kill(-1, 9) on line
> 196 will kill a lot of processes.
>
> Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> ---
> testcases/kernel/syscalls/ptrace/ptrace05.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/ptrace/ptrace05.c b/testcases/kernel/syscalls/ptrace/ptrace05.c
> index d610cc0..e717319 100644
> --- a/testcases/kernel/syscalls/ptrace/ptrace05.c
> +++ b/testcases/kernel/syscalls/ptrace/ptrace05.c
> @@ -99,7 +99,7 @@ int main(int argc, char **argv)
> switch (child = fork()) {
> case -1:
> tst_resm(TBROK | TERRNO, "Failed to fork properly.");
> - break;
> + continue;
I would just change this to tst_brkm(). There is no point in continuing
the test if fork() starts failing.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH] ptrace/ptrace05: preventing kill other processes if fork failed
2016-04-12 10:08 ` Cyril Hrubis
@ 2016-04-12 13:19 ` Han Pingtian
2016-04-12 15:42 ` Cyril Hrubis
0 siblings, 1 reply; 4+ messages in thread
From: Han Pingtian @ 2016-04-12 13:19 UTC (permalink / raw)
To: ltp
On Tue, Apr 12, 2016 at 12:08:59PM +0200, Cyril Hrubis wrote:
> Hi!
> > If fork failed, we should try next signum. Or the kill(-1, 9) on line
> > 196 will kill a lot of processes.
> >
> > Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> > ---
> > testcases/kernel/syscalls/ptrace/ptrace05.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/testcases/kernel/syscalls/ptrace/ptrace05.c b/testcases/kernel/syscalls/ptrace/ptrace05.c
> > index d610cc0..e717319 100644
> > --- a/testcases/kernel/syscalls/ptrace/ptrace05.c
> > +++ b/testcases/kernel/syscalls/ptrace/ptrace05.c
> > @@ -99,7 +99,7 @@ int main(int argc, char **argv)
> > switch (child = fork()) {
> > case -1:
> > tst_resm(TBROK | TERRNO, "Failed to fork properly.");
> > - break;
> > + continue;
>
> I would just change this to tst_brkm(). There is no point in continuing
> the test if fork() starts failing.
>
Please review the new patch. Thanks.
From ee7ba40a79644a9039d0cc581f78e8708aef8b06 Mon Sep 17 00:00:00 2001
From: Han Pingtian <hanpt@linux.vnet.ibm.com>
Date: Tue, 12 Apr 2016 09:13:57 +0800
Subject: [PATCH] ptrace/ptrace05: preventing kill other processes if fork
failed
If fork failed, we should try next signum. Or the kill(-1, 9) on line
196 will kill a lot of processes.
Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
---
testcases/kernel/syscalls/ptrace/ptrace05.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/ptrace/ptrace05.c b/testcases/kernel/syscalls/ptrace/ptrace05.c
index d610cc0..db611e7 100644
--- a/testcases/kernel/syscalls/ptrace/ptrace05.c
+++ b/testcases/kernel/syscalls/ptrace/ptrace05.c
@@ -98,8 +98,8 @@ int main(int argc, char **argv)
switch (child = fork()) {
case -1:
- tst_resm(TBROK | TERRNO, "Failed to fork properly.");
- break;
+ tst_brkm(TBROK | TERRNO, NULL,
+ "Failed to fork properly.");
case 0:
if (ptrace(PTRACE_TRACEME, 0, NULL, NULL) != -1) {
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [LTP] [PATCH] ptrace/ptrace05: preventing kill other processes if fork failed
2016-04-12 13:19 ` Han Pingtian
@ 2016-04-12 15:42 ` Cyril Hrubis
0 siblings, 0 replies; 4+ messages in thread
From: Cyril Hrubis @ 2016-04-12 15:42 UTC (permalink / raw)
To: ltp
Hi!
> If fork failed, we should try next signum. Or the kill(-1, 9) on line
> 196 will kill a lot of processes.
I've shortened the error message a bit and pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-12 15:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-12 3:07 [LTP] [PATCH] ptrace/ptrace05: preventing kill other processes if fork failed Han Pingtian
2016-04-12 10:08 ` Cyril Hrubis
2016-04-12 13:19 ` Han Pingtian
2016-04-12 15:42 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.