All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Tony Luck <tony.luck@gmail.com>,
	"Luck, Tony" <tony.luck@intel.com>
Subject: Re: [PATCH 2/2] efi: Remove global 'memmap'
Date: Tue, 12 Apr 2016 21:01:19 +0100	[thread overview]
Message-ID: <20160412200119.GH2829@codeblueprint.co.uk> (raw)
In-Reply-To: <CAKv+Gu-xUzbxzpTa_E_HjZcSXW+DdhasFDP1n-w-AzuDjvp6FA@mail.gmail.com>

On Mon, 11 Apr, at 03:17:55PM, Ard Biesheuvel wrote:
> > diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
> > index 1cfbfaf57a2d..0416d5d33e74 100644
> > --- a/drivers/firmware/efi/arm-runtime.c
> > +++ b/drivers/firmware/efi/arm-runtime.c
> > @@ -89,6 +89,7 @@ static bool __init efi_virtmap_init(void)
> >   */
> >  static int __init arm_enable_runtime_services(void)
> >  {
> > +       phys_addr_t phys_map;
> 
> Is the sole purpose of this variable to prevent breaking the 80-column rule?
 
Indeed it is.

> If so, please be aware that I intend to propose a patch that replaces
> the ioremap_cache() below with a call to memremap(), but this is
> another change that is gated by Russell merging my memremap patches
> for ARM

OK. Would you like me to drop this particular hunk and just go with,

	efi.memmap.map = (__force void *)ioremap_cache(efi.memmap.phys_map,
						       mapsize);

if you're going to rewrite it soon anyway?

WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Tony Luck <tony.luck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Luck, Tony" <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 2/2] efi: Remove global 'memmap'
Date: Tue, 12 Apr 2016 21:01:19 +0100	[thread overview]
Message-ID: <20160412200119.GH2829@codeblueprint.co.uk> (raw)
In-Reply-To: <CAKv+Gu-xUzbxzpTa_E_HjZcSXW+DdhasFDP1n-w-AzuDjvp6FA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Mon, 11 Apr, at 03:17:55PM, Ard Biesheuvel wrote:
> > diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
> > index 1cfbfaf57a2d..0416d5d33e74 100644
> > --- a/drivers/firmware/efi/arm-runtime.c
> > +++ b/drivers/firmware/efi/arm-runtime.c
> > @@ -89,6 +89,7 @@ static bool __init efi_virtmap_init(void)
> >   */
> >  static int __init arm_enable_runtime_services(void)
> >  {
> > +       phys_addr_t phys_map;
> 
> Is the sole purpose of this variable to prevent breaking the 80-column rule?
 
Indeed it is.

> If so, please be aware that I intend to propose a patch that replaces
> the ioremap_cache() below with a call to memremap(), but this is
> another change that is gated by Russell merging my memremap patches
> for ARM

OK. Would you like me to drop this particular hunk and just go with,

	efi.memmap.map = (__force void *)ioremap_cache(efi.memmap.phys_map,
						       mapsize);

if you're going to rewrite it soon anyway?

  reply	other threads:[~2016-04-12 20:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 13:03 [PATCH 0/2] efi: Delete global 'memmap' variable Matt Fleming
2016-04-11 13:03 ` Matt Fleming
2016-04-11 13:03 ` [PATCH 1/2] efi: Iterate over efi->memmap in for_each_efi_memory_desc Matt Fleming
2016-04-11 13:03   ` Matt Fleming
2016-04-11 13:24   ` kbuild test robot
2016-04-11 13:24     ` kbuild test robot
2016-04-11 13:27   ` kbuild test robot
2016-04-11 13:27     ` kbuild test robot
2016-04-11 13:03 ` [PATCH 2/2] efi: Remove global 'memmap' Matt Fleming
2016-04-11 13:03   ` Matt Fleming
2016-04-11 13:17   ` Ard Biesheuvel
2016-04-12 20:01     ` Matt Fleming [this message]
2016-04-12 20:01       ` Matt Fleming
2016-04-13  8:12       ` Ard Biesheuvel
2016-04-13  8:12         ` Ard Biesheuvel
2016-04-13 10:24         ` Matt Fleming
2016-04-13 10:24           ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160412200119.GH2829@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=ard.biesheuvel@linaro.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.