All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 00/11 v3] xfs: inode reclaim vs the world
Date: Wed, 13 Apr 2016 08:38:38 -0700	[thread overview]
Message-ID: <20160413153838.GC18517@birch.djwong.org> (raw)
In-Reply-To: <1460525492-1170-1-git-send-email-david@fromorbit.com>

> Subject: Re: [PATCH 00/11 v3] xfs: inode reclaim vs the world

Does it also have to defeat seven evil X's? ;)

--D

On Wed, Apr 13, 2016 at 03:31:21PM +1000, Dave Chinner wrote:
> Hi folks,
> 
> The inode reclaim patchset has grown somewhat larger with all the
> fixes I've accrued over the past couple of days for issues that have
> been reported. I've just re-ordered the patchset to have all the bug
> fixes that need to go into 4.6-rc up front, followed by other bug
> fixes, followed by all the cleanups I wrote as I went along fixing
> things. I want to get this out before LSFMM, so I'm posting this
> before I've done a full verification that I've got the patches
> correct, and they are still running through xfstests right now.
> 
> Patch 1 is new - it fixes a regression introduced in 4.6-rc1 and is
> caused by clearing the vfs inode i_mode in ->evict_inode, when there
> is code in evict() that requires the mode to be intact until
> ->destroy_inode.
> 
> Patch 2 is new - if fixes the inode log item leak that left a dirty
> log item on the AIL after the inode had been reclaimed, resulting in
> unmountable filesystems and a couple of use-after-free vectors.
> 
> Patch 3 is the original fix for the xfs_iflush_cluster lookup
> validity checks that were incorect
> 
> Patch 4 is the original fix for avoiding flushing stale inodes.
> 
> Patch 5 is new, and comes from Alex @ Zadara to avoid having to
> reallocate memory when tearing down the inode extent lists. This is
> a necessary pre-requisite for patch 6.
> 
> Patch 6 is the original patch that pushed all the inode memory
> freeing into the RCU callback, so that xfs_iflush_cluster didn't
> reference freed memory when racing with reclaim.
> 
> Patch 7 is the original patch that made reclaim races eaasier to
> detect.
> 
> Patch 8 is the original patch that drops out of xfs-iflush_cluster
> on the first inode beyond the end of the current cluster.
> 
> Patch 9 is the original patch that renames the variables in
> xfs_iflush_cluster().
> 
> Patch 10 and 11 are new patches that simplify the inode reclaim
> tagging interfaces to remove dependencies on the struct xfs_inode
> and the inode number where they are not actually required.
> 
> -Dave.
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2016-04-13 15:38 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  5:31 [PATCH 00/11 v3] xfs: inode reclaim vs the world Dave Chinner
2016-04-13  5:31 ` [PATCH 01/11] xfs: we don't need no steekin ->evict_inode Dave Chinner
2016-04-13 16:41   ` Christoph Hellwig
2016-04-13 21:20     ` Dave Chinner
2016-04-14 12:10   ` Brian Foster
2016-04-13  5:31 ` [PATCH 02/11] xfs: xfs_iflush_cluster fails to abort on error Dave Chinner
2016-04-13 16:41   ` Christoph Hellwig
2016-04-13  5:31 ` [PATCH 03/11] xfs: fix inode validity check in xfs_iflush_cluster Dave Chinner
2016-04-13  5:31 ` [PATCH 04/11] xfs: skip stale inodes " Dave Chinner
2016-04-13  5:31 ` [PATCH 05/11] xfs: optimise xfs_iext_destroy Dave Chinner
2016-04-13 16:45   ` Christoph Hellwig
2016-04-13  5:31 ` [PATCH 06/11] xfs: xfs_inode_free() isn't RCU safe Dave Chinner
2016-04-13  5:31 ` [PATCH 07/11] xfs: mark reclaimed inodes invalid earlier Dave Chinner
2016-04-13  6:49   ` Dave Chinner
2016-04-14 12:10     ` Brian Foster
2016-04-14 23:31       ` Dave Chinner
2016-04-15 12:46         ` Brian Foster
2016-04-13  5:31 ` [PATCH 08/11] xfs: xfs_iflush_cluster has range issues Dave Chinner
2016-04-13  5:31 ` [PATCH 09/11] xfs: rename variables in xfs_iflush_cluster for clarity Dave Chinner
2016-04-13  5:31 ` [PATCH 10/11] xfs: simplify inode reclaim tagging interfaces Dave Chinner
2016-04-14 12:10   ` Brian Foster
2016-06-29  4:21   ` Darrick J. Wong
2016-04-13  5:31 ` [PATCH 11/11] xfs: move reclaim tagging functions Dave Chinner
2016-04-14 12:11   ` Brian Foster
2016-04-13 15:38 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160413153838.GC18517@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.