All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	arm@kernel.org, Kevin Hilman <khilman@baylibre.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] Qualcomm Driver Updates for v4.7
Date: Wed, 13 Apr 2016 11:41:34 -0700	[thread overview]
Message-ID: <20160413184134.GJ19945@localhost> (raw)
In-Reply-To: <20160413182156.GE14441@codeaurora.org>

On Wed, Apr 13, 2016 at 11:21:56AM -0700, Stephen Boyd wrote:
> On 04/13, Olof Johansson wrote:
> > THis does:
> > 
> > -config ARCH_MSM8974
> > -       bool "Enable support for MSM8974"
> > -       select HAVE_ARM_ARCH_TIMER
> > 
> > 
> > ... and I don't see the HAVE_ARCH_ARM_TIMER added anywhere. So it looks
> > like you might need to pick it for ARCH_QCOM_A_FAMILY now?
> > 
> 
> That was part of the original series[1]. Splitting up patches
> into topic branches is problematic here it seems.
> 
> [1] http://lkml.kernel.org/r/1448485478-21699-3-git-send-email-sboyd@codeaurora.org

The HAVE.* options are usually expected to be set through selects, not
necessarily driven by a user choosing them. So I think adding a select here is
the right way to do it.

HAVE.* options are usually used for dependencies for the user-exposed options.
I.e. only ask if you want arch timers if HAVE_ARM_ARCH_TIMERS is set, etc.


-Olof

WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] Qualcomm Driver Updates for v4.7
Date: Wed, 13 Apr 2016 11:41:34 -0700	[thread overview]
Message-ID: <20160413184134.GJ19945@localhost> (raw)
In-Reply-To: <20160413182156.GE14441@codeaurora.org>

On Wed, Apr 13, 2016 at 11:21:56AM -0700, Stephen Boyd wrote:
> On 04/13, Olof Johansson wrote:
> > THis does:
> > 
> > -config ARCH_MSM8974
> > -       bool "Enable support for MSM8974"
> > -       select HAVE_ARM_ARCH_TIMER
> > 
> > 
> > ... and I don't see the HAVE_ARCH_ARM_TIMER added anywhere. So it looks
> > like you might need to pick it for ARCH_QCOM_A_FAMILY now?
> > 
> 
> That was part of the original series[1]. Splitting up patches
> into topic branches is problematic here it seems.
> 
> [1] http://lkml.kernel.org/r/1448485478-21699-3-git-send-email-sboyd at codeaurora.org

The HAVE.* options are usually expected to be set through selects, not
necessarily driven by a user choosing them. So I think adding a select here is
the right way to do it.

HAVE.* options are usually used for dependencies for the user-exposed options.
I.e. only ask if you want arch timers if HAVE_ARM_ARCH_TIMERS is set, etc.


-Olof

  reply	other threads:[~2016-04-13 18:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 19:59 [GIT PULL] Qualcomm Driver Updates for v4.7 Andy Gross
2016-04-01 19:59 ` Andy Gross
2016-04-13 18:10 ` Olof Johansson
2016-04-13 18:10   ` Olof Johansson
2016-04-13 18:21   ` Stephen Boyd
2016-04-13 18:21     ` Stephen Boyd
2016-04-13 18:41     ` Olof Johansson [this message]
2016-04-13 18:41       ` Olof Johansson
2016-04-13 19:11       ` Stephen Boyd
2016-04-13 19:11         ` Stephen Boyd
2016-04-16 19:59         ` Arnd Bergmann
2016-04-16 19:59           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160413184134.GJ19945@localhost \
    --to=olof@lixom.net \
    --cc=andy.gross@linaro.org \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.