All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Stephen Boyd <sboyd@codeaurora.org>,
	Olof Johansson <olof@lixom.net>,
	Kevin Hilman <khilman@baylibre.com>,
	arm@kernel.org, linux-arm-msm@vger.kernel.org,
	Andy Gross <andy.gross@linaro.org>
Subject: Re: [GIT PULL] Qualcomm Driver Updates for v4.7
Date: Sat, 16 Apr 2016 21:59:16 +0200	[thread overview]
Message-ID: <6572897.TrNljr4Es3@wuerfel> (raw)
In-Reply-To: <20160413191108.GF14441@codeaurora.org>

On Wednesday 13 April 2016 12:11:08 Stephen Boyd wrote:
> 
> Honestly, I view these clocksource selects as the only blocker in
> the effort to get rid of machine type Kconfigs. Maybe that isn't
> a good goal though.

I agree with you, it would be nice if we could just make them
all configurable and not need any machine type Kconfigs (though
a lot of platforms will continue using them for other reasons).

A patch like the one below (as I think you suggested) would be
nice too, but requires people to update their defconfig files.
In the mainline kernel, we have four defconfig files that
enable CONFIG_HAVE_ARM_ARCH_TIMER manually, so those all need
to be changed along with the Kconfig files, and everyone that
has their own out of tree defconfig file (not a full .config)
runs into the same issue.

It's probably still worth doing the change, but it's not obvious.

	Arnd


diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 62c209504c0a..0daad62cfce5 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1296,7 +1296,6 @@ config HAVE_ARM_SCU
 	  This option enables support for the ARM system coherency unit
 
 config HAVE_ARM_ARCH_TIMER
-	bool "Architected timer support"
 	depends on CPU_V7
 	select ARM_ARCH_TIMER
 	select GENERIC_CLOCKEVENTS
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index c346be650892..0314778c992f 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -187,7 +187,7 @@ config CLKSRC_STM32
 	select CLKSRC_MMIO
 
 config ARM_ARCH_TIMER
-	bool
+	bool "Architected timer support"
 	select CLKSRC_OF if OF
 	select CLKSRC_ACPI if ACPI
 

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] Qualcomm Driver Updates for v4.7
Date: Sat, 16 Apr 2016 21:59:16 +0200	[thread overview]
Message-ID: <6572897.TrNljr4Es3@wuerfel> (raw)
In-Reply-To: <20160413191108.GF14441@codeaurora.org>

On Wednesday 13 April 2016 12:11:08 Stephen Boyd wrote:
> 
> Honestly, I view these clocksource selects as the only blocker in
> the effort to get rid of machine type Kconfigs. Maybe that isn't
> a good goal though.

I agree with you, it would be nice if we could just make them
all configurable and not need any machine type Kconfigs (though
a lot of platforms will continue using them for other reasons).

A patch like the one below (as I think you suggested) would be
nice too, but requires people to update their defconfig files.
In the mainline kernel, we have four defconfig files that
enable CONFIG_HAVE_ARM_ARCH_TIMER manually, so those all need
to be changed along with the Kconfig files, and everyone that
has their own out of tree defconfig file (not a full .config)
runs into the same issue.

It's probably still worth doing the change, but it's not obvious.

	Arnd


diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 62c209504c0a..0daad62cfce5 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1296,7 +1296,6 @@ config HAVE_ARM_SCU
 	  This option enables support for the ARM system coherency unit
 
 config HAVE_ARM_ARCH_TIMER
-	bool "Architected timer support"
 	depends on CPU_V7
 	select ARM_ARCH_TIMER
 	select GENERIC_CLOCKEVENTS
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index c346be650892..0314778c992f 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -187,7 +187,7 @@ config CLKSRC_STM32
 	select CLKSRC_MMIO
 
 config ARM_ARCH_TIMER
-	bool
+	bool "Architected timer support"
 	select CLKSRC_OF if OF
 	select CLKSRC_ACPI if ACPI
 

  reply	other threads:[~2016-04-16 19:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 19:59 [GIT PULL] Qualcomm Driver Updates for v4.7 Andy Gross
2016-04-01 19:59 ` Andy Gross
2016-04-13 18:10 ` Olof Johansson
2016-04-13 18:10   ` Olof Johansson
2016-04-13 18:21   ` Stephen Boyd
2016-04-13 18:21     ` Stephen Boyd
2016-04-13 18:41     ` Olof Johansson
2016-04-13 18:41       ` Olof Johansson
2016-04-13 19:11       ` Stephen Boyd
2016-04-13 19:11         ` Stephen Boyd
2016-04-16 19:59         ` Arnd Bergmann [this message]
2016-04-16 19:59           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6572897.TrNljr4Es3@wuerfel \
    --to=arnd@arndb.de \
    --cc=andy.gross@linaro.org \
    --cc=arm@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.