From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Vineet Gupta <Vineet.Gupta1@synopsys.com> Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <marc.zyngier@arm.com>, Noam Camus <noamc@ezchip.com> Subject: Re: [PATCH v5] ARC: clockevent: DT based probe Date: Mon, 18 Apr 2016 11:08:18 +0200 [thread overview] Message-ID: <20160418090818.GA14358@linaro.org> (raw) In-Reply-To: <1460961970-20696-1-git-send-email-vgupta@synopsys.com> On Mon, Apr 18, 2016 at 12:16:10PM +0530, Vineet Gupta wrote: > - timer frequency is derived from DT (no longer rely on top level > DT "clock-frequency" probed early and exported by asm/clk.h) > > - TIMER0_IRQ need not be exported across arch code, confined to intc as > it is property of same > > - Any failures in clockevent setup are considered pedantic and system > panic()'s as there is no generic fallback (unlike clocksource where > a jiffies based soft clocksource always exists) > > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Signed-off-by: Vineet Gupta <vgupta@synopsys.com> > --- > Changes since v4 [*] > - clockevent setup failure panic()s bubbled up to top level function [Daniel] > - arc_get_timer_clk() returns error status vs. void [Daniel] > - For consistency, straggler pr_err() in setup function also converted to panic > > [*] http://lists.infradead.org/pipermail/linux-snps-arc/2016-April/000903.html [ ... ] > +static int noinline arc_get_timer_clk(struct device_node *node) > +{ > + struct clk *clk; > + int ret = -1; > + > + clk = of_clk_get(node, 0); > + if (IS_ERR(clk)) { > + pr_err("timer missing clk"); > + return ret; > + } return PTR_ERR(clk); > + ret = clk_prepare_enable(clk); > + if (ret) { > + pr_err("Couldn't enable parent clk\n"); > + return ret; > + } > + > + arc_timer_freq = clk_get_rate(clk); > + return ret; > +} With the change above: Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano) To: linux-snps-arc@lists.infradead.org Subject: [PATCH v5] ARC: clockevent: DT based probe Date: Mon, 18 Apr 2016 11:08:18 +0200 [thread overview] Message-ID: <20160418090818.GA14358@linaro.org> (raw) In-Reply-To: <1460961970-20696-1-git-send-email-vgupta@synopsys.com> On Mon, Apr 18, 2016@12:16:10PM +0530, Vineet Gupta wrote: > - timer frequency is derived from DT (no longer rely on top level > DT "clock-frequency" probed early and exported by asm/clk.h) > > - TIMER0_IRQ need not be exported across arch code, confined to intc as > it is property of same > > - Any failures in clockevent setup are considered pedantic and system > panic()'s as there is no generic fallback (unlike clocksource where > a jiffies based soft clocksource always exists) > > Cc: Daniel Lezcano <daniel.lezcano at linaro.org> > Signed-off-by: Vineet Gupta <vgupta at synopsys.com> > --- > Changes since v4 [*] > - clockevent setup failure panic()s bubbled up to top level function [Daniel] > - arc_get_timer_clk() returns error status vs. void [Daniel] > - For consistency, straggler pr_err() in setup function also converted to panic > > [*] http://lists.infradead.org/pipermail/linux-snps-arc/2016-April/000903.html [ ... ] > +static int noinline arc_get_timer_clk(struct device_node *node) > +{ > + struct clk *clk; > + int ret = -1; > + > + clk = of_clk_get(node, 0); > + if (IS_ERR(clk)) { > + pr_err("timer missing clk"); > + return ret; > + } return PTR_ERR(clk); > + ret = clk_prepare_enable(clk); > + if (ret) { > + pr_err("Couldn't enable parent clk\n"); > + return ret; > + } > + > + arc_timer_freq = clk_get_rate(clk); > + return ret; > +} With the change above: Acked-by: Daniel Lezcano <daniel.lezcano at linaro.org>
next prev parent reply other threads:[~2016-04-18 9:08 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-13 11:40 [PATCH v4 0/5] Modernize ARC clocksource/clockevent/intc drivers Vineet Gupta 2016-04-13 11:40 ` Vineet Gupta 2016-04-13 11:40 ` [PATCH v4 1/5] ARC: clockevent: DT based probe Vineet Gupta 2016-04-13 11:40 ` Vineet Gupta 2016-04-13 12:59 ` Daniel Lezcano 2016-04-13 12:59 ` Daniel Lezcano 2016-04-14 9:32 ` Vineet Gupta 2016-04-14 9:32 ` Vineet Gupta 2016-04-14 10:05 ` Daniel Lezcano 2016-04-14 10:05 ` Daniel Lezcano 2016-04-18 6:46 ` [PATCH v5] " Vineet Gupta 2016-04-18 6:46 ` Vineet Gupta 2016-04-18 9:08 ` Daniel Lezcano [this message] 2016-04-18 9:08 ` Daniel Lezcano 2016-04-13 11:40 ` [PATCH v4 2/5] ARC: clocksource: " Vineet Gupta 2016-04-13 11:40 ` Vineet Gupta 2016-04-13 16:22 ` Marc Zyngier 2016-04-13 16:22 ` Marc Zyngier 2016-04-14 9:26 ` Vineet Gupta 2016-04-14 9:26 ` Vineet Gupta 2016-04-14 9:32 ` Marc Zyngier 2016-04-14 9:32 ` Marc Zyngier 2016-04-14 9:36 ` Vineet Gupta 2016-04-14 9:36 ` Vineet Gupta 2016-04-13 11:40 ` [PATCH v4 3/5] ARC: irq: export some IRQs again Vineet Gupta 2016-04-13 11:40 ` Vineet Gupta 2016-04-13 11:40 ` [PATCH v4 4/5] ARC: [intc-*] Do a domain lookup in primary handler for hwirq -> linux virq Vineet Gupta 2016-04-13 11:40 ` Vineet Gupta 2016-04-13 11:40 ` [PATCH v4 5/5] ARC: [intc-*] switch to linear domain Vineet Gupta 2016-04-13 11:40 ` Vineet Gupta 2016-04-18 6:51 ` Vineet Gupta 2016-04-18 6:51 ` Vineet Gupta 2016-04-18 9:41 ` Marc Zyngier 2016-04-18 9:41 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160418090818.GA14358@linaro.org \ --to=daniel.lezcano@linaro.org \ --cc=Vineet.Gupta1@synopsys.com \ --cc=jason@lakedaemon.net \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-snps-arc@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=noamc@ezchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.