From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
<linux-snps-arc@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, "Noam Camus" <noamc@ezchip.com>
Subject: Re: [PATCH v4 5/5] ARC: [intc-*] switch to linear domain
Date: Mon, 18 Apr 2016 12:21:55 +0530 [thread overview]
Message-ID: <5714840B.5080309@synopsys.com> (raw)
In-Reply-To: <1460547605-26184-6-git-send-email-vgupta@synopsys.com>
Hi Marc,
On Wednesday 13 April 2016 05:10 PM, Vineet Gupta wrote:
> Now that we have Timers probed from DT, don't need legacy domain
>
> This however requires mapping to be called explicitly for the IRQ which
> still can't (and probably never) be probed from DT such as IPI and
> SOFTIRQ
>
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> ---
> arch/arc/kernel/intc-arcv2.c | 8 ++++++--
> arch/arc/kernel/intc-compact.c | 2 +-
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arc/kernel/intc-arcv2.c b/arch/arc/kernel/intc-arcv2.c
> index 592cc977151e..6c24faf48b16 100644
> --- a/arch/arc/kernel/intc-arcv2.c
> +++ b/arch/arc/kernel/intc-arcv2.c
> @@ -146,8 +146,7 @@ init_onchip_IRQ(struct device_node *intc, struct device_node *parent)
> if (parent)
> panic("DeviceTree incore intc not a root irq controller\n");
>
> - root_domain = irq_domain_add_legacy(intc, NR_CPU_IRQS, 0, 0,
> - &arcv2_irq_ops, NULL);
> + root_domain = irq_domain_add_linear(intc, NR_CPU_IRQS, &arcv2_irq_ops, NULL);
> if (!root_domain)
> panic("root irq domain not avail\n");
>
> @@ -157,6 +156,11 @@ init_onchip_IRQ(struct device_node *intc, struct device_node *parent)
> */
> irq_set_default_host(root_domain);
>
> +#ifdef CONFIG_SMP
> + irq_create_mapping(root_domain, IPI_IRQ);
> +#endif
> + irq_create_mapping(root_domain, SOFTIRQ_IRQ);
> +
> return 0;
> }
>
> diff --git a/arch/arc/kernel/intc-compact.c b/arch/arc/kernel/intc-compact.c
> index 48a8b24de23e..c5cceca36118 100644
> --- a/arch/arc/kernel/intc-compact.c
> +++ b/arch/arc/kernel/intc-compact.c
> @@ -105,7 +105,7 @@ init_onchip_IRQ(struct device_node *intc, struct device_node *parent)
> if (parent)
> panic("DeviceTree incore intc not a root irq controller\n");
>
> - root_domain = irq_domain_add_legacy(intc, NR_CPU_IRQS, 0, 0,
> + root_domain = irq_domain_add_linear(intc, NR_CPU_IRQS,
> &arc_intc_domain_ops, NULL);
> if (!root_domain)
> panic("root irq domain not avail\n");
>
Does this patch look ok to you ? Do you want to see any other improvements here.
-Vineet
WARNING: multiple messages have this Message-ID (diff)
From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v4 5/5] ARC: [intc-*] switch to linear domain
Date: Mon, 18 Apr 2016 12:21:55 +0530 [thread overview]
Message-ID: <5714840B.5080309@synopsys.com> (raw)
In-Reply-To: <1460547605-26184-6-git-send-email-vgupta@synopsys.com>
Hi Marc,
On Wednesday 13 April 2016 05:10 PM, Vineet Gupta wrote:
> Now that we have Timers probed from DT, don't need legacy domain
>
> This however requires mapping to be called explicitly for the IRQ which
> still can't (and probably never) be probed from DT such as IPI and
> SOFTIRQ
>
> Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
> ---
> arch/arc/kernel/intc-arcv2.c | 8 ++++++--
> arch/arc/kernel/intc-compact.c | 2 +-
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arc/kernel/intc-arcv2.c b/arch/arc/kernel/intc-arcv2.c
> index 592cc977151e..6c24faf48b16 100644
> --- a/arch/arc/kernel/intc-arcv2.c
> +++ b/arch/arc/kernel/intc-arcv2.c
> @@ -146,8 +146,7 @@ init_onchip_IRQ(struct device_node *intc, struct device_node *parent)
> if (parent)
> panic("DeviceTree incore intc not a root irq controller\n");
>
> - root_domain = irq_domain_add_legacy(intc, NR_CPU_IRQS, 0, 0,
> - &arcv2_irq_ops, NULL);
> + root_domain = irq_domain_add_linear(intc, NR_CPU_IRQS, &arcv2_irq_ops, NULL);
> if (!root_domain)
> panic("root irq domain not avail\n");
>
> @@ -157,6 +156,11 @@ init_onchip_IRQ(struct device_node *intc, struct device_node *parent)
> */
> irq_set_default_host(root_domain);
>
> +#ifdef CONFIG_SMP
> + irq_create_mapping(root_domain, IPI_IRQ);
> +#endif
> + irq_create_mapping(root_domain, SOFTIRQ_IRQ);
> +
> return 0;
> }
>
> diff --git a/arch/arc/kernel/intc-compact.c b/arch/arc/kernel/intc-compact.c
> index 48a8b24de23e..c5cceca36118 100644
> --- a/arch/arc/kernel/intc-compact.c
> +++ b/arch/arc/kernel/intc-compact.c
> @@ -105,7 +105,7 @@ init_onchip_IRQ(struct device_node *intc, struct device_node *parent)
> if (parent)
> panic("DeviceTree incore intc not a root irq controller\n");
>
> - root_domain = irq_domain_add_legacy(intc, NR_CPU_IRQS, 0, 0,
> + root_domain = irq_domain_add_linear(intc, NR_CPU_IRQS,
> &arc_intc_domain_ops, NULL);
> if (!root_domain)
> panic("root irq domain not avail\n");
>
Does this patch look ok to you ? Do you want to see any other improvements here.
-Vineet
next prev parent reply other threads:[~2016-04-18 6:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 11:40 [PATCH v4 0/5] Modernize ARC clocksource/clockevent/intc drivers Vineet Gupta
2016-04-13 11:40 ` Vineet Gupta
2016-04-13 11:40 ` [PATCH v4 1/5] ARC: clockevent: DT based probe Vineet Gupta
2016-04-13 11:40 ` Vineet Gupta
2016-04-13 12:59 ` Daniel Lezcano
2016-04-13 12:59 ` Daniel Lezcano
2016-04-14 9:32 ` Vineet Gupta
2016-04-14 9:32 ` Vineet Gupta
2016-04-14 10:05 ` Daniel Lezcano
2016-04-14 10:05 ` Daniel Lezcano
2016-04-18 6:46 ` [PATCH v5] " Vineet Gupta
2016-04-18 6:46 ` Vineet Gupta
2016-04-18 9:08 ` Daniel Lezcano
2016-04-18 9:08 ` Daniel Lezcano
2016-04-13 11:40 ` [PATCH v4 2/5] ARC: clocksource: " Vineet Gupta
2016-04-13 11:40 ` Vineet Gupta
2016-04-13 16:22 ` Marc Zyngier
2016-04-13 16:22 ` Marc Zyngier
2016-04-14 9:26 ` Vineet Gupta
2016-04-14 9:26 ` Vineet Gupta
2016-04-14 9:32 ` Marc Zyngier
2016-04-14 9:32 ` Marc Zyngier
2016-04-14 9:36 ` Vineet Gupta
2016-04-14 9:36 ` Vineet Gupta
2016-04-13 11:40 ` [PATCH v4 3/5] ARC: irq: export some IRQs again Vineet Gupta
2016-04-13 11:40 ` Vineet Gupta
2016-04-13 11:40 ` [PATCH v4 4/5] ARC: [intc-*] Do a domain lookup in primary handler for hwirq -> linux virq Vineet Gupta
2016-04-13 11:40 ` Vineet Gupta
2016-04-13 11:40 ` [PATCH v4 5/5] ARC: [intc-*] switch to linear domain Vineet Gupta
2016-04-13 11:40 ` Vineet Gupta
2016-04-18 6:51 ` Vineet Gupta [this message]
2016-04-18 6:51 ` Vineet Gupta
2016-04-18 9:41 ` Marc Zyngier
2016-04-18 9:41 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5714840B.5080309@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=daniel.lezcano@linaro.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=noamc@ezchip.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.