* [PATCH v2 1/2] asus-laptop: remove redundant initializers
@ 2016-04-16 0:01 Giedrius Statkevičius
2016-04-16 0:01 ` [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Giedrius Statkevičius
2016-04-21 23:01 ` [PATCH v2 1/2] asus-laptop: remove redundant initializers Andy Shevchenko
0 siblings, 2 replies; 8+ messages in thread
From: Giedrius Statkevičius @ 2016-04-16 0:01 UTC (permalink / raw)
To: corentin.chary, dvhart
Cc: acpi4asus-user, platform-driver-x86, linux-kernel,
Giedrius Statkevičius
Initializing rv to AE_OK is pointless because later function results are
assigned to them and only then the variable is used
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
---
drivers/platform/x86/asus-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index f2b5d0a..d86d42e 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -771,7 +771,7 @@ static int asus_read_brightness(struct backlight_device *bd)
{
struct asus_laptop *asus = bl_get_data(bd);
unsigned long long value;
- acpi_status rv = AE_OK;
+ acpi_status rv;
rv = acpi_evaluate_integer(asus->handle, METHOD_BRIGHTNESS_GET,
NULL, &value);
@@ -865,7 +865,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,
int len = 0;
unsigned long long temp;
char buf[16]; /* enough for all info */
- acpi_status rv = AE_OK;
+ acpi_status rv;
/*
* We use the easy way, we don't care of off and count,
@@ -1265,7 +1265,7 @@ static DEVICE_ATTR_RO(ls_value);
static int asus_gps_status(struct asus_laptop *asus)
{
unsigned long long status;
- acpi_status rv = AE_OK;
+ acpi_status rv;
rv = acpi_evaluate_integer(asus->handle, METHOD_GPS_STATUS,
NULL, &status);
--
2.8.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set
2016-04-16 0:01 [PATCH v2 1/2] asus-laptop: remove redundant initializers Giedrius Statkevičius
@ 2016-04-16 0:01 ` Giedrius Statkevičius
2016-04-20 20:19 ` Darren Hart
` (2 more replies)
2016-04-21 23:01 ` [PATCH v2 1/2] asus-laptop: remove redundant initializers Andy Shevchenko
1 sibling, 3 replies; 8+ messages in thread
From: Giedrius Statkevičius @ 2016-04-16 0:01 UTC (permalink / raw)
To: corentin.chary, dvhart
Cc: acpi4asus-user, platform-driver-x86, linux-kernel,
Giedrius Statkevičius
Properly return rv back to the caller in the case of an error in
parse_arg. In the process remove a unused variable 'out'.
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
---
drivers/platform/x86/asus-laptop.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index d86d42e..9a69734 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
const char *method)
{
int rv, value;
- int out = 0;
rv = parse_arg(buf, count, &value);
- if (rv > 0)
- out = value ? 1 : 0;
+ if (rv <= 0)
+ return rv;
if (write_acpi_int(asus->handle, method, value))
return -ENODEV;
--
2.8.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set
2016-04-16 0:01 ` [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Giedrius Statkevičius
@ 2016-04-20 20:19 ` Darren Hart
2016-04-21 6:35 ` Giedrius Statkevičius
2016-04-21 20:34 ` Andy Shevchenko
2016-04-25 17:47 ` Darren Hart
2 siblings, 1 reply; 8+ messages in thread
From: Darren Hart @ 2016-04-20 20:19 UTC (permalink / raw)
To: Giedrius Statkevičius
Cc: corentin.chary, acpi4asus-user, platform-driver-x86, linux-kernel
On Sat, Apr 16, 2016 at 03:01:57AM +0300, Giedrius Statkevičius wrote:
> Properly return rv back to the caller in the case of an error in
> parse_arg. In the process remove a unused variable 'out'.
The initial problem if I recall was value being uninitialized. Is that correct?
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
> ---
> drivers/platform/x86/asus-laptop.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index d86d42e..9a69734 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
> const char *method)
> {
> int rv, value;
> - int out = 0;
>
> rv = parse_arg(buf, count, &value);
> - if (rv > 0)
> - out = value ? 1 : 0;
> + if (rv <= 0)
> + return rv;
>
> if (write_acpi_int(asus->handle, method, value))
> return -ENODEV;
> --
> 2.8.0
>
>
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set
2016-04-20 20:19 ` Darren Hart
@ 2016-04-21 6:35 ` Giedrius Statkevičius
0 siblings, 0 replies; 8+ messages in thread
From: Giedrius Statkevičius @ 2016-04-21 6:35 UTC (permalink / raw)
To: Darren Hart
Cc: corentin.chary, acpi4asus-user, platform-driver-x86, linux-kernel
On Wed, Apr 20, 2016 at 01:19:55PM -0700, Darren Hart wrote:
> On Sat, Apr 16, 2016 at 03:01:57AM +0300, Giedrius Statkevičius wrote:
> > Properly return rv back to the caller in the case of an error in
> > parse_arg. In the process remove a unused variable 'out'.
>
> The initial problem if I recall was value being uninitialized. Is that correct?
No, 'out' was just removed as it was unused. Then you caught the issue with
error handling in this function so I've updated this patch to fix that as well.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set
2016-04-16 0:01 ` [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Giedrius Statkevičius
2016-04-20 20:19 ` Darren Hart
@ 2016-04-21 20:34 ` Andy Shevchenko
2016-04-21 20:59 ` Darren Hart
2016-04-25 17:47 ` Darren Hart
2 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2016-04-21 20:34 UTC (permalink / raw)
To: Giedrius Statkevičius
Cc: Corentin Chary, dvhart, acpi4asus-user, platform-driver-x86,
linux-kernel
On Sat, Apr 16, 2016 at 3:01 AM, Giedrius Statkevičius
<giedrius.statkevicius@gmail.com> wrote:
> Properly return rv back to the caller in the case of an error in
> parse_arg. In the process remove a unused variable 'out'.
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
> ---
> drivers/platform/x86/asus-laptop.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index d86d42e..9a69734 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
> const char *method)
> {
> int rv, value;
> - int out = 0;
>
> rv = parse_arg(buf, count, &value);
Just noticed (might be a separate patch for this) that parse_arg
pretty much duplicated kstrotint().
> - if (rv > 0)
> - out = value ? 1 : 0;
> + if (rv <= 0)
> + return rv;
>
> if (write_acpi_int(asus->handle, method, value))
> return -ENODEV;
> --
> 2.8.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set
2016-04-21 20:34 ` Andy Shevchenko
@ 2016-04-21 20:59 ` Darren Hart
0 siblings, 0 replies; 8+ messages in thread
From: Darren Hart @ 2016-04-21 20:59 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Giedrius Statkevičius, Corentin Chary, acpi4asus-user,
platform-driver-x86, linux-kernel
On Thu, Apr 21, 2016 at 11:34:13PM +0300, Andy Shevchenko wrote:
> On Sat, Apr 16, 2016 at 3:01 AM, Giedrius Statkevičius
> <giedrius.statkevicius@gmail.com> wrote:
> > Properly return rv back to the caller in the case of an error in
> > parse_arg. In the process remove a unused variable 'out'.
> >
> > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
> > ---
> > drivers/platform/x86/asus-laptop.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> > index d86d42e..9a69734 100644
> > --- a/drivers/platform/x86/asus-laptop.c
> > +++ b/drivers/platform/x86/asus-laptop.c
> > @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
> > const char *method)
> > {
> > int rv, value;
> > - int out = 0;
> >
> > rv = parse_arg(buf, count, &value);
>
> Just noticed (might be a separate patch for this) that parse_arg
> pretty much duplicated kstrotint().
Ah, thanks Andy.
I'd like to take this one as is, but a cleanup for that would be welcome indeed.
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set
2016-04-16 0:01 ` [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Giedrius Statkevičius
2016-04-20 20:19 ` Darren Hart
2016-04-21 20:34 ` Andy Shevchenko
@ 2016-04-25 17:47 ` Darren Hart
2 siblings, 0 replies; 8+ messages in thread
From: Darren Hart @ 2016-04-25 17:47 UTC (permalink / raw)
To: Giedrius Statkevičius
Cc: corentin.chary, acpi4asus-user, platform-driver-x86, linux-kernel
On Sat, Apr 16, 2016 at 03:01:57AM +0300, Giedrius Statkevičius wrote:
> Properly return rv back to the caller in the case of an error in
> parse_arg. In the process remove a unused variable 'out'.
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
1 and 2 queued for 4.7.
> ---
> drivers/platform/x86/asus-laptop.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index d86d42e..9a69734 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -946,11 +946,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
> const char *method)
> {
> int rv, value;
> - int out = 0;
>
> rv = parse_arg(buf, count, &value);
> - if (rv > 0)
> - out = value ? 1 : 0;
> + if (rv <= 0)
> + return rv;
>
> if (write_acpi_int(asus->handle, method, value))
> return -ENODEV;
> --
> 2.8.0
>
>
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] asus-laptop: remove redundant initializers
2016-04-16 0:01 [PATCH v2 1/2] asus-laptop: remove redundant initializers Giedrius Statkevičius
2016-04-16 0:01 ` [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Giedrius Statkevičius
@ 2016-04-21 23:01 ` Andy Shevchenko
1 sibling, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2016-04-21 23:01 UTC (permalink / raw)
To: Giedrius Statkevičius
Cc: Corentin Chary, dvhart, acpi4asus-user, platform-driver-x86,
linux-kernel
On Sat, Apr 16, 2016 at 3:01 AM, Giedrius Statkevičius
<giedrius.statkevicius@gmail.com> wrote:
> Initializing rv to AE_OK is pointless because later function results are
> assigned to them and only then the variable is used
>
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Fine to me:
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> drivers/platform/x86/asus-laptop.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index f2b5d0a..d86d42e 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -771,7 +771,7 @@ static int asus_read_brightness(struct backlight_device *bd)
> {
> struct asus_laptop *asus = bl_get_data(bd);
> unsigned long long value;
> - acpi_status rv = AE_OK;
> + acpi_status rv;
>
> rv = acpi_evaluate_integer(asus->handle, METHOD_BRIGHTNESS_GET,
> NULL, &value);
> @@ -865,7 +865,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr,
> int len = 0;
> unsigned long long temp;
> char buf[16]; /* enough for all info */
> - acpi_status rv = AE_OK;
> + acpi_status rv;
>
> /*
> * We use the easy way, we don't care of off and count,
> @@ -1265,7 +1265,7 @@ static DEVICE_ATTR_RO(ls_value);
> static int asus_gps_status(struct asus_laptop *asus)
> {
> unsigned long long status;
> - acpi_status rv = AE_OK;
> + acpi_status rv;
>
> rv = acpi_evaluate_integer(asus->handle, METHOD_GPS_STATUS,
> NULL, &status);
> --
> 2.8.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-04-25 17:47 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-16 0:01 [PATCH v2 1/2] asus-laptop: remove redundant initializers Giedrius Statkevičius
2016-04-16 0:01 ` [PATCH v2 2/2] asus-laptop: correct error handling in sysfs_acpi_set Giedrius Statkevičius
2016-04-20 20:19 ` Darren Hart
2016-04-21 6:35 ` Giedrius Statkevičius
2016-04-21 20:34 ` Andy Shevchenko
2016-04-21 20:59 ` Darren Hart
2016-04-25 17:47 ` Darren Hart
2016-04-21 23:01 ` [PATCH v2 1/2] asus-laptop: remove redundant initializers Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.