* [PATCH i-g-t 0/7] Improve kms_panel_fitting.
@ 2016-04-22 21:24 robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 1/7] kms_panel_fitting: Remove un-read variable robert.foss
` (7 more replies)
0 siblings, 8 replies; 23+ messages in thread
From: robert.foss @ 2016-04-22 21:24 UTC (permalink / raw)
To: marius.vlad, daniel.vetter; +Cc: intel-gfx
From: Robert Foss <robert.foss@collabora.com>
This series removes some dead code from kms_panel_fitting and
enables support for LVDS and DSI connectors.
Robert Foss (7):
kms_panel_fitting: Remove un-read variable.
kms_panel_fitting: Remove un-read variable pipe_crc.
kms_panel_fitting: Remove un-used variable.
kms_panel_fitting: Switched DRM format to a hardware agnostic
alternative.
kms_panel_fitting: Enabled test on non-Intel hardware.
kms_panel_fitting: Don't skip test after finding an incompatible
connector.
kms_panel_fitting: Add support for LVDS and DSI connectors.
tests/kms_panel_fitting.c | 35 +++++++++++++++--------------------
1 file changed, 15 insertions(+), 20 deletions(-)
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH i-g-t 1/7] kms_panel_fitting: Remove un-read variable.
2016-04-22 21:24 [PATCH i-g-t 0/7] Improve kms_panel_fitting robert.foss
@ 2016-04-22 21:24 ` robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 2/7] kms_panel_fitting: Remove un-read variable pipe_crc robert.foss
` (6 subsequent siblings)
7 siblings, 0 replies; 23+ messages in thread
From: robert.foss @ 2016-04-22 21:24 UTC (permalink / raw)
To: marius.vlad, daniel.vetter; +Cc: intel-gfx
From: Robert Foss <robert.foss@collabora.com>
Remove devid from data_t since it is never read.
Also remove one assignment to devid.
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
tests/kms_panel_fitting.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index 829d9cd..ab06d25 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -29,7 +29,6 @@
IGT_TEST_DESCRIPTION("Test display panel fitting");
typedef struct {
- uint32_t devid;
int drm_fd;
igt_display_t display;
igt_crc_t ref_crc;
@@ -224,7 +223,6 @@ igt_simple_main
data.drm_fd = drm_open_driver(DRIVER_INTEL);
igt_require_pipe_crc();
igt_display_init(&data.display, data.drm_fd);
- data.devid = intel_get_drm_devid(data.drm_fd);
test_panel_fitting(&data);
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH i-g-t 2/7] kms_panel_fitting: Remove un-read variable pipe_crc.
2016-04-22 21:24 [PATCH i-g-t 0/7] Improve kms_panel_fitting robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 1/7] kms_panel_fitting: Remove un-read variable robert.foss
@ 2016-04-22 21:24 ` robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 3/7] kms_panel_fitting: Remove un-used variable robert.foss
` (5 subsequent siblings)
7 siblings, 0 replies; 23+ messages in thread
From: robert.foss @ 2016-04-22 21:24 UTC (permalink / raw)
To: marius.vlad, daniel.vetter; +Cc: intel-gfx
From: Robert Foss <robert.foss@collabora.com>
pipe_crc in data_t is assigned an allocated memory space and
then later free'd. But it is never used for any comparisons.
It should therefore be safe to remove pipe_crc and the crc
requirement.
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
tests/kms_panel_fitting.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index ab06d25..b64e829 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -32,7 +32,6 @@ typedef struct {
int drm_fd;
igt_display_t display;
igt_crc_t ref_crc;
- igt_pipe_crc_t *pipe_crc;
int image_w;
int image_h;
@@ -59,10 +58,6 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
igt_output_set_pipe(output, pipe);
- /* create the pipe_crc object for this pipe */
- igt_pipe_crc_free(data->pipe_crc);
- data->pipe_crc = igt_pipe_crc_new(pipe, INTEL_PIPE_CRC_SOURCE_AUTO);
-
/* before allocating, free if any older fb */
if (data->fb_id1) {
igt_remove_fb(data->drm_fd, &data->fb1);
@@ -109,9 +104,6 @@ static void cleanup_crtc(data_t *data, igt_output_t *output, igt_plane_t *plane)
{
igt_display_t *display = &data->display;
- igt_pipe_crc_free(data->pipe_crc);
- data->pipe_crc = NULL;
-
if (data->fb_id1) {
igt_remove_fb(data->drm_fd, &data->fb1);
data->fb_id1 = 0;
@@ -221,7 +213,6 @@ igt_simple_main
igt_skip_on_simulation();
data.drm_fd = drm_open_driver(DRIVER_INTEL);
- igt_require_pipe_crc();
igt_display_init(&data.display, data.drm_fd);
test_panel_fitting(&data);
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH i-g-t 3/7] kms_panel_fitting: Remove un-used variable.
2016-04-22 21:24 [PATCH i-g-t 0/7] Improve kms_panel_fitting robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 1/7] kms_panel_fitting: Remove un-read variable robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 2/7] kms_panel_fitting: Remove un-read variable pipe_crc robert.foss
@ 2016-04-22 21:24 ` robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 4/7] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative robert.foss
` (4 subsequent siblings)
7 siblings, 0 replies; 23+ messages in thread
From: robert.foss @ 2016-04-22 21:24 UTC (permalink / raw)
To: marius.vlad, daniel.vetter; +Cc: intel-gfx
From: Robert Foss <robert.foss@collabora.com>
ref_crc is never assigned or read, and can be safely
removed.
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
tests/kms_panel_fitting.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index b64e829..dface97 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -31,7 +31,6 @@ IGT_TEST_DESCRIPTION("Test display panel fitting");
typedef struct {
int drm_fd;
igt_display_t display;
- igt_crc_t ref_crc;
int image_w;
int image_h;
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH i-g-t 4/7] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative.
2016-04-22 21:24 [PATCH i-g-t 0/7] Improve kms_panel_fitting robert.foss
` (2 preceding siblings ...)
2016-04-22 21:24 ` [PATCH i-g-t 3/7] kms_panel_fitting: Remove un-used variable robert.foss
@ 2016-04-22 21:24 ` robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 5/7] kms_panel_fitting: Enabled test on non-Intel hardware robert.foss
` (3 subsequent siblings)
7 siblings, 0 replies; 23+ messages in thread
From: robert.foss @ 2016-04-22 21:24 UTC (permalink / raw)
To: marius.vlad, daniel.vetter; +Cc: intel-gfx
From: Robert Foss <robert.foss@collabora.com>
Changed the DRM format to LOCAL_DRM_FORMAT_MOD_NONE since it
is hardware agnostic.
Also fixed formatting/tabs.
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
tests/kms_panel_fitting.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index dface97..ec7ce21 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -65,10 +65,10 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
/* allocate fb for plane 1 */
data->fb_id1 = igt_create_pattern_fb(data->drm_fd,
- mode->hdisplay, mode->vdisplay,
- DRM_FORMAT_XRGB8888,
- LOCAL_I915_FORMAT_MOD_X_TILED, /* tiled */
- &data->fb1);
+ mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ LOCAL_DRM_FORMAT_MOD_NONE,
+ &data->fb1);
igt_assert(data->fb_id1);
/*
@@ -158,7 +158,7 @@ static void test_panel_fitting(data_t *d)
d->fb_id2 = igt_create_image_fb(d->drm_fd, 0, 0,
DRM_FORMAT_XRGB8888,
- LOCAL_I915_FORMAT_MOD_X_TILED, /* tiled */
+ LOCAL_DRM_FORMAT_MOD_NONE,
FILE_NAME, &d->fb2);
igt_assert(d->fb_id2);
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH i-g-t 5/7] kms_panel_fitting: Enabled test on non-Intel hardware.
2016-04-22 21:24 [PATCH i-g-t 0/7] Improve kms_panel_fitting robert.foss
` (3 preceding siblings ...)
2016-04-22 21:24 ` [PATCH i-g-t 4/7] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative robert.foss
@ 2016-04-22 21:24 ` robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector robert.foss
` (2 subsequent siblings)
7 siblings, 0 replies; 23+ messages in thread
From: robert.foss @ 2016-04-22 21:24 UTC (permalink / raw)
To: marius.vlad, daniel.vetter; +Cc: intel-gfx
From: Robert Foss <robert.foss@collabora.com>
Switched from DRIVER_INTEL to DRIVER_ANY to enable test
on all hardware.
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
tests/kms_panel_fitting.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index ec7ce21..2398a5e 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -211,7 +211,7 @@ igt_simple_main
igt_skip_on_simulation();
- data.drm_fd = drm_open_driver(DRIVER_INTEL);
+ data.drm_fd = drm_open_driver(DRIVER_ANY);
igt_display_init(&data.display, data.drm_fd);
test_panel_fitting(&data);
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector.
2016-04-22 21:24 [PATCH i-g-t 0/7] Improve kms_panel_fitting robert.foss
` (4 preceding siblings ...)
2016-04-22 21:24 ` [PATCH i-g-t 5/7] kms_panel_fitting: Enabled test on non-Intel hardware robert.foss
@ 2016-04-22 21:24 ` robert.foss
2016-04-26 14:10 ` Daniel Vetter
2016-04-22 21:25 ` [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors robert.foss
2016-04-26 14:11 ` [PATCH i-g-t 0/7] Improve kms_panel_fitting Daniel Vetter
7 siblings, 1 reply; 23+ messages in thread
From: robert.foss @ 2016-04-22 21:24 UTC (permalink / raw)
To: marius.vlad, daniel.vetter; +Cc: intel-gfx
From: Robert Foss <robert.foss@collabora.com>
If an incompatible connector is found, don't skip the test,
but rather keep looking for valid connectors.
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
tests/kms_panel_fitting.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index 2398a5e..60a22b0 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -140,8 +140,9 @@ static void test_panel_fitting(data_t *d)
for_each_connected_output(display, output) {
drmModeModeInfo *mode, native_mode;
- igt_require(output->config.connector->connector_type ==
- DRM_MODE_CONNECTOR_eDP);
+ if (output->config.connector->connector_type !=
+ DRM_MODE_CONNECTOR_eDP)
+ continue;
pipe = output->config.pipe;
igt_output_set_pipe(output, pipe);
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-22 21:24 [PATCH i-g-t 0/7] Improve kms_panel_fitting robert.foss
` (5 preceding siblings ...)
2016-04-22 21:24 ` [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector robert.foss
@ 2016-04-22 21:25 ` robert.foss
2016-04-22 22:31 ` Marius Vlad
2016-04-26 14:11 ` Daniel Vetter
2016-04-26 14:11 ` [PATCH i-g-t 0/7] Improve kms_panel_fitting Daniel Vetter
7 siblings, 2 replies; 23+ messages in thread
From: robert.foss @ 2016-04-22 21:25 UTC (permalink / raw)
To: marius.vlad, daniel.vetter; +Cc: intel-gfx
From: Robert Foss <robert.foss@collabora.com>
Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
connectors.
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
tests/kms_panel_fitting.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
index 60a22b0..933776c 100644
--- a/tests/kms_panel_fitting.c
+++ b/tests/kms_panel_fitting.c
@@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
for_each_connected_output(display, output) {
drmModeModeInfo *mode, native_mode;
- if (output->config.connector->connector_type !=
- DRM_MODE_CONNECTOR_eDP)
- continue;
+ switch (output->config.connector->connector_type)
+ {
+ case DRM_MODE_CONNECTOR_LVDS:
+ case DRM_MODE_CONNECTOR_eDP:
+ case DRM_MODE_CONNECTOR_DSI:
+ break;
+ default:
+ continue;
+ }
pipe = output->config.pipe;
igt_output_set_pipe(output, pipe);
--
2.5.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-22 21:25 ` [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors robert.foss
@ 2016-04-22 22:31 ` Marius Vlad
2016-04-26 14:11 ` Daniel Vetter
1 sibling, 0 replies; 23+ messages in thread
From: Marius Vlad @ 2016-04-22 22:31 UTC (permalink / raw)
To: robert.foss; +Cc: Jani Nikula, daniel.vetter, intel-gfx, marius.vlad
[-- Attachment #1.1: Type: text/plain, Size: 1534 bytes --]
Think you can squash the last two into one (you're removing
what you've added in the previous one).
Also see https://lists.freedesktop.org/archives/intel-gfx/2016-March/090617.html.
On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
> connectors.
>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
> tests/kms_panel_fitting.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index 60a22b0..933776c 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
> for_each_connected_output(display, output) {
> drmModeModeInfo *mode, native_mode;
>
> - if (output->config.connector->connector_type !=
> - DRM_MODE_CONNECTOR_eDP)
> - continue;
> + switch (output->config.connector->connector_type)
> + {
> + case DRM_MODE_CONNECTOR_LVDS:
> + case DRM_MODE_CONNECTOR_eDP:
> + case DRM_MODE_CONNECTOR_DSI:
> + break;
> + default:
> + continue;
> + }
>
> pipe = output->config.pipe;
> igt_output_set_pipe(output, pipe);
> --
> 2.5.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector.
2016-04-22 21:24 ` [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector robert.foss
@ 2016-04-26 14:10 ` Daniel Vetter
2016-04-26 16:50 ` Robert Foss
0 siblings, 1 reply; 23+ messages in thread
From: Daniel Vetter @ 2016-04-26 14:10 UTC (permalink / raw)
To: robert.foss; +Cc: daniel.vetter, intel-gfx, marius.vlad
On Fri, Apr 22, 2016 at 05:24:59PM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> If an incompatible connector is found, don't skip the test,
> but rather keep looking for valid connectors.
>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
> tests/kms_panel_fitting.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index 2398a5e..60a22b0 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -140,8 +140,9 @@ static void test_panel_fitting(data_t *d)
> for_each_connected_output(display, output) {
> drmModeModeInfo *mode, native_mode;
>
> - igt_require(output->config.connector->connector_type ==
> - DRM_MODE_CONNECTOR_eDP);
> + if (output->config.connector->connector_type !=
> + DRM_MODE_CONNECTOR_eDP)
> + continue;
Needs a counter to make sure we end up at least with one successful run.
See e.g kms_cursor_crc.
for_each_config {
if (unsuitable_conntector)
continue;
/* test code */
valid_configs++;
}
igt_require(valid_configs);
I thought about extracting this into an igt block as a helper, but every
tests has it's own idea of how to write for_each_config and when to skip.
So hand-rolling everywhere unfortunately :(
-Daniel
>
> pipe = output->config.pipe;
> igt_output_set_pipe(output, pipe);
> --
> 2.5.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-22 21:25 ` [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors robert.foss
2016-04-22 22:31 ` Marius Vlad
@ 2016-04-26 14:11 ` Daniel Vetter
2016-04-26 16:55 ` Robert Foss
1 sibling, 1 reply; 23+ messages in thread
From: Daniel Vetter @ 2016-04-26 14:11 UTC (permalink / raw)
To: robert.foss; +Cc: daniel.vetter, intel-gfx, marius.vlad
On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
> connectors.
>
> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> ---
> tests/kms_panel_fitting.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> index 60a22b0..933776c 100644
> --- a/tests/kms_panel_fitting.c
> +++ b/tests/kms_panel_fitting.c
> @@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
> for_each_connected_output(display, output) {
> drmModeModeInfo *mode, native_mode;
>
> - if (output->config.connector->connector_type !=
> - DRM_MODE_CONNECTOR_eDP)
> - continue;
> + switch (output->config.connector->connector_type)
> + {
> + case DRM_MODE_CONNECTOR_LVDS:
> + case DRM_MODE_CONNECTOR_eDP:
> + case DRM_MODE_CONNECTOR_DSI:
> + break;
> + default:
> + continue;
> + }
I think ville commented that we should instead check for "scaling mode",
and we discussed this on irc. Am I accidentally looking at an old patch
series?
-Daniel
>
> pipe = output->config.pipe;
> igt_output_set_pipe(output, pipe);
> --
> 2.5.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 0/7] Improve kms_panel_fitting.
2016-04-22 21:24 [PATCH i-g-t 0/7] Improve kms_panel_fitting robert.foss
` (6 preceding siblings ...)
2016-04-22 21:25 ` [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors robert.foss
@ 2016-04-26 14:11 ` Daniel Vetter
7 siblings, 0 replies; 23+ messages in thread
From: Daniel Vetter @ 2016-04-26 14:11 UTC (permalink / raw)
To: robert.foss; +Cc: daniel.vetter, intel-gfx, marius.vlad
On Fri, Apr 22, 2016 at 05:24:53PM -0400, robert.foss@collabora.com wrote:
> From: Robert Foss <robert.foss@collabora.com>
>
> This series removes some dead code from kms_panel_fitting and
> enables support for LVDS and DSI connectors.
>
> Robert Foss (7):
> kms_panel_fitting: Remove un-read variable.
> kms_panel_fitting: Remove un-read variable pipe_crc.
> kms_panel_fitting: Remove un-used variable.
> kms_panel_fitting: Switched DRM format to a hardware agnostic
> alternative.
> kms_panel_fitting: Enabled test on non-Intel hardware.
> kms_panel_fitting: Don't skip test after finding an incompatible
> connector.
> kms_panel_fitting: Add support for LVDS and DSI connectors.
Two comments, lgtm otherwise but again please ask Tomeu to do a detailed
review before pushing.
-Daniel
>
> tests/kms_panel_fitting.c | 35 +++++++++++++++--------------------
> 1 file changed, 15 insertions(+), 20 deletions(-)
>
> --
> 2.5.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector.
2016-04-26 14:10 ` Daniel Vetter
@ 2016-04-26 16:50 ` Robert Foss
2016-04-28 8:01 ` Daniel Vetter
0 siblings, 1 reply; 23+ messages in thread
From: Robert Foss @ 2016-04-26 16:50 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx, daniel.vetter
On 04/26/2016 10:10 AM, Daniel Vetter wrote:
> On Fri, Apr 22, 2016 at 05:24:59PM -0400, robert.foss@collabora.com wrote:
>> From: Robert Foss <robert.foss@collabora.com>
>>
>> If an incompatible connector is found, don't skip the test,
>> but rather keep looking for valid connectors.
>>
>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>> ---
>> tests/kms_panel_fitting.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
>> index 2398a5e..60a22b0 100644
>> --- a/tests/kms_panel_fitting.c
>> +++ b/tests/kms_panel_fitting.c
>> @@ -140,8 +140,9 @@ static void test_panel_fitting(data_t *d)
>> for_each_connected_output(display, output) {
>> drmModeModeInfo *mode, native_mode;
>>
>> - igt_require(output->config.connector->connector_type ==
>> - DRM_MODE_CONNECTOR_eDP);
>> + if (output->config.connector->connector_type !=
>> + DRM_MODE_CONNECTOR_eDP)
>> + continue;
>
> Needs a counter to make sure we end up at least with one successful run.
> See e.g kms_cursor_crc.
>
> for_each_config {
>
> if (unsuitable_conntector)
> continue;
>
> /* test code */
>
> valid_configs++;
> }
>
> igt_require(valid_configs);
>
> I thought about extracting this into an igt block as a helper, but every
> tests has it's own idea of how to write for_each_config and when to skip.
> So hand-rolling everywhere unfortunately :(
> -Daniel
>
>
But isn't there already a check like that in trunk?
int valid_tests = 0;
for_each_connected_output {
/* test code */
valid_tests++;
}
igt_require_f(valid_tests, "no valid crtc/connector\n");
>>
>> pipe = output->config.pipe;
>> igt_output_set_pipe(output, pipe);
>> --
>> 2.5.0
>>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-26 14:11 ` Daniel Vetter
@ 2016-04-26 16:55 ` Robert Foss
2016-04-26 17:00 ` Ville Syrjälä
0 siblings, 1 reply; 23+ messages in thread
From: Robert Foss @ 2016-04-26 16:55 UTC (permalink / raw)
To: Daniel Vetter; +Cc: daniel.vetter, intel-gfx, marius.vlad
On 04/26/2016 10:11 AM, Daniel Vetter wrote:
> On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
>> From: Robert Foss <robert.foss@collabora.com>
>>
>> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
>> connectors.
>>
>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>> ---
>> tests/kms_panel_fitting.c | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
>> index 60a22b0..933776c 100644
>> --- a/tests/kms_panel_fitting.c
>> +++ b/tests/kms_panel_fitting.c
>> @@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
>> for_each_connected_output(display, output) {
>> drmModeModeInfo *mode, native_mode;
>>
>> - if (output->config.connector->connector_type !=
>> - DRM_MODE_CONNECTOR_eDP)
>> - continue;
>> + switch (output->config.connector->connector_type)
>> + {
>> + case DRM_MODE_CONNECTOR_LVDS:
>> + case DRM_MODE_CONNECTOR_eDP:
>> + case DRM_MODE_CONNECTOR_DSI:
>> + break;
>> + default:
>> + continue;
>> + }
>
> I think ville commented that we should instead check for "scaling mode",
> and we discussed this on irc. Am I accidentally looking at an old patch
> series?
> -Daniel
>
No, this isn't an old patch, I misunderstood where our conversation ended.
"scaling mode" is an intel specific extension as far as I understand it,
which is somewhat the opposite of generalizing i-g-t tests.
Is there an architecture independent way forward?
>>
>> pipe = output->config.pipe;
>> igt_output_set_pipe(output, pipe);
>> --
>> 2.5.0
>>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-26 16:55 ` Robert Foss
@ 2016-04-26 17:00 ` Ville Syrjälä
2016-04-26 17:08 ` Robert Foss
0 siblings, 1 reply; 23+ messages in thread
From: Ville Syrjälä @ 2016-04-26 17:00 UTC (permalink / raw)
To: Robert Foss; +Cc: daniel.vetter, intel-gfx, marius.vlad
On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote:
>
>
> On 04/26/2016 10:11 AM, Daniel Vetter wrote:
> > On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
> >> From: Robert Foss <robert.foss@collabora.com>
> >>
> >> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
> >> connectors.
> >>
> >> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> >> ---
> >> tests/kms_panel_fitting.c | 12 +++++++++---
> >> 1 file changed, 9 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> >> index 60a22b0..933776c 100644
> >> --- a/tests/kms_panel_fitting.c
> >> +++ b/tests/kms_panel_fitting.c
> >> @@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
> >> for_each_connected_output(display, output) {
> >> drmModeModeInfo *mode, native_mode;
> >>
> >> - if (output->config.connector->connector_type !=
> >> - DRM_MODE_CONNECTOR_eDP)
> >> - continue;
> >> + switch (output->config.connector->connector_type)
> >> + {
> >> + case DRM_MODE_CONNECTOR_LVDS:
> >> + case DRM_MODE_CONNECTOR_eDP:
> >> + case DRM_MODE_CONNECTOR_DSI:
> >> + break;
> >> + default:
> >> + continue;
> >> + }
> >
> > I think ville commented that we should instead check for "scaling mode",
> > and we discussed this on irc. Am I accidentally looking at an old patch
> > series?
> > -Daniel
> >
> No, this isn't an old patch, I misunderstood where our conversation ended.
>
> "scaling mode" is an intel specific extension as far as I understand it,
> which is somewhat the opposite of generalizing i-g-t tests.
>
> Is there an architecture independent way forward?
A quick poke at cscope tells me "scaling mode" is used by amdgpu, gma500,
i915, nouveau, and radeon. Seems fairly independent to me.
> >>
> >> pipe = output->config.pipe;
> >> igt_output_set_pipe(output, pipe);
> >> --
> >> 2.5.0
> >>
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-26 17:00 ` Ville Syrjälä
@ 2016-04-26 17:08 ` Robert Foss
2016-04-28 8:02 ` Daniel Vetter
0 siblings, 1 reply; 23+ messages in thread
From: Robert Foss @ 2016-04-26 17:08 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: daniel.vetter, intel-gfx, marius.vlad
On 04/26/2016 01:00 PM, Ville Syrjälä wrote:
> On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote:
>>
>>
>> On 04/26/2016 10:11 AM, Daniel Vetter wrote:
>>> On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
>>>> From: Robert Foss <robert.foss@collabora.com>
>>>>
>>>> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
>>>> connectors.
>>>>
>>>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>>>> ---
>>>> tests/kms_panel_fitting.c | 12 +++++++++---
>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
>>>> index 60a22b0..933776c 100644
>>>> --- a/tests/kms_panel_fitting.c
>>>> +++ b/tests/kms_panel_fitting.c
>>>> @@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
>>>> for_each_connected_output(display, output) {
>>>> drmModeModeInfo *mode, native_mode;
>>>>
>>>> - if (output->config.connector->connector_type !=
>>>> - DRM_MODE_CONNECTOR_eDP)
>>>> - continue;
>>>> + switch (output->config.connector->connector_type)
>>>> + {
>>>> + case DRM_MODE_CONNECTOR_LVDS:
>>>> + case DRM_MODE_CONNECTOR_eDP:
>>>> + case DRM_MODE_CONNECTOR_DSI:
>>>> + break;
>>>> + default:
>>>> + continue;
>>>> + }
>>>
>>> I think ville commented that we should instead check for "scaling mode",
>>> and we discussed this on irc. Am I accidentally looking at an old patch
>>> series?
>>> -Daniel
>>>
>> No, this isn't an old patch, I misunderstood where our conversation ended.
>>
>> "scaling mode" is an intel specific extension as far as I understand it,
>> which is somewhat the opposite of generalizing i-g-t tests.
>>
>> Is there an architecture independent way forward?
>
> A quick poke at cscope tells me "scaling mode" is used by amdgpu, gma500,
> i915, nouveau, and radeon. Seems fairly independent to me.
>
If that is the case, and it seems to be, "scaling mode" is definitely
worth pursuing.
>>>>
>>>> pipe = output->config.pipe;
>>>> igt_output_set_pipe(output, pipe);
>>>> --
>>>> 2.5.0
>>>>
>>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector.
2016-04-26 16:50 ` Robert Foss
@ 2016-04-28 8:01 ` Daniel Vetter
0 siblings, 0 replies; 23+ messages in thread
From: Daniel Vetter @ 2016-04-28 8:01 UTC (permalink / raw)
To: Robert Foss; +Cc: intel-gfx, daniel.vetter
On Tue, Apr 26, 2016 at 12:50:07PM -0400, Robert Foss wrote:
>
>
> On 04/26/2016 10:10 AM, Daniel Vetter wrote:
> >On Fri, Apr 22, 2016 at 05:24:59PM -0400, robert.foss@collabora.com wrote:
> >>From: Robert Foss <robert.foss@collabora.com>
> >>
> >>If an incompatible connector is found, don't skip the test,
> >>but rather keep looking for valid connectors.
> >>
> >>Signed-off-by: Robert Foss <robert.foss@collabora.com>
> >>---
> >> tests/kms_panel_fitting.c | 5 +++--
> >> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> >>index 2398a5e..60a22b0 100644
> >>--- a/tests/kms_panel_fitting.c
> >>+++ b/tests/kms_panel_fitting.c
> >>@@ -140,8 +140,9 @@ static void test_panel_fitting(data_t *d)
> >> for_each_connected_output(display, output) {
> >> drmModeModeInfo *mode, native_mode;
> >>
> >>- igt_require(output->config.connector->connector_type ==
> >>- DRM_MODE_CONNECTOR_eDP);
> >>+ if (output->config.connector->connector_type !=
> >>+ DRM_MODE_CONNECTOR_eDP)
> >>+ continue;
> >
> >Needs a counter to make sure we end up at least with one successful run.
> >See e.g kms_cursor_crc.
> >
> >for_each_config {
> >
> > if (unsuitable_conntector)
> > continue;
> >
> > /* test code */
> >
> > valid_configs++;
> >}
> >
> >igt_require(valid_configs);
> >
> >I thought about extracting this into an igt block as a helper, but every
> >tests has it's own idea of how to write for_each_config and when to skip.
> >So hand-rolling everywhere unfortunately :(
> >-Daniel
> >
> >
> But isn't there already a check like that in trunk?
>
> int valid_tests = 0;
> for_each_connected_output {
> /* test code */
> valid_tests++;
> }
> igt_require_f(valid_tests, "no valid crtc/connector\n");
Oops, didn't read the existing code carefully enough.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> >>
> >> pipe = output->config.pipe;
> >> igt_output_set_pipe(output, pipe);
> >>--
> >>2.5.0
> >>
> >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-26 17:08 ` Robert Foss
@ 2016-04-28 8:02 ` Daniel Vetter
2016-04-28 14:07 ` Robert Foss
0 siblings, 1 reply; 23+ messages in thread
From: Daniel Vetter @ 2016-04-28 8:02 UTC (permalink / raw)
To: Robert Foss; +Cc: daniel.vetter, intel-gfx, marius.vlad
On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote:
>
>
> On 04/26/2016 01:00 PM, Ville Syrjälä wrote:
> >On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote:
> >>
> >>
> >>On 04/26/2016 10:11 AM, Daniel Vetter wrote:
> >>>On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
> >>>>From: Robert Foss <robert.foss@collabora.com>
> >>>>
> >>>>Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
> >>>>connectors.
> >>>>
> >>>>Signed-off-by: Robert Foss <robert.foss@collabora.com>
> >>>>---
> >>>> tests/kms_panel_fitting.c | 12 +++++++++---
> >>>> 1 file changed, 9 insertions(+), 3 deletions(-)
> >>>>
> >>>>diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> >>>>index 60a22b0..933776c 100644
> >>>>--- a/tests/kms_panel_fitting.c
> >>>>+++ b/tests/kms_panel_fitting.c
> >>>>@@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
> >>>> for_each_connected_output(display, output) {
> >>>> drmModeModeInfo *mode, native_mode;
> >>>>
> >>>>- if (output->config.connector->connector_type !=
> >>>>- DRM_MODE_CONNECTOR_eDP)
> >>>>- continue;
> >>>>+ switch (output->config.connector->connector_type)
> >>>>+ {
> >>>>+ case DRM_MODE_CONNECTOR_LVDS:
> >>>>+ case DRM_MODE_CONNECTOR_eDP:
> >>>>+ case DRM_MODE_CONNECTOR_DSI:
> >>>>+ break;
> >>>>+ default:
> >>>>+ continue;
> >>>>+ }
> >>>
> >>>I think ville commented that we should instead check for "scaling mode",
> >>>and we discussed this on irc. Am I accidentally looking at an old patch
> >>>series?
> >>>-Daniel
> >>>
> >>No, this isn't an old patch, I misunderstood where our conversation ended.
> >>
> >>"scaling mode" is an intel specific extension as far as I understand it,
> >>which is somewhat the opposite of generalizing i-g-t tests.
> >>
> >>Is there an architecture independent way forward?
> >
> >A quick poke at cscope tells me "scaling mode" is used by amdgpu, gma500,
> >i915, nouveau, and radeon. Seems fairly independent to me.
> >
> If that is the case, and it seems to be, "scaling mode" is definitely
> worth pursuing.
Perhaps also send in a kernel patch to update the docbook table? It's
awful, but the best thing we have right now ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-28 8:02 ` Daniel Vetter
@ 2016-04-28 14:07 ` Robert Foss
2016-04-28 14:41 ` Daniel Vetter
0 siblings, 1 reply; 23+ messages in thread
From: Robert Foss @ 2016-04-28 14:07 UTC (permalink / raw)
To: Daniel Vetter; +Cc: daniel.vetter, intel-gfx, marius.vlad
On 04/28/2016 04:02 AM, Daniel Vetter wrote:
> On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote:
>>
>>
>> On 04/26/2016 01:00 PM, Ville Syrjälä wrote:
>>> On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote:
>>>>
>>>>
>>>> On 04/26/2016 10:11 AM, Daniel Vetter wrote:
>>>>> On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
>>>>>> From: Robert Foss <robert.foss@collabora.com>
>>>>>>
>>>>>> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
>>>>>> connectors.
>>>>>>
>>>>>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>>>>>> ---
>>>>>> tests/kms_panel_fitting.c | 12 +++++++++---
>>>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>>>>>
>>>>>> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
>>>>>> index 60a22b0..933776c 100644
>>>>>> --- a/tests/kms_panel_fitting.c
>>>>>> +++ b/tests/kms_panel_fitting.c
>>>>>> @@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
>>>>>> for_each_connected_output(display, output) {
>>>>>> drmModeModeInfo *mode, native_mode;
>>>>>>
>>>>>> - if (output->config.connector->connector_type !=
>>>>>> - DRM_MODE_CONNECTOR_eDP)
>>>>>> - continue;
>>>>>> + switch (output->config.connector->connector_type)
>>>>>> + {
>>>>>> + case DRM_MODE_CONNECTOR_LVDS:
>>>>>> + case DRM_MODE_CONNECTOR_eDP:
>>>>>> + case DRM_MODE_CONNECTOR_DSI:
>>>>>> + break;
>>>>>> + default:
>>>>>> + continue;
>>>>>> + }
>>>>>
>>>>> I think ville commented that we should instead check for "scaling mode",
>>>>> and we discussed this on irc. Am I accidentally looking at an old patch
>>>>> series?
>>>>> -Daniel
>>>>>
>>>> No, this isn't an old patch, I misunderstood where our conversation ended.
>>>>
>>>> "scaling mode" is an intel specific extension as far as I understand it,
>>>> which is somewhat the opposite of generalizing i-g-t tests.
>>>>
>>>> Is there an architecture independent way forward?
>>>
>>> A quick poke at cscope tells me "scaling mode" is used by amdgpu, gma500,
>>> i915, nouveau, and radeon. Seems fairly independent to me.
>>>
>> If that is the case, and it seems to be, "scaling mode" is definitely
>> worth pursuing.
>
> Perhaps also send in a kernel patch to update the docbook table? It's
> awful, but the best thing we have right now ...
> -Daniel
>
Other than a Description/Restrictions entry for "scaling mode", is there
anything you'd like to see added?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-28 14:07 ` Robert Foss
@ 2016-04-28 14:41 ` Daniel Vetter
2016-04-28 15:57 ` Robert Foss
0 siblings, 1 reply; 23+ messages in thread
From: Daniel Vetter @ 2016-04-28 14:41 UTC (permalink / raw)
To: Robert Foss; +Cc: daniel.vetter, intel-gfx, marius.vlad
On Thu, Apr 28, 2016 at 10:07:41AM -0400, Robert Foss wrote:
>
>
> On 04/28/2016 04:02 AM, Daniel Vetter wrote:
> >On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote:
> >>
> >>
> >>On 04/26/2016 01:00 PM, Ville Syrjälä wrote:
> >>>On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote:
> >>>>
> >>>>
> >>>>On 04/26/2016 10:11 AM, Daniel Vetter wrote:
> >>>>>On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
> >>>>>>From: Robert Foss <robert.foss@collabora.com>
> >>>>>>
> >>>>>>Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
> >>>>>>connectors.
> >>>>>>
> >>>>>>Signed-off-by: Robert Foss <robert.foss@collabora.com>
> >>>>>>---
> >>>>>> tests/kms_panel_fitting.c | 12 +++++++++---
> >>>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
> >>>>>>
> >>>>>>diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> >>>>>>index 60a22b0..933776c 100644
> >>>>>>--- a/tests/kms_panel_fitting.c
> >>>>>>+++ b/tests/kms_panel_fitting.c
> >>>>>>@@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
> >>>>>> for_each_connected_output(display, output) {
> >>>>>> drmModeModeInfo *mode, native_mode;
> >>>>>>
> >>>>>>- if (output->config.connector->connector_type !=
> >>>>>>- DRM_MODE_CONNECTOR_eDP)
> >>>>>>- continue;
> >>>>>>+ switch (output->config.connector->connector_type)
> >>>>>>+ {
> >>>>>>+ case DRM_MODE_CONNECTOR_LVDS:
> >>>>>>+ case DRM_MODE_CONNECTOR_eDP:
> >>>>>>+ case DRM_MODE_CONNECTOR_DSI:
> >>>>>>+ break;
> >>>>>>+ default:
> >>>>>>+ continue;
> >>>>>>+ }
> >>>>>
> >>>>>I think ville commented that we should instead check for "scaling mode",
> >>>>>and we discussed this on irc. Am I accidentally looking at an old patch
> >>>>>series?
> >>>>>-Daniel
> >>>>>
> >>>>No, this isn't an old patch, I misunderstood where our conversation ended.
> >>>>
> >>>>"scaling mode" is an intel specific extension as far as I understand it,
> >>>>which is somewhat the opposite of generalizing i-g-t tests.
> >>>>
> >>>>Is there an architecture independent way forward?
> >>>
> >>>A quick poke at cscope tells me "scaling mode" is used by amdgpu, gma500,
> >>>i915, nouveau, and radeon. Seems fairly independent to me.
> >>>
> >>If that is the case, and it seems to be, "scaling mode" is definitely
> >>worth pursuing.
> >
> >Perhaps also send in a kernel patch to update the docbook table? It's
> >awful, but the best thing we have right now ...
> >-Daniel
> >
>
> Other than a Description/Restrictions entry for "scaling mode", is there
> anything you'd like to see added?
I meant moving it into the generic section and list which drivers support
it. No need to change the description itself - that's an entire project on
itself.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-28 14:41 ` Daniel Vetter
@ 2016-04-28 15:57 ` Robert Foss
2016-05-02 8:20 ` Daniel Vetter
0 siblings, 1 reply; 23+ messages in thread
From: Robert Foss @ 2016-04-28 15:57 UTC (permalink / raw)
To: Daniel Vetter; +Cc: daniel.vetter, intel-gfx
On 04/28/2016 10:41 AM, Daniel Vetter wrote:
> On Thu, Apr 28, 2016 at 10:07:41AM -0400, Robert Foss wrote:
>>
>>
>> On 04/28/2016 04:02 AM, Daniel Vetter wrote:
>>> On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote:
>>>>
>>>>
>>>> On 04/26/2016 01:00 PM, Ville Syrjälä wrote:
>>>>> On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote:
>>>>>>
>>>>>>
>>>>>> On 04/26/2016 10:11 AM, Daniel Vetter wrote:
>>>>>>> On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
>>>>>>>> From: Robert Foss <robert.foss@collabora.com>
>>>>>>>>
>>>>>>>> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
>>>>>>>> connectors.
>>>>>>>>
>>>>>>>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>>>>>>>> ---
>>>>>>>> tests/kms_panel_fitting.c | 12 +++++++++---
>>>>>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
>>>>>>>> index 60a22b0..933776c 100644
>>>>>>>> --- a/tests/kms_panel_fitting.c
>>>>>>>> +++ b/tests/kms_panel_fitting.c
>>>>>>>> @@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
>>>>>>>> for_each_connected_output(display, output) {
>>>>>>>> drmModeModeInfo *mode, native_mode;
>>>>>>>>
>>>>>>>> - if (output->config.connector->connector_type !=
>>>>>>>> - DRM_MODE_CONNECTOR_eDP)
>>>>>>>> - continue;
>>>>>>>> + switch (output->config.connector->connector_type)
>>>>>>>> + {
>>>>>>>> + case DRM_MODE_CONNECTOR_LVDS:
>>>>>>>> + case DRM_MODE_CONNECTOR_eDP:
>>>>>>>> + case DRM_MODE_CONNECTOR_DSI:
>>>>>>>> + break;
>>>>>>>> + default:
>>>>>>>> + continue;
>>>>>>>> + }
>>>>>>>
>>>>>>> I think ville commented that we should instead check for "scaling mode",
>>>>>>> and we discussed this on irc. Am I accidentally looking at an old patch
>>>>>>> series?
>>>>>>> -Daniel
>>>>>>>
>>>>>> No, this isn't an old patch, I misunderstood where our conversation ended.
>>>>>>
>>>>>> "scaling mode" is an intel specific extension as far as I understand it,
>>>>>> which is somewhat the opposite of generalizing i-g-t tests.
>>>>>>
>>>>>> Is there an architecture independent way forward?
>>>>>
>>>>> A quick poke at cscope tells me "scaling mode" is used by amdgpu, gma500,
>>>>> i915, nouveau, and radeon. Seems fairly independent to me.
>>>>>
>>>> If that is the case, and it seems to be, "scaling mode" is definitely
>>>> worth pursuing.
>>>
>>> Perhaps also send in a kernel patch to update the docbook table? It's
>>> awful, but the best thing we have right now ...
>>> -Daniel
>>>
>>
>> Other than a Description/Restrictions entry for "scaling mode", is there
>> anything you'd like to see added?
>
> I meant moving it into the generic section and list which drivers support
> it. No need to change the description itself - that's an entire project on
> itself.
> -Daniel
>
I'm not seeing any other properties that have driver support listed.
Would adding a column called "Driver support" make sense?
Just to be clear, I'm moving the property to DRM->Generic->scaling mode.
Rob.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-04-28 15:57 ` Robert Foss
@ 2016-05-02 8:20 ` Daniel Vetter
2016-05-02 19:16 ` Robert Foss
0 siblings, 1 reply; 23+ messages in thread
From: Daniel Vetter @ 2016-05-02 8:20 UTC (permalink / raw)
To: Robert Foss; +Cc: daniel.vetter, intel-gfx
On Thu, Apr 28, 2016 at 11:57:21AM -0400, Robert Foss wrote:
>
>
> On 04/28/2016 10:41 AM, Daniel Vetter wrote:
> >On Thu, Apr 28, 2016 at 10:07:41AM -0400, Robert Foss wrote:
> >>
> >>
> >>On 04/28/2016 04:02 AM, Daniel Vetter wrote:
> >>>On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote:
> >>>>
> >>>>
> >>>>On 04/26/2016 01:00 PM, Ville Syrjälä wrote:
> >>>>>On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote:
> >>>>>>
> >>>>>>
> >>>>>>On 04/26/2016 10:11 AM, Daniel Vetter wrote:
> >>>>>>>On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
> >>>>>>>>From: Robert Foss <robert.foss@collabora.com>
> >>>>>>>>
> >>>>>>>>Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
> >>>>>>>>connectors.
> >>>>>>>>
> >>>>>>>>Signed-off-by: Robert Foss <robert.foss@collabora.com>
> >>>>>>>>---
> >>>>>>>> tests/kms_panel_fitting.c | 12 +++++++++---
> >>>>>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
> >>>>>>>>
> >>>>>>>>diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
> >>>>>>>>index 60a22b0..933776c 100644
> >>>>>>>>--- a/tests/kms_panel_fitting.c
> >>>>>>>>+++ b/tests/kms_panel_fitting.c
> >>>>>>>>@@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
> >>>>>>>> for_each_connected_output(display, output) {
> >>>>>>>> drmModeModeInfo *mode, native_mode;
> >>>>>>>>
> >>>>>>>>- if (output->config.connector->connector_type !=
> >>>>>>>>- DRM_MODE_CONNECTOR_eDP)
> >>>>>>>>- continue;
> >>>>>>>>+ switch (output->config.connector->connector_type)
> >>>>>>>>+ {
> >>>>>>>>+ case DRM_MODE_CONNECTOR_LVDS:
> >>>>>>>>+ case DRM_MODE_CONNECTOR_eDP:
> >>>>>>>>+ case DRM_MODE_CONNECTOR_DSI:
> >>>>>>>>+ break;
> >>>>>>>>+ default:
> >>>>>>>>+ continue;
> >>>>>>>>+ }
> >>>>>>>
> >>>>>>>I think ville commented that we should instead check for "scaling mode",
> >>>>>>>and we discussed this on irc. Am I accidentally looking at an old patch
> >>>>>>>series?
> >>>>>>>-Daniel
> >>>>>>>
> >>>>>>No, this isn't an old patch, I misunderstood where our conversation ended.
> >>>>>>
> >>>>>>"scaling mode" is an intel specific extension as far as I understand it,
> >>>>>>which is somewhat the opposite of generalizing i-g-t tests.
> >>>>>>
> >>>>>>Is there an architecture independent way forward?
> >>>>>
> >>>>>A quick poke at cscope tells me "scaling mode" is used by amdgpu, gma500,
> >>>>>i915, nouveau, and radeon. Seems fairly independent to me.
> >>>>>
> >>>>If that is the case, and it seems to be, "scaling mode" is definitely
> >>>>worth pursuing.
> >>>
> >>>Perhaps also send in a kernel patch to update the docbook table? It's
> >>>awful, but the best thing we have right now ...
> >>>-Daniel
> >>>
> >>
> >>Other than a Description/Restrictions entry for "scaling mode", is there
> >>anything you'd like to see added?
> >
> >I meant moving it into the generic section and list which drivers support
> >it. No need to change the description itself - that's an entire project on
> >itself.
> >-Daniel
> >
>
> I'm not seeing any other properties that have driver support listed. Would
> adding a column called "Driver support" make sense?
Not sure we want to go to all that trouble. The current table is pretty
much a dead-end wrt documentation, and we're just stalling on getting
better markup support for kerneldoc before we can fix it all up properly.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.
2016-05-02 8:20 ` Daniel Vetter
@ 2016-05-02 19:16 ` Robert Foss
0 siblings, 0 replies; 23+ messages in thread
From: Robert Foss @ 2016-05-02 19:16 UTC (permalink / raw)
To: Daniel Vetter; +Cc: daniel.vetter, intel-gfx, Tomeu Vizoso
On 05/02/2016 04:20 AM, Daniel Vetter wrote:
> On Thu, Apr 28, 2016 at 11:57:21AM -0400, Robert Foss wrote:
>>
>>
>> On 04/28/2016 10:41 AM, Daniel Vetter wrote:
>>> On Thu, Apr 28, 2016 at 10:07:41AM -0400, Robert Foss wrote:
>>>>
>>>>
>>>> On 04/28/2016 04:02 AM, Daniel Vetter wrote:
>>>>> On Tue, Apr 26, 2016 at 01:08:35PM -0400, Robert Foss wrote:
>>>>>>
>>>>>>
>>>>>> On 04/26/2016 01:00 PM, Ville Syrjälä wrote:
>>>>>>> On Tue, Apr 26, 2016 at 12:55:54PM -0400, Robert Foss wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 04/26/2016 10:11 AM, Daniel Vetter wrote:
>>>>>>>>> On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.foss@collabora.com wrote:
>>>>>>>>>> From: Robert Foss <robert.foss@collabora.com>
>>>>>>>>>>
>>>>>>>>>> Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI
>>>>>>>>>> connectors.
>>>>>>>>>>
>>>>>>>>>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>>>>>>>>>> ---
>>>>>>>>>> tests/kms_panel_fitting.c | 12 +++++++++---
>>>>>>>>>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>>>>>>>>>
>>>>>>>>>> diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c
>>>>>>>>>> index 60a22b0..933776c 100644
>>>>>>>>>> --- a/tests/kms_panel_fitting.c
>>>>>>>>>> +++ b/tests/kms_panel_fitting.c
>>>>>>>>>> @@ -140,9 +140,15 @@ static void test_panel_fitting(data_t *d)
>>>>>>>>>> for_each_connected_output(display, output) {
>>>>>>>>>> drmModeModeInfo *mode, native_mode;
>>>>>>>>>>
>>>>>>>>>> - if (output->config.connector->connector_type !=
>>>>>>>>>> - DRM_MODE_CONNECTOR_eDP)
>>>>>>>>>> - continue;
>>>>>>>>>> + switch (output->config.connector->connector_type)
>>>>>>>>>> + {
>>>>>>>>>> + case DRM_MODE_CONNECTOR_LVDS:
>>>>>>>>>> + case DRM_MODE_CONNECTOR_eDP:
>>>>>>>>>> + case DRM_MODE_CONNECTOR_DSI:
>>>>>>>>>> + break;
>>>>>>>>>> + default:
>>>>>>>>>> + continue;
>>>>>>>>>> + }
>>>>>>>>>
>>>>>>>>> I think ville commented that we should instead check for "scaling mode",
>>>>>>>>> and we discussed this on irc. Am I accidentally looking at an old patch
>>>>>>>>> series?
>>>>>>>>> -Daniel
>>>>>>>>>
>>>>>>>> No, this isn't an old patch, I misunderstood where our conversation ended.
>>>>>>>>
>>>>>>>> "scaling mode" is an intel specific extension as far as I understand it,
>>>>>>>> which is somewhat the opposite of generalizing i-g-t tests.
>>>>>>>>
>>>>>>>> Is there an architecture independent way forward?
>>>>>>>
>>>>>>> A quick poke at cscope tells me "scaling mode" is used by amdgpu, gma500,
>>>>>>> i915, nouveau, and radeon. Seems fairly independent to me.
>>>>>>>
>>>>>> If that is the case, and it seems to be, "scaling mode" is definitely
>>>>>> worth pursuing.
>>>>>
>>>>> Perhaps also send in a kernel patch to update the docbook table? It's
>>>>> awful, but the best thing we have right now ...
>>>>> -Daniel
>>>>>
>>>>
>>>> Other than a Description/Restrictions entry for "scaling mode", is there
>>>> anything you'd like to see added?
>>>
>>> I meant moving it into the generic section and list which drivers support
>>> it. No need to change the description itself - that's an entire project on
>>> itself.
>>> -Daniel
>>>
>>
>> I'm not seeing any other properties that have driver support listed. Would
>> adding a column called "Driver support" make sense?
>
> Not sure we want to go to all that trouble. The current table is pretty
> much a dead-end wrt documentation, and we're just stalling on getting
> better markup support for kerneldoc before we can fix it all up properly.
> -Daniel
>
Documentation patch submitted to lkml.
This series should be cleared for merging now.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2016-05-02 19:16 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-22 21:24 [PATCH i-g-t 0/7] Improve kms_panel_fitting robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 1/7] kms_panel_fitting: Remove un-read variable robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 2/7] kms_panel_fitting: Remove un-read variable pipe_crc robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 3/7] kms_panel_fitting: Remove un-used variable robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 4/7] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 5/7] kms_panel_fitting: Enabled test on non-Intel hardware robert.foss
2016-04-22 21:24 ` [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector robert.foss
2016-04-26 14:10 ` Daniel Vetter
2016-04-26 16:50 ` Robert Foss
2016-04-28 8:01 ` Daniel Vetter
2016-04-22 21:25 ` [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors robert.foss
2016-04-22 22:31 ` Marius Vlad
2016-04-26 14:11 ` Daniel Vetter
2016-04-26 16:55 ` Robert Foss
2016-04-26 17:00 ` Ville Syrjälä
2016-04-26 17:08 ` Robert Foss
2016-04-28 8:02 ` Daniel Vetter
2016-04-28 14:07 ` Robert Foss
2016-04-28 14:41 ` Daniel Vetter
2016-04-28 15:57 ` Robert Foss
2016-05-02 8:20 ` Daniel Vetter
2016-05-02 19:16 ` Robert Foss
2016-04-26 14:11 ` [PATCH i-g-t 0/7] Improve kms_panel_fitting Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.