Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg

From: Peter Zijlstra <peterz@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg
Date: Tue, 26 Apr 2016 13:12:13 +0200	[thread overview]
Message-ID: <20160426111213.GS3448@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160425195437.GA25465@kroah.com>

On Mon, Apr 25, 2016 at 12:54:37PM -0700, Greg Kroah-Hartman wrote:
> On Mon, Apr 25, 2016 at 09:24:35PM +0200, Peter Zijlstra wrote:
> > On Mon, Apr 25, 2016 at 12:18:15PM -0700, Greg Kroah-Hartman wrote:
> > > On Mon, Apr 25, 2016 at 09:06:51PM +0200, Peter Zijlstra wrote:
> > > > On Mon, Apr 25, 2016 at 02:56:06PM -0400, Steven Rostedt wrote:
> > > > > +static bool __read_mostly devkmsg_disabled;
> > > > > +static int __init disable_devkmsg(char *str)
> > > > > +{
> > > > > +	devkmsg_disabled = true;
> > > > > +	return 0;
> > > > > +}
> > > > > +__setup("printk.disable_kmsg_write", disable_devkmsg);
> > > > 
> > > > Again, please default enable and use an easier name to toggle this.
> > > > Userspace flooding this with junk is really insane.
> > > 
> > > If you default enable, you break working systems today that want to log
> > > stuff through this interface, sorry.
> > 
> > Oh, you mean those 'working' systems that livelocked my box because I
> > had console to serial enabled which could not keep up with the endless
> > flood of shite?
> > 
> > This systemd exposure has seriously eroded your sanity.
> 
> See Andrew's message, this was added because of klibc :)

The initial feature, yes. But systemd ran with it and made it a problem
(as per usual).