All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg
Date: Mon, 25 Apr 2016 12:34:23 -0700	[thread overview]
Message-ID: <CA+55aFx3+cBN6Q1xBGiFmQeVmwvSmpDC7+2x8Rq9eV8x5mV5Jw@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFzKP4N0xSZGF4kkTcK7iOyAmOK+CR1B=DfD8=TsN0qnEA@mail.gmail.com>

On Mon, Apr 25, 2016 at 12:28 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> I think it should be a tristate with "yes/no/ratelimit", and let's
> default to ratelimit.

Oh, and in general we should *not* use "negative" settings. It's
really annoying to have to enable things with a double negative.

So even if you want to disable something, you should see it as an
"enable" that is on by default, and you can then disable things by
turning that setting off.

That just makes things way more logical.

(Which is not to say that we haven't made this mistake in the past, but ...)

              Linus

  reply	other threads:[~2016-04-25 19:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 18:56 [PATCH v2] printk: Add kernel parameter to disable writes to /dev/kmsg Steven Rostedt
2016-04-25 19:06 ` Peter Zijlstra
2016-04-25 19:18   ` Greg Kroah-Hartman
2016-04-25 19:24     ` Peter Zijlstra
2016-04-25 19:44       ` Andrew Morton
2016-04-25 19:54       ` Greg Kroah-Hartman
2016-04-25 20:00         ` Steven Rostedt
2016-04-25 20:23           ` Linus Torvalds
2016-04-25 20:34             ` Steven Rostedt
2016-04-25 20:45               ` Linus Torvalds
2016-04-25 21:23                 ` Steven Rostedt
2016-04-26 11:01             ` Borislav Petkov
2016-04-26 11:12         ` Peter Zijlstra
2016-04-25 19:30     ` Steven Rostedt
2016-04-25 19:28   ` Linus Torvalds
2016-04-25 19:34     ` Linus Torvalds [this message]
2016-04-25 19:35     ` Steven Rostedt
2016-04-25 19:44     ` Steven Rostedt
2016-04-26  5:36       ` Ingo Molnar
2016-04-26 10:43         ` Bjørn Mork
2016-04-26 11:09           ` Peter Zijlstra
2016-04-25 19:46 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFx3+cBN6Q1xBGiFmQeVmwvSmpDC7+2x8Rq9eV8x5mV5Jw@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.