From: Jiri Benc <jbenc@redhat.com>
To: Simon Horman <simon.horman@netronome.com>
Cc: pravin shelar <pshelar@ovn.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
ovs dev <dev@openvswitch.org>, Lorand Jakab <lojakab@cisco.com>,
Thomas Morin <thomas.morin@orange.com>
Subject: Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support
Date: Wed, 11 May 2016 15:57:26 +0200 [thread overview]
Message-ID: <20160511155726.17268c07@griffin> (raw)
In-Reply-To: <20160511015009.GB24436@vergenet.net>
On Wed, 11 May 2016 10:50:12 +0900, Simon Horman wrote:
> On Tue, May 10, 2016 at 02:01:06PM +0200, Jiri Benc wrote:
> > We have two options here:
> >
> > 1. As for metadata tunnels all the info is in metadata_dst and we
> > don't need the IP/GRE header for anything, we can make the ipgre
> > interface ARPHRD_NONE in metadata based mode.
> >
> > 2. We can fix this up in ovs after receiving the packet from
> > ARPHRD_IPGRE interface.
> >
> > I think the first option is the correct one. We already don't assign
> > dev->header_ops in metadata mode. I'll prepare a patch.
>
> I agree that 1. seems to be the better approach.
I just sent a patch that fixes this. And we have the same bug in
VXLAN-GPE, I sent a patch, too.
> Sure, if that is your preference I think it should be simple enough to
> implement. I agree that netdev_port_receive() looks like a good place for
> this.
Great, thanks!
Jiri
next prev parent reply other threads:[~2016-05-11 13:57 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 7:36 [PATCH v9 net-next 0/7] openvswitch: support for layer 3 encapsulated packets Simon Horman
2016-05-04 7:36 ` [PATCH v9 net-next 1/7] net: add skb_vlan_deaccel helper Simon Horman
2016-05-04 7:36 ` [PATCH v9 net-next 2/7] openvswitch: set skb protocol when receiving on internal device Simon Horman
2016-05-04 7:36 ` [PATCH v9 net-next 3/7] openvswitch: add support to push and pop mpls for layer3 packets Simon Horman
[not found] ` <1462347393-22354-4-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2016-05-05 17:35 ` pravin shelar
2016-05-06 4:33 ` Simon Horman
2016-05-04 7:36 ` [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support Simon Horman
[not found] ` <1462347393-22354-5-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2016-05-05 17:37 ` pravin shelar
2016-05-06 5:57 ` Simon Horman
2016-05-06 9:25 ` Jiri Benc
2016-05-09 8:04 ` Simon Horman
[not found] ` <20160509080420.GA4470-IxS8c3vjKQDk1uMJSBkQmQ@public.gmane.org>
2016-05-10 12:01 ` Jiri Benc
2016-05-11 1:50 ` Simon Horman
[not found] ` <20160511015009.GB24436-IxS8c3vjKQDk1uMJSBkQmQ@public.gmane.org>
2016-05-11 3:06 ` Simon Horman
2016-05-11 14:09 ` Jiri Benc
2016-05-11 22:46 ` Simon Horman
2016-05-17 14:43 ` Jiri Benc
2016-05-18 2:18 ` Simon Horman
2016-05-11 13:57 ` Jiri Benc [this message]
2016-05-06 9:35 ` Jiri Benc
2016-05-09 8:18 ` Simon Horman
2016-05-10 0:16 ` [ovs-dev] " Yang, Yi Y
[not found] ` <79BBBFE6CB6C9B488C1A45ACD284F51913CB6446-0J0gbvR4kTggGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-10 12:07 ` Jiri Benc
2016-05-10 12:06 ` Jiri Benc
2016-05-11 3:28 ` Simon Horman
2016-05-11 14:10 ` Jiri Benc
2016-05-17 14:32 ` Jiri Benc
2016-05-20 5:29 ` Simon Horman
2016-05-20 8:00 ` Jiri Benc
2016-05-20 8:11 ` Simon Horman
2016-05-20 8:16 ` Simon Horman
[not found] ` <20160520081611.GB17561-IxS8c3vjKQDk1uMJSBkQmQ@public.gmane.org>
2016-05-20 8:39 ` Jiri Benc
2016-05-20 9:12 ` Simon Horman
2016-05-20 9:20 ` Jiri Benc
2016-05-20 10:14 ` Simon Horman
[not found] ` <1462347393-22354-1-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2016-05-04 7:36 ` [PATCH v9 net-next 5/7] openvswitch: add layer 3 support to ovs_packet_cmd_execute() Simon Horman
[not found] ` <1462347393-22354-6-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2016-05-17 14:51 ` Jiri Benc
2016-05-18 2:24 ` Simon Horman
2016-05-04 7:36 ` [PATCH v9 net-next 6/7] openvswitch: extend layer 3 support to cover non-IP packets Simon Horman
2016-05-04 7:36 ` [PATCH v9 net-next 7/7] openvswitch: use ipgre tunnel rather than gretap tunnel Simon Horman
[not found] ` <1462347393-22354-8-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2016-05-05 21:45 ` pravin shelar
2016-05-06 6:54 ` Simon Horman
2016-05-06 9:15 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511155726.17268c07@griffin \
--to=jbenc@redhat.com \
--cc=dev@openvswitch.org \
--cc=lojakab@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=simon.horman@netronome.com \
--cc=thomas.morin@orange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.