From: Mark Brown <broonie@kernel.org> To: Christer Weinigel <christer@weinigel.se> Cc: Rob Herring <robh@kernel.org>, Frank Rowand <frowand.list@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH] devicetree - document using aliases to set spi bus number. Date: Thu, 26 May 2016 19:47:46 +0100 [thread overview] Message-ID: <20160526184746.GF16172@sirena.org.uk> (raw) In-Reply-To: <5746D6CE.5020605@weinigel.se> [-- Attachment #1: Type: text/plain, Size: 2176 bytes --] On Thu, May 26, 2016 at 12:58:22PM +0200, Christer Weinigel wrote: > One of the main drivers behind devicetree was that Linus got fed up > with the churn for all platform device changes in arch/arm. I faintly > recall him writing that he would be rather unhappy if that just got > replaced with churn for devicetree dts files. Since device trees are hardware descriptions they really shouldn't be churning at all - if they are that's an indication that we're failing at device tree. > It makes sense to include dts files for reference boards in the > mainline kernel. To include dts files for every vendors variant of a > design would add just as much churn and be rather pointless. My guess > is that the dts file for most platforms are kept private. Well, a huge proportion of platforms don't work with upstream or upgrade kernel versions at all but rather use vendor BSPs with all sorts of fun stuff that the broader community would question strongly. It's really quite muddy. > For platforms based on a FPGA such as the Xilinx Zync it's even more > pointless to submit dts files to mainline. When you have "hardware" > that can be reconfigured the device tree files can't be set in stone. > If I use Xilinx tools [1] to add one more UART I have just added new > hardware this needs to be reflected in the devicetree for the devices > to be usable in Linux. And something like aliases which provides a > stable device name can be very useful here. Right, but it doesn't follow that aliases are what we should be doing here - both Rob and myself have mentioned providing a way to label the actual SPI devices themselves, this seems like a more robust way of doing things. For example in a FPGA environment it would allow you to keep names stable even if you decide to reorganize the distribution of devices between controllers or mappings of chip selects and would have similar benefits for handling board variants. Just numbering the buses provides a partial solution for some systems with usability drawbacks (you need to know the number to name mapping somehow), naming devices is both more direct and more general. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Christer Weinigel <christer-rKHMIqA5R6gwFerOooGFRg@public.gmane.org> Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH] devicetree - document using aliases to set spi bus number. Date: Thu, 26 May 2016 19:47:46 +0100 [thread overview] Message-ID: <20160526184746.GF16172@sirena.org.uk> (raw) In-Reply-To: <5746D6CE.5020605-rKHMIqA5R6gwFerOooGFRg@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 2176 bytes --] On Thu, May 26, 2016 at 12:58:22PM +0200, Christer Weinigel wrote: > One of the main drivers behind devicetree was that Linus got fed up > with the churn for all platform device changes in arch/arm. I faintly > recall him writing that he would be rather unhappy if that just got > replaced with churn for devicetree dts files. Since device trees are hardware descriptions they really shouldn't be churning at all - if they are that's an indication that we're failing at device tree. > It makes sense to include dts files for reference boards in the > mainline kernel. To include dts files for every vendors variant of a > design would add just as much churn and be rather pointless. My guess > is that the dts file for most platforms are kept private. Well, a huge proportion of platforms don't work with upstream or upgrade kernel versions at all but rather use vendor BSPs with all sorts of fun stuff that the broader community would question strongly. It's really quite muddy. > For platforms based on a FPGA such as the Xilinx Zync it's even more > pointless to submit dts files to mainline. When you have "hardware" > that can be reconfigured the device tree files can't be set in stone. > If I use Xilinx tools [1] to add one more UART I have just added new > hardware this needs to be reflected in the devicetree for the devices > to be usable in Linux. And something like aliases which provides a > stable device name can be very useful here. Right, but it doesn't follow that aliases are what we should be doing here - both Rob and myself have mentioned providing a way to label the actual SPI devices themselves, this seems like a more robust way of doing things. For example in a FPGA environment it would allow you to keep names stable even if you decide to reorganize the distribution of devices between controllers or mappings of chip selects and would have similar benefits for handling board variants. Just numbering the buses provides a partial solution for some systems with usability drawbacks (you need to know the number to name mapping somehow), naming devices is both more direct and more general. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-26 18:48 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-24 16:39 [PATCH] devicetree - document using aliases to set spi bus number Christer Weinigel 2016-05-24 16:39 ` Christer Weinigel 2016-05-24 17:20 ` Mark Brown 2016-05-24 18:03 ` Christer Weinigel 2016-05-24 18:32 ` Mark Brown 2016-05-24 18:57 ` Christer Weinigel 2016-05-24 18:57 ` Christer Weinigel 2016-05-25 12:19 ` Mark Rutland 2016-05-25 12:19 ` Mark Rutland 2016-05-25 12:50 ` Mark Brown 2016-05-25 12:33 ` Mark Brown 2016-05-25 12:33 ` Mark Brown 2016-05-24 23:34 ` Frank Rowand 2016-05-24 23:34 ` Frank Rowand 2016-05-25 0:18 ` Frank Rowand 2016-05-25 0:18 ` Frank Rowand 2016-05-25 17:49 ` Rob Herring 2016-05-25 18:03 ` Mark Brown 2016-05-25 18:06 ` Frank Rowand 2016-05-25 18:44 ` Mark Brown 2016-05-26 1:10 ` Christer Weinigel 2016-05-26 1:44 ` Rob Herring 2016-05-26 1:44 ` Rob Herring 2016-05-26 1:56 ` Christer Weinigel 2016-05-26 10:07 ` Mark Brown 2016-05-26 10:07 ` Mark Brown 2016-05-26 10:58 ` Christer Weinigel 2016-05-26 18:47 ` Mark Brown [this message] 2016-05-26 18:47 ` Mark Brown 2016-05-26 21:04 ` Christer Weinigel 2016-05-26 21:04 ` Christer Weinigel 2016-05-27 16:43 ` Mark Brown 2016-05-24 17:41 ` Mark Rutland 2016-05-24 20:41 ` Frank Rowand 2016-05-25 9:20 ` Mark Rutland 2016-05-25 9:20 ` Mark Rutland 2016-05-25 10:38 ` Mark Brown 2016-05-25 10:38 ` Mark Brown 2016-05-25 11:20 ` Christer Weinigel 2016-05-25 12:34 ` Mark Rutland 2016-05-25 12:34 ` Mark Rutland 2016-05-25 13:08 ` Mark Brown 2016-05-25 13:08 ` Mark Brown 2016-05-25 15:32 ` Frank Rowand 2016-05-25 15:32 ` Frank Rowand 2016-05-25 15:59 ` Mark Rutland 2016-05-25 15:59 ` Mark Rutland 2016-05-25 16:21 ` Frank Rowand 2016-05-25 16:21 ` Frank Rowand 2016-05-25 18:02 ` Mark Brown 2016-05-25 17:48 ` Mark Brown 2016-05-25 17:48 ` Mark Brown 2016-05-25 18:46 ` Frank Rowand 2016-05-27 18:36 ` Mark Brown 2016-05-27 18:36 ` Mark Brown 2016-05-28 20:57 ` Christer Weinigel 2016-05-30 16:13 ` Mark Brown 2016-05-30 16:13 ` Mark Brown 2016-05-25 15:25 ` Frank Rowand 2016-05-25 15:25 ` Frank Rowand 2016-05-25 16:06 ` Mark Rutland 2016-05-25 16:06 ` Mark Rutland 2016-05-25 16:31 ` Frank Rowand 2016-05-25 18:44 ` Rob Herring 2016-05-25 18:44 ` Rob Herring 2016-05-25 18:48 ` Mark Brown 2016-05-25 18:48 ` Mark Brown 2016-05-26 8:21 ` Geert Uytterhoeven 2016-05-26 8:21 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160526184746.GF16172@sirena.org.uk \ --to=broonie@kernel.org \ --cc=christer@weinigel.se \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.