From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH resend v2 5/6] ARM: dts: sun9i: a80-optimus: Disable dummy regulators vcc3v0, vcc3v3, vcc5v0
Date: Wed, 1 Jun 2016 09:01:14 +0200 [thread overview]
Message-ID: <20160601070114.GQ4908@lukather> (raw)
In-Reply-To: <CAGb2v65_kAtrOW_G51Tn1urroXVuo=AqzX66zm7Ewsyw_AJdvA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]
On Wed, Jun 01, 2016 at 10:45:51AM +0800, Chen-Yu Tsai wrote:
> On Wed, Jun 1, 2016 at 3:01 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi,
> >
> > On Wed, Jun 01, 2016 at 12:23:23AM +0800, Chen-Yu Tsai wrote:
> >> These 3 regulators are provided in sunxi-common-regulators.dtsi.
> >> 3.0V/3.3V and 5.0V are commonly used voltages in Allwinner devices.
> >> These dummy regulators provide a stand-in when bindings that require
> >> one, but the real regulator is not supported yet.
> >>
> >> Since these are no longer needed, we can disable them.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> ---
> >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 12 ++++++++++++
> >> 1 file changed, 12 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts
> >> index 6cfc02194035..991337d1d6f1 100644
> >> --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts
> >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts
> >> @@ -322,6 +322,18 @@
> >>
> >> #include "axp809.dtsi"
> >>
> >> +®_vcc3v0 {
> >> + status = "disabled";
> >> +};
> >> +
> >> +®_vcc3v3 {
> >> + status = "disabled";
> >> +};
> >> +
> >> +®_vcc5v0 {
> >> + status = "disabled";
> >> +};
> >> +
> >
> > Why not remove the include entirely?
>
> reg_usb1_vbus is still used. Or I could just copy it and
> get rid of the include.
Ah yes, it is on the Optimus (but not the cubieboard I initially
looked at).
Since we have that other regulator usb3 regulator, we can simply
remove it.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH resend v2 5/6] ARM: dts: sun9i: a80-optimus: Disable dummy regulators vcc3v0, vcc3v3, vcc5v0
Date: Wed, 1 Jun 2016 09:01:14 +0200 [thread overview]
Message-ID: <20160601070114.GQ4908@lukather> (raw)
In-Reply-To: <CAGb2v65_kAtrOW_G51Tn1urroXVuo=AqzX66zm7Ewsyw_AJdvA@mail.gmail.com>
On Wed, Jun 01, 2016 at 10:45:51AM +0800, Chen-Yu Tsai wrote:
> On Wed, Jun 1, 2016 at 3:01 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi,
> >
> > On Wed, Jun 01, 2016 at 12:23:23AM +0800, Chen-Yu Tsai wrote:
> >> These 3 regulators are provided in sunxi-common-regulators.dtsi.
> >> 3.0V/3.3V and 5.0V are commonly used voltages in Allwinner devices.
> >> These dummy regulators provide a stand-in when bindings that require
> >> one, but the real regulator is not supported yet.
> >>
> >> Since these are no longer needed, we can disable them.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> ---
> >> arch/arm/boot/dts/sun9i-a80-optimus.dts | 12 ++++++++++++
> >> 1 file changed, 12 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/sun9i-a80-optimus.dts b/arch/arm/boot/dts/sun9i-a80-optimus.dts
> >> index 6cfc02194035..991337d1d6f1 100644
> >> --- a/arch/arm/boot/dts/sun9i-a80-optimus.dts
> >> +++ b/arch/arm/boot/dts/sun9i-a80-optimus.dts
> >> @@ -322,6 +322,18 @@
> >>
> >> #include "axp809.dtsi"
> >>
> >> +®_vcc3v0 {
> >> + status = "disabled";
> >> +};
> >> +
> >> +®_vcc3v3 {
> >> + status = "disabled";
> >> +};
> >> +
> >> +®_vcc5v0 {
> >> + status = "disabled";
> >> +};
> >> +
> >
> > Why not remove the include entirely?
>
> reg_usb1_vbus is still used. Or I could just copy it and
> get rid of the include.
Ah yes, it is on the Optimus (but not the cubieboard I initially
looked at).
Since we have that other regulator usb3 regulator, we can simply
remove it.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160601/80858236/attachment.sig>
next prev parent reply other threads:[~2016-06-01 7:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 16:23 [PATCH resend v2 0/6] regulator: axp20x: Add support for AXP809 PMIC Chen-Yu Tsai
2016-05-31 16:23 ` Chen-Yu Tsai
2016-05-31 16:23 ` [PATCH resend v2 1/6] regulator: axp20x: support AXP809 variant Chen-Yu Tsai
2016-05-31 16:23 ` Chen-Yu Tsai
2016-05-31 17:36 ` Mark Brown
2016-05-31 17:36 ` Mark Brown
2016-06-01 2:03 ` Chen-Yu Tsai
2016-06-01 2:03 ` Chen-Yu Tsai
2016-06-02 10:27 ` Mark Brown
2016-06-02 10:27 ` Mark Brown
2016-06-02 11:05 ` Chen-Yu Tsai
2016-06-02 11:05 ` Chen-Yu Tsai
2016-06-02 13:25 ` Mark Brown
2016-06-02 13:25 ` Mark Brown
2016-06-02 14:14 ` Chen-Yu Tsai
2016-06-02 14:14 ` Chen-Yu Tsai
2016-05-31 16:23 ` [PATCH resend v2 2/6] ARM: dts: sunxi: Add dtsi file for AXP809 PMIC Chen-Yu Tsai
2016-05-31 16:23 ` Chen-Yu Tsai
2016-05-31 16:23 ` [PATCH resend v2 3/6] ARM: dts: sun9i: a80-optimus: Add AXP809 PMIC device node and regulators Chen-Yu Tsai
2016-05-31 16:23 ` Chen-Yu Tsai
2016-05-31 16:23 ` [PATCH resend v2 4/6] ARM: dts: sun9i: cubieboard4: " Chen-Yu Tsai
2016-05-31 16:23 ` Chen-Yu Tsai
2016-05-31 16:23 ` [PATCH resend v2 5/6] ARM: dts: sun9i: a80-optimus: Disable dummy regulators vcc3v0, vcc3v3, vcc5v0 Chen-Yu Tsai
2016-05-31 16:23 ` Chen-Yu Tsai
2016-05-31 19:01 ` Maxime Ripard
2016-05-31 19:01 ` Maxime Ripard
2016-06-01 2:45 ` Chen-Yu Tsai
2016-06-01 2:45 ` Chen-Yu Tsai
2016-06-01 7:01 ` Maxime Ripard [this message]
2016-06-01 7:01 ` Maxime Ripard
2016-05-31 16:23 ` [PATCH resend v2 6/6] ARM: dts: sun9i: cubieboard4: " Chen-Yu Tsai
2016-05-31 16:23 ` Chen-Yu Tsai
2016-05-31 19:02 ` [PATCH resend v2 0/6] regulator: axp20x: Add support for AXP809 PMIC Maxime Ripard
2016-05-31 19:02 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601070114.GQ4908@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.