* [PATCH] posix-clock: remove unneeded posix_clock_compat_ioctl()
@ 2016-06-01 8:54 Jungseung Lee
2016-06-01 14:32 ` Richard Cochran
2016-06-06 13:59 ` Thomas Gleixner
0 siblings, 2 replies; 3+ messages in thread
From: Jungseung Lee @ 2016-06-01 8:54 UTC (permalink / raw)
To: Thomas Gleixner, Richard Cochran, linux-kernel; +Cc: Jungseung Lee
posix_clock_compat_ioctl() is identical to posix_clock_ioctl().
We don't need additional compat_ioctl in this time.
Remove posix_clock_compat_ioctl() and let posix_clock_ioctl() is in charge.
Signed-off-by: Jungseung Lee <js07.lee@samsung.com>
---
kernel/time/posix-clock.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/kernel/time/posix-clock.c b/kernel/time/posix-clock.c
index 9cff0ab..d46ac80 100644
--- a/kernel/time/posix-clock.c
+++ b/kernel/time/posix-clock.c
@@ -131,25 +131,6 @@ static long posix_clock_ioctl(struct file *fp,
return err;
}
-#ifdef CONFIG_COMPAT
-static long posix_clock_compat_ioctl(struct file *fp,
- unsigned int cmd, unsigned long arg)
-{
- struct posix_clock *clk = get_posix_clock(fp);
- int err = -ENOTTY;
-
- if (!clk)
- return -ENODEV;
-
- if (clk->ops.ioctl)
- err = clk->ops.ioctl(clk, cmd, arg);
-
- put_posix_clock(clk);
-
- return err;
-}
-#endif
-
static int posix_clock_open(struct inode *inode, struct file *fp)
{
int err;
@@ -201,9 +182,6 @@ static const struct file_operations posix_clock_file_operations = {
.release = posix_clock_release,
.fasync = posix_clock_fasync,
.mmap = posix_clock_mmap,
-#ifdef CONFIG_COMPAT
- .compat_ioctl = posix_clock_compat_ioctl,
-#endif
};
int posix_clock_register(struct posix_clock *clk, dev_t devid)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] posix-clock: remove unneeded posix_clock_compat_ioctl()
2016-06-01 8:54 [PATCH] posix-clock: remove unneeded posix_clock_compat_ioctl() Jungseung Lee
@ 2016-06-01 14:32 ` Richard Cochran
2016-06-06 13:59 ` Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2016-06-01 14:32 UTC (permalink / raw)
To: Jungseung Lee; +Cc: Thomas Gleixner, linux-kernel
On Wed, Jun 01, 2016 at 05:54:41PM +0900, Jungseung Lee wrote:
> posix_clock_compat_ioctl() is identical to posix_clock_ioctl().
> We don't need additional compat_ioctl in this time.
> Remove posix_clock_compat_ioctl() and let posix_clock_ioctl() is in charge.
Did you test this patch? Did you run a 32 program using the ioctl on
a 64 bit kernel?
Thanks,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] posix-clock: remove unneeded posix_clock_compat_ioctl()
2016-06-01 8:54 [PATCH] posix-clock: remove unneeded posix_clock_compat_ioctl() Jungseung Lee
2016-06-01 14:32 ` Richard Cochran
@ 2016-06-06 13:59 ` Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2016-06-06 13:59 UTC (permalink / raw)
To: Jungseung Lee; +Cc: Richard Cochran, linux-kernel
On Wed, 1 Jun 2016, Jungseung Lee wrote:
> posix_clock_compat_ioctl() is identical to posix_clock_ioctl().
> We don't need additional compat_ioctl in this time.
> Remove posix_clock_compat_ioctl() and let posix_clock_ioctl() is in charge.
Which will return -ENOTTY for all affected ioctls simply because the ioctls
are not listed in the compatible list.
Thanks,
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-06 14:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-01 8:54 [PATCH] posix-clock: remove unneeded posix_clock_compat_ioctl() Jungseung Lee
2016-06-01 14:32 ` Richard Cochran
2016-06-06 13:59 ` Thomas Gleixner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.