From: "Pali Rohár" <pali.rohar@gmail.com> To: Gabriele Mazzotta <gabriele.mzt@gmail.com>, Mario Limonciello <mario_limonciello@dell.com> Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>, "Darren Hart" <dvhart@infradead.org>, "Michał Kępień" <kernel@kempniu.pl>, "Andy Lutomirski" <luto@kernel.org>, "Alex Hung" <alex.hung@canonical.com>, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] dell-wmi: Add information about other WMI event codes Date: Wed, 8 Jun 2016 01:00:08 +0200 [thread overview] Message-ID: <20160607230008.GQ29844@pali> (raw) In-Reply-To: <79752a4a-22b0-13ec-721c-d92b5dfd46e1@gmail.com> On Friday 27 May 2016 00:04:23 Gabriele Mazzotta wrote: > On 22/05/2016 13:36, Pali Rohár wrote: > > ACPI DSDT tables have defined other WMI codes, but does not contain any > > description when those codes are emitted. Some other codes can be found in > > logs on internet. In this patch are all which I saw, but lot of them are > > not tested properly (e.g. for duplicate events with AT keyboard). Now we > > have all WMI event codes at one place and in future after proper testing > > those codes can be correctly enabled or disabled... > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > --- > > drivers/platform/x86/dell-wmi.c | 32 ++++++++++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > > index 363d927..7aac1dc 100644 > > --- a/drivers/platform/x86/dell-wmi.c > > +++ b/drivers/platform/x86/dell-wmi.c > > @@ -110,6 +110,9 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = { > > /* BIOS error detected */ > > { KE_IGNORE, 0xe00d, { KEY_RESERVED } }, > > > > + /* Unknown, defined in ACPI DSDT */ > > + /* { KE_IGNORE, 0xe00e, { KEY_RESERVED } }, */ > > + > > I'm interested in knowing what's the meaning of this 0xe00e. This > event is sent multiple times when I suspend/resume my laptop and > it's definitely not a keypress. >From DSDT dumps which I have seen, I guess it could be something with battery charging... but that is only my guess. Mario, do you have any idea, what these unknown events are? > Anyway, I've been using this patch set and didn't notice any issue, so > > Tested-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> > > > /* Wifi Catcher */ > > { KE_KEY, 0xe011, { KEY_PROG2 } }, > > > > @@ -118,21 +121,45 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = { > > > > { KE_IGNORE, 0xe020, { KEY_MUTE } }, > > > > + /* Unknown, defined in ACPI DSDT */ > > + /* { KE_IGNORE, 0xe023, { KEY_RESERVED } }, */ > > + > > + /* Untested, Dell Instant Launch key on Inspiron 7520 */ > > + /* { KE_IGNORE, 0xe024, { KEY_RESERVED } }, */ > > + > > /* Dell Instant Launch key */ > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > > > /* Audio panel key */ > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > > + /* Untested, Multimedia key on Dell Vostro 3560 */ > > + /* { KE_IGNORE, 0xe028, { KEY_RESERVED } }, */ > > + > > /* Dell Instant Launch key */ > > { KE_KEY, 0xe029, { KEY_PROG4 } }, > > > > + /* Untested, Windows Mobility Center button on Inspiron 7520 */ > > + /* { KE_IGNORE, 0xe02a, { KEY_RESERVED } }, */ > > + > > + /* Unknown, defined in ACPI DSDT */ > > + /* { KE_IGNORE, 0xe02b, { KEY_RESERVED } }, */ > > + > > + /* Untested, Dell Audio With Preset Switch button on Inspiron 7520 */ > > + /* { KE_IGNORE, 0xe02c, { KEY_RESERVED } }, */ > > + > > { KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } }, > > { KE_IGNORE, 0xe030, { KEY_VOLUMEUP } }, > > { KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } }, > > { KE_IGNORE, 0xe034, { KEY_KBDILLUMDOWN } }, > > { KE_IGNORE, 0xe03a, { KEY_CAPSLOCK } }, > > > > + /* NIC Link is Up */ > > + { KE_IGNORE, 0xe043, { KEY_RESERVED } }, > > + > > + /* NIC Link is Down */ > > + { KE_IGNORE, 0xe044, { KEY_RESERVED } }, > > + > > /* > > * This entry is very suspicious! > > * Originally Matthew Garrett created this dell-wmi driver specially for > > @@ -145,7 +172,12 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = { > > */ > > { KE_IGNORE, 0xe045, { KEY_NUMLOCK } }, > > > > + /* Scroll lock and also going to tablet mode on portable devices */ > > { KE_IGNORE, 0xe046, { KEY_SCROLLLOCK } }, > > + > > + /* Untested, going from tablet mode on portable devices */ > > + /* { KE_IGNORE, 0xe047, { KEY_RESERVED } }, */ > > + > > { KE_IGNORE, 0xe0f7, { KEY_MUTE } }, > > { KE_IGNORE, 0xe0f8, { KEY_VOLUMEDOWN } }, > > { KE_IGNORE, 0xe0f9, { KEY_VOLUMEUP } }, > > -- Pali Rohár pali.rohar@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali.rohar@gmail.com> To: Gabriele Mazzotta <gabriele.mzt@gmail.com>, Mario Limonciello <mario_limonciello@dell.com> Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>, "Darren Hart" <dvhart@infradead.org>, "Michał Kępień" <kernel@kempniu.pl>, "Andy Lutomirski" <luto@kernel.org>, "Alex Hung" <alex.hung@canonical.com>, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] dell-wmi: Add information about other WMI event codes Date: Wed, 8 Jun 2016 01:00:08 +0200 [thread overview] Message-ID: <20160607230008.GQ29844@pali> (raw) In-Reply-To: <79752a4a-22b0-13ec-721c-d92b5dfd46e1@gmail.com> On Friday 27 May 2016 00:04:23 Gabriele Mazzotta wrote: > On 22/05/2016 13:36, Pali Rohár wrote: > > ACPI DSDT tables have defined other WMI codes, but does not contain any > > description when those codes are emitted. Some other codes can be found in > > logs on internet. In this patch are all which I saw, but lot of them are > > not tested properly (e.g. for duplicate events with AT keyboard). Now we > > have all WMI event codes at one place and in future after proper testing > > those codes can be correctly enabled or disabled... > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > --- > > drivers/platform/x86/dell-wmi.c | 32 ++++++++++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > > index 363d927..7aac1dc 100644 > > --- a/drivers/platform/x86/dell-wmi.c > > +++ b/drivers/platform/x86/dell-wmi.c > > @@ -110,6 +110,9 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = { > > /* BIOS error detected */ > > { KE_IGNORE, 0xe00d, { KEY_RESERVED } }, > > > > + /* Unknown, defined in ACPI DSDT */ > > + /* { KE_IGNORE, 0xe00e, { KEY_RESERVED } }, */ > > + > > I'm interested in knowing what's the meaning of this 0xe00e. This > event is sent multiple times when I suspend/resume my laptop and > it's definitely not a keypress. From DSDT dumps which I have seen, I guess it could be something with battery charging... but that is only my guess. Mario, do you have any idea, what these unknown events are? > Anyway, I've been using this patch set and didn't notice any issue, so > > Tested-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> > > > /* Wifi Catcher */ > > { KE_KEY, 0xe011, { KEY_PROG2 } }, > > > > @@ -118,21 +121,45 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = { > > > > { KE_IGNORE, 0xe020, { KEY_MUTE } }, > > > > + /* Unknown, defined in ACPI DSDT */ > > + /* { KE_IGNORE, 0xe023, { KEY_RESERVED } }, */ > > + > > + /* Untested, Dell Instant Launch key on Inspiron 7520 */ > > + /* { KE_IGNORE, 0xe024, { KEY_RESERVED } }, */ > > + > > /* Dell Instant Launch key */ > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > > > /* Audio panel key */ > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > > + /* Untested, Multimedia key on Dell Vostro 3560 */ > > + /* { KE_IGNORE, 0xe028, { KEY_RESERVED } }, */ > > + > > /* Dell Instant Launch key */ > > { KE_KEY, 0xe029, { KEY_PROG4 } }, > > > > + /* Untested, Windows Mobility Center button on Inspiron 7520 */ > > + /* { KE_IGNORE, 0xe02a, { KEY_RESERVED } }, */ > > + > > + /* Unknown, defined in ACPI DSDT */ > > + /* { KE_IGNORE, 0xe02b, { KEY_RESERVED } }, */ > > + > > + /* Untested, Dell Audio With Preset Switch button on Inspiron 7520 */ > > + /* { KE_IGNORE, 0xe02c, { KEY_RESERVED } }, */ > > + > > { KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } }, > > { KE_IGNORE, 0xe030, { KEY_VOLUMEUP } }, > > { KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } }, > > { KE_IGNORE, 0xe034, { KEY_KBDILLUMDOWN } }, > > { KE_IGNORE, 0xe03a, { KEY_CAPSLOCK } }, > > > > + /* NIC Link is Up */ > > + { KE_IGNORE, 0xe043, { KEY_RESERVED } }, > > + > > + /* NIC Link is Down */ > > + { KE_IGNORE, 0xe044, { KEY_RESERVED } }, > > + > > /* > > * This entry is very suspicious! > > * Originally Matthew Garrett created this dell-wmi driver specially for > > @@ -145,7 +172,12 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = { > > */ > > { KE_IGNORE, 0xe045, { KEY_NUMLOCK } }, > > > > + /* Scroll lock and also going to tablet mode on portable devices */ > > { KE_IGNORE, 0xe046, { KEY_SCROLLLOCK } }, > > + > > + /* Untested, going from tablet mode on portable devices */ > > + /* { KE_IGNORE, 0xe047, { KEY_RESERVED } }, */ > > + > > { KE_IGNORE, 0xe0f7, { KEY_MUTE } }, > > { KE_IGNORE, 0xe0f8, { KEY_VOLUMEDOWN } }, > > { KE_IGNORE, 0xe0f9, { KEY_VOLUMEUP } }, > > -- Pali Rohár pali.rohar@gmail.com
next prev parent reply other threads:[~2016-06-07 23:00 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-22 11:36 [PATCH 0/4] dell-wmi: Changes in WMI event code handling Pali Rohár 2016-05-22 11:36 ` [PATCH 1/4] dell-wmi: Ignore WMI event code 0xe045 Pali Rohár 2016-05-22 11:36 ` Pali Rohár 2016-05-22 11:36 ` [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments Pali Rohár 2016-06-02 10:41 ` Michał Kępień 2016-06-07 22:03 ` Pali Rohár 2016-06-08 19:48 ` Darren Hart 2016-06-08 19:57 ` Pali Rohár 2016-06-08 20:15 ` Darren Hart 2016-06-08 20:15 ` Darren Hart 2016-06-08 20:27 ` Pali Rohár 2016-06-08 20:43 ` Darren Hart 2016-06-08 20:49 ` Pali Rohár 2016-05-22 11:36 ` [PATCH 3/4] dell-wmi: Add information about other WMI event codes Pali Rohár 2016-05-26 22:04 ` Gabriele Mazzotta 2016-06-07 23:00 ` Pali Rohár [this message] 2016-06-07 23:00 ` Pali Rohár 2016-06-08 6:02 ` Mario_Limonciello 2016-06-08 6:02 ` Mario_Limonciello 2016-06-08 10:44 ` Gabriele Mazzotta 2016-06-15 19:51 ` Pali Rohár 2016-06-21 19:51 ` Mario_Limonciello 2016-06-21 19:51 ` Mario_Limonciello 2016-06-22 7:56 ` Pali Rohár 2016-06-22 13:40 ` Mario_Limonciello 2016-06-22 13:40 ` Mario_Limonciello 2016-06-22 14:12 ` Pali Rohár 2016-06-22 14:21 ` Mario_Limonciello 2016-06-22 14:21 ` Mario_Limonciello 2016-06-22 14:24 ` Pali Rohár 2016-06-22 14:28 ` Mario_Limonciello 2016-06-22 14:28 ` Mario_Limonciello 2016-06-22 14:31 ` Pali Rohár 2016-06-22 14:34 ` Mario_Limonciello 2016-06-22 14:34 ` Mario_Limonciello 2016-06-22 14:38 ` Pali Rohár 2016-06-22 14:39 ` Gabriele Mazzotta 2016-06-22 14:46 ` Mario_Limonciello 2016-06-22 14:46 ` Mario_Limonciello 2016-06-02 10:41 ` Michał Kępień 2016-06-07 22:06 ` Pali Rohár 2016-05-22 11:36 ` [PATCH 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events Pali Rohár 2016-05-23 17:07 ` Andy Lutomirski 2016-06-02 10:42 ` Michał Kępień 2016-06-07 22:30 ` Pali Rohár 2016-06-02 10:52 ` [PATCH 0/4] dell-wmi: Changes in WMI event code handling Michał Kępień
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160607230008.GQ29844@pali \ --to=pali.rohar@gmail.com \ --cc=alex.hung@canonical.com \ --cc=dvhart@infradead.org \ --cc=gabriele.mzt@gmail.com \ --cc=kernel@kempniu.pl \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mario_limonciello@dell.com \ --cc=mjg59@srcf.ucam.org \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.