From: <Mario_Limonciello@Dell.com>
To: <pali.rohar@gmail.com>
Cc: <gabriele.mzt@gmail.com>, <mjg59@srcf.ucam.org>,
<dvhart@infradead.org>, <kernel@kempniu.pl>, <luto@kernel.org>,
<alex.hung@canonical.com>, <platform-driver-x86@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/4] dell-wmi: Add information about other WMI event codes
Date: Wed, 22 Jun 2016 14:28:37 +0000 [thread overview]
Message-ID: <68dd5c56440d4fc9a1c09c69a548476a@ausx13mpc124.AMER.DELL.COM> (raw)
In-Reply-To: <20160622142407.GH29844@pali>
> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Wednesday, June 22, 2016 9:24 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: gabriele.mzt@gmail.com; mjg59@srcf.ucam.org; dvhart@infradead.org;
> kernel@kempniu.pl; luto@kernel.org; alex.hung@canonical.com; platform-
> driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 3/4] dell-wmi: Add information about other WMI event
> codes
>
> On Wednesday 22 June 2016 14:21:25 Mario_Limonciello@Dell.com wrote:
> > > > For Linux I don’t think this is necessary and a NOOP is appropriate.
> > > >
> > > > There is also a second place that some older laptops had a battery
> "hotkey"
> > > > that would also emit 0xE00E. This was also picked up by quickset and
> would
> > > > show battery information.
> > > >
> > > > This shouldn't be blocked by kernel, I'd expect if someone wants to
> bind
> > > this
> > > > to another application from userspace they should be able to.
> > >
> > > Great! Can I send patch after which 0xe00e will be send to input layer as
> > > event KEY_BATTERY?
> > >
> >
> > Well that's why I was mentioning this in two places. If it's received from
> keyboard
> > recoding it as KEY_BATTERY sounds appropriate to me. If it's received from
> WMI,
> > it really shouldn't be set as anything for Linux to do.
> >
> > I don't think any apps will benefit from the notification to re-read battery
> > Information today.
>
> I mean for dell-wmi.c code.
> Why it should not be set to anything on Linux?
>
On Windows Quickset is a separate application from built-in Windows battery
applet. It shows similar types of information as gnome-power-manager does,
but because it's not part of the OS, it doesn't get notifications like this so
special BIOS hooks are in place for it to know when to re-read battery
information.
On Linux, there are already infrastructure for battery removal and adding
notifications from ACPI. Sending this up to user space won't be useful.
WARNING: multiple messages have this Message-ID (diff)
From: <Mario_Limonciello@Dell.com>
To: pali.rohar@gmail.com
Cc: gabriele.mzt@gmail.com, mjg59@srcf.ucam.org,
dvhart@infradead.org, kernel@kempniu.pl, luto@kernel.org,
alex.hung@canonical.com, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: RE: [PATCH 3/4] dell-wmi: Add information about other WMI event codes
Date: Wed, 22 Jun 2016 14:28:37 +0000 [thread overview]
Message-ID: <68dd5c56440d4fc9a1c09c69a548476a@ausx13mpc124.AMER.DELL.COM> (raw)
In-Reply-To: <20160622142407.GH29844@pali>
> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Wednesday, June 22, 2016 9:24 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: gabriele.mzt@gmail.com; mjg59@srcf.ucam.org; dvhart@infradead.org;
> kernel@kempniu.pl; luto@kernel.org; alex.hung@canonical.com; platform-
> driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 3/4] dell-wmi: Add information about other WMI event
> codes
>
> On Wednesday 22 June 2016 14:21:25 Mario_Limonciello@Dell.com wrote:
> > > > For Linux I don’t think this is necessary and a NOOP is appropriate.
> > > >
> > > > There is also a second place that some older laptops had a battery
> "hotkey"
> > > > that would also emit 0xE00E. This was also picked up by quickset and
> would
> > > > show battery information.
> > > >
> > > > This shouldn't be blocked by kernel, I'd expect if someone wants to
> bind
> > > this
> > > > to another application from userspace they should be able to.
> > >
> > > Great! Can I send patch after which 0xe00e will be send to input layer as
> > > event KEY_BATTERY?
> > >
> >
> > Well that's why I was mentioning this in two places. If it's received from
> keyboard
> > recoding it as KEY_BATTERY sounds appropriate to me. If it's received from
> WMI,
> > it really shouldn't be set as anything for Linux to do.
> >
> > I don't think any apps will benefit from the notification to re-read battery
> > Information today.
>
> I mean for dell-wmi.c code.
> Why it should not be set to anything on Linux?
>
On Windows Quickset is a separate application from built-in Windows battery
applet. It shows similar types of information as gnome-power-manager does,
but because it's not part of the OS, it doesn't get notifications like this so
special BIOS hooks are in place for it to know when to re-read battery
information.
On Linux, there are already infrastructure for battery removal and adding
notifications from ACPI. Sending this up to user space won't be useful.
next prev parent reply other threads:[~2016-06-22 14:28 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-22 11:36 [PATCH 0/4] dell-wmi: Changes in WMI event code handling Pali Rohár
2016-05-22 11:36 ` [PATCH 1/4] dell-wmi: Ignore WMI event code 0xe045 Pali Rohár
2016-05-22 11:36 ` Pali Rohár
2016-05-22 11:36 ` [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments Pali Rohár
2016-06-02 10:41 ` Michał Kępień
2016-06-07 22:03 ` Pali Rohár
2016-06-08 19:48 ` Darren Hart
2016-06-08 19:57 ` Pali Rohár
2016-06-08 20:15 ` Darren Hart
2016-06-08 20:15 ` Darren Hart
2016-06-08 20:27 ` Pali Rohár
2016-06-08 20:43 ` Darren Hart
2016-06-08 20:49 ` Pali Rohár
2016-05-22 11:36 ` [PATCH 3/4] dell-wmi: Add information about other WMI event codes Pali Rohár
2016-05-26 22:04 ` Gabriele Mazzotta
2016-06-07 23:00 ` Pali Rohár
2016-06-07 23:00 ` Pali Rohár
2016-06-08 6:02 ` Mario_Limonciello
2016-06-08 6:02 ` Mario_Limonciello
2016-06-08 10:44 ` Gabriele Mazzotta
2016-06-15 19:51 ` Pali Rohár
2016-06-21 19:51 ` Mario_Limonciello
2016-06-21 19:51 ` Mario_Limonciello
2016-06-22 7:56 ` Pali Rohár
2016-06-22 13:40 ` Mario_Limonciello
2016-06-22 13:40 ` Mario_Limonciello
2016-06-22 14:12 ` Pali Rohár
2016-06-22 14:21 ` Mario_Limonciello
2016-06-22 14:21 ` Mario_Limonciello
2016-06-22 14:24 ` Pali Rohár
2016-06-22 14:28 ` Mario_Limonciello [this message]
2016-06-22 14:28 ` Mario_Limonciello
2016-06-22 14:31 ` Pali Rohár
2016-06-22 14:34 ` Mario_Limonciello
2016-06-22 14:34 ` Mario_Limonciello
2016-06-22 14:38 ` Pali Rohár
2016-06-22 14:39 ` Gabriele Mazzotta
2016-06-22 14:46 ` Mario_Limonciello
2016-06-22 14:46 ` Mario_Limonciello
2016-06-02 10:41 ` Michał Kępień
2016-06-07 22:06 ` Pali Rohár
2016-05-22 11:36 ` [PATCH 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events Pali Rohár
2016-05-23 17:07 ` Andy Lutomirski
2016-06-02 10:42 ` Michał Kępień
2016-06-07 22:30 ` Pali Rohár
2016-06-02 10:52 ` [PATCH 0/4] dell-wmi: Changes in WMI event code handling Michał Kępień
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68dd5c56440d4fc9a1c09c69a548476a@ausx13mpc124.AMER.DELL.COM \
--to=mario_limonciello@dell.com \
--cc=alex.hung@canonical.com \
--cc=dvhart@infradead.org \
--cc=gabriele.mzt@gmail.com \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.