* [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size()
@ 2016-05-25 12:30 Tobias Jakobi
2016-06-10 10:12 ` Tobias Jakobi
2016-06-10 10:54 ` Eric Engestrom
0 siblings, 2 replies; 6+ messages in thread
From: Tobias Jakobi @ 2016-05-25 12:30 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: Tobias Jakobi, dri-devel, m.szyprowski
The current bitwise AND should result in the same assembler
but this is what the code is actually supposed to do.
Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c
index b3f3c2c..e4a1a63 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_plane.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c
@@ -226,7 +226,7 @@ exynos_drm_plane_check_size(const struct exynos_drm_plane_config *config,
state->v_ratio == (1 << 15))
height_ok = true;
- if (width_ok & height_ok)
+ if (width_ok && height_ok)
return 0;
DRM_DEBUG_KMS("scaling mode is not supported");
--
2.7.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size()
2016-05-25 12:30 [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size() Tobias Jakobi
@ 2016-06-10 10:12 ` Tobias Jakobi
2016-06-13 1:34 ` Inki Dae
2016-06-10 10:54 ` Eric Engestrom
1 sibling, 1 reply; 6+ messages in thread
From: Tobias Jakobi @ 2016-06-10 10:12 UTC (permalink / raw)
To: Tobias Jakobi, linux-samsung-soc; +Cc: dri-devel, m.szyprowski
Ping!
- Tobias
Tobias Jakobi wrote:
> The current bitwise AND should result in the same assembler
> but this is what the code is actually supposed to do.
>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
> drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c
> index b3f3c2c..e4a1a63 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c
> @@ -226,7 +226,7 @@ exynos_drm_plane_check_size(const struct exynos_drm_plane_config *config,
> state->v_ratio == (1 << 15))
> height_ok = true;
>
> - if (width_ok & height_ok)
> + if (width_ok && height_ok)
> return 0;
>
> DRM_DEBUG_KMS("scaling mode is not supported");
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size()
2016-05-25 12:30 [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size() Tobias Jakobi
2016-06-10 10:12 ` Tobias Jakobi
@ 2016-06-10 10:54 ` Eric Engestrom
2016-06-10 14:11 ` Daniel Vetter
1 sibling, 1 reply; 6+ messages in thread
From: Eric Engestrom @ 2016-06-10 10:54 UTC (permalink / raw)
To: Tobias Jakobi; +Cc: linux-samsung-soc, dri-devel, m.szyprowski
On Wed, May 25, 2016 at 02:30:07PM +0200, Tobias Jakobi wrote:
> The current bitwise AND should result in the same assembler
> but this is what the code is actually supposed to do.
>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c
> index b3f3c2c..e4a1a63 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c
> @@ -226,7 +226,7 @@ exynos_drm_plane_check_size(const struct exynos_drm_plane_config *config,
> state->v_ratio == (1 << 15))
> height_ok = true;
>
> - if (width_ok & height_ok)
> + if (width_ok && height_ok)
> return 0;
>
> DRM_DEBUG_KMS("scaling mode is not supported");
> --
> 2.7.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size()
2016-06-10 10:54 ` Eric Engestrom
@ 2016-06-10 14:11 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2016-06-10 14:11 UTC (permalink / raw)
To: Eric Engestrom; +Cc: Tobias Jakobi, linux-samsung-soc, dri-devel, m.szyprowski
On Fri, Jun 10, 2016 at 11:54:50AM +0100, Eric Engestrom wrote:
> On Wed, May 25, 2016 at 02:30:07PM +0200, Tobias Jakobi wrote:
> > The current bitwise AND should result in the same assembler
> > but this is what the code is actually supposed to do.
> >
> > Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>
> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
Applied to drm-misc, thanks.
-Daniel
>
> > ---
> > drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c
> > index b3f3c2c..e4a1a63 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c
> > @@ -226,7 +226,7 @@ exynos_drm_plane_check_size(const struct exynos_drm_plane_config *config,
> > state->v_ratio == (1 << 15))
> > height_ok = true;
> >
> > - if (width_ok & height_ok)
> > + if (width_ok && height_ok)
> > return 0;
> >
> > DRM_DEBUG_KMS("scaling mode is not supported");
> > --
> > 2.7.3
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size()
2016-06-10 10:12 ` Tobias Jakobi
@ 2016-06-13 1:34 ` Inki Dae
2016-06-13 6:34 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Inki Dae @ 2016-06-13 1:34 UTC (permalink / raw)
To: Tobias Jakobi, linux-samsung-soc; +Cc: dri-devel, m.szyprowski
Picked it up.
Thanks,
Inki Dae
2016년 06월 10일 19:12에 Tobias Jakobi 이(가) 쓴 글:
> Ping!
>
> - Tobias
>
> Tobias Jakobi wrote:
>> The current bitwise AND should result in the same assembler
>> but this is what the code is actually supposed to do.
>>
>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c
>> index b3f3c2c..e4a1a63 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c
>> @@ -226,7 +226,7 @@ exynos_drm_plane_check_size(const struct exynos_drm_plane_config *config,
>> state->v_ratio == (1 << 15))
>> height_ok = true;
>>
>> - if (width_ok & height_ok)
>> + if (width_ok && height_ok)
>> return 0;
>>
>> DRM_DEBUG_KMS("scaling mode is not supported");
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size()
2016-06-13 1:34 ` Inki Dae
@ 2016-06-13 6:34 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2016-06-13 6:34 UTC (permalink / raw)
To: Inki Dae; +Cc: Tobias Jakobi, linux-samsung-soc, dri-devel, Marek Szyprowski
On Mon, Jun 13, 2016 at 3:34 AM, Inki Dae <inki.dae@samsung.com> wrote:
> Picked it up.
Fyi it's already in drm-misc too.
-Daniel
>
> Thanks,
> Inki Dae
>
> 2016년 06월 10일 19:12에 Tobias Jakobi 이(가) 쓴 글:
>> Ping!
>>
>> - Tobias
>>
>> Tobias Jakobi wrote:
>>> The current bitwise AND should result in the same assembler
>>> but this is what the code is actually supposed to do.
>>>
>>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>>> ---
>>> drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c
>>> index b3f3c2c..e4a1a63 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c
>>> @@ -226,7 +226,7 @@ exynos_drm_plane_check_size(const struct exynos_drm_plane_config *config,
>>> state->v_ratio == (1 << 15))
>>> height_ok = true;
>>>
>>> - if (width_ok & height_ok)
>>> + if (width_ok && height_ok)
>>> return 0;
>>>
>>> DRM_DEBUG_KMS("scaling mode is not supported");
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-13 6:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-25 12:30 [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size() Tobias Jakobi
2016-06-10 10:12 ` Tobias Jakobi
2016-06-13 1:34 ` Inki Dae
2016-06-13 6:34 ` Daniel Vetter
2016-06-10 10:54 ` Eric Engestrom
2016-06-10 14:11 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.