From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, Pavel Butsykin <pbutsykin@virtuozzo.com>,
Jeff Cody <jcody@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>, John Snow <jsnow@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 08/11] drive-backup: added support for data compression
Date: Mon, 13 Jun 2016 14:19:08 +0100 [thread overview]
Message-ID: <20160613131908.GO27781@stefanha-x1.localdomain> (raw)
In-Reply-To: <1464686130-12265-9-git-send-email-den@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]
On Tue, May 31, 2016 at 12:15:27PM +0300, Denis V. Lunev wrote:
> From: Pavel Butsykin <pbutsykin@virtuozzo.com>
>
> The idea is simple - backup is "written-once" data. It is written block
> by block and it is large enough. It would be nice to save storage
> space and compress it.
>
> The patch adds a flag to the qmp/hmp drive-backup command which enables
> block compression. Compression should be implemented in the format driver
> to enable this feature.
>
> There are some limitations of the format driver to allow compressed writes.
> We can write data only once. Though for backup this is perfectly fine.
> These limitations are maintained by the driver and the error will be
> reported if we are doing something wrong.
>
> Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Jeff Cody <jcody@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>
> CC: Eric Blake <eblake@redhat.com>
> CC: John Snow <jsnow@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> ---
> block/backup.c | 13 +++++++++++++
> blockdev.c | 12 ++++++++++--
> hmp-commands.hx | 8 +++++---
> hmp.c | 3 ++-
> include/block/block_int.h | 1 +
> qapi/block-core.json | 5 ++++-
> qmp-commands.hx | 5 ++++-
> 7 files changed, 39 insertions(+), 8 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-13 13:19 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 9:15 [Qemu-devel] [PATCH v4 00/11] backup compression Denis V. Lunev
2016-05-31 9:15 ` [Qemu-devel] [PATCH 01/11] block: switch blk_write_compressed() to byte-based interface Denis V. Lunev
2016-06-13 13:01 ` Stefan Hajnoczi
2016-06-13 14:23 ` Eric Blake
2016-06-22 12:25 ` Pavel Butsykin
2016-06-28 10:53 ` Kevin Wolf
2016-06-28 11:32 ` Pavel Butsykin
2016-05-31 9:15 ` [Qemu-devel] [PATCH 02/11] block/io: add bdrv_co_write_compressed Denis V. Lunev
2016-06-13 13:18 ` Stefan Hajnoczi
2016-06-13 14:32 ` Eric Blake
2016-06-22 12:26 ` Pavel Butsykin
2016-06-28 11:09 ` Kevin Wolf
2016-06-28 11:35 ` Pavel Butsykin
2016-05-31 9:15 ` [Qemu-devel] [PATCH 03/11] qcow2: add qcow2_co_write_compressed Denis V. Lunev
2016-06-13 13:18 ` Stefan Hajnoczi
2016-06-13 20:14 ` Eric Blake
2016-06-22 12:27 ` Pavel Butsykin
2016-06-28 11:17 ` Kevin Wolf
2016-06-28 11:30 ` Kevin Wolf
2016-06-28 15:06 ` Pavel Butsykin
2016-05-31 9:15 ` [Qemu-devel] [PATCH 04/11] vmdk: add vmdk_co_write_compressed Denis V. Lunev
2016-06-13 13:18 ` Stefan Hajnoczi
2016-05-31 9:15 ` [Qemu-devel] [PATCH 05/11] qcow: add qcow_co_write_compressed Denis V. Lunev
2016-06-13 13:18 ` Stefan Hajnoczi
2016-05-31 9:15 ` [Qemu-devel] [PATCH 06/11] block: remove BlockDriver.bdrv_write_compressed Denis V. Lunev
2016-06-13 13:19 ` Stefan Hajnoczi
2016-05-31 9:15 ` [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed() Denis V. Lunev
2016-06-13 13:11 ` Stefan Hajnoczi
2016-06-13 20:16 ` Eric Blake
2016-06-15 10:22 ` Stefan Hajnoczi
2016-06-24 15:42 ` Eric Blake
2016-06-28 11:47 ` Kevin Wolf
2016-06-28 12:32 ` Pavel Butsykin
2016-06-28 13:05 ` Kevin Wolf
2016-05-31 9:15 ` [Qemu-devel] [PATCH 08/11] drive-backup: added support for data compression Denis V. Lunev
2016-06-13 13:19 ` Stefan Hajnoczi [this message]
2016-06-13 20:18 ` Eric Blake
2016-06-23 9:15 ` Pavel Butsykin
2016-06-24 15:39 ` Eric Blake
2016-06-24 15:50 ` Pavel Butsykin
2016-05-31 9:15 ` [Qemu-devel] [PATCH 09/11] blockdev-backup: " Denis V. Lunev
2016-06-13 13:19 ` Stefan Hajnoczi
2016-06-13 20:19 ` Eric Blake
2016-05-31 9:15 ` [Qemu-devel] [PATCH 10/11] qemu-iotests: test backup compression in 055 Denis V. Lunev
2016-06-13 13:17 ` Stefan Hajnoczi
2016-05-31 9:15 ` [Qemu-devel] [PATCH 11/11] qemu-iotests: add vmdk for " Denis V. Lunev
2016-06-13 13:18 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613131908.GO27781@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbutsykin@virtuozzo.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.