From: Eric Blake <eblake@redhat.com>
To: Pavel Butsykin <pbutsykin@virtuozzo.com>,
"Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org
Cc: Jeff Cody <jcody@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
John Snow <jsnow@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 08/11] drive-backup: added support for data compression
Date: Fri, 24 Jun 2016 09:39:56 -0600 [thread overview]
Message-ID: <576D544C.9080804@redhat.com> (raw)
In-Reply-To: <576BA89E.3020501@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]
On 06/23/2016 03:15 AM, Pavel Butsykin wrote:
>>> @@ -3309,6 +3315,7 @@ void qmp_drive_backup(const char *device, const
>>> char *target,
>>> bool has_mode, enum NewImageMode mode,
>>> bool has_speed, int64_t speed,
>>> bool has_bitmap, const char *bitmap,
>>> + bool has_compress, bool compress,
>>> bool has_on_source_error, BlockdevOnError
>>> on_source_error,
>>> bool has_on_target_error, BlockdevOnError
>>> on_target_error,
>>> Error **errp)
>>
>> Might be nice to simplify this signature once my qapi 'box' patches land.
>>
>
> Yes, it would certainly be better. But your patches are not applied on
> the current, maybe you have your own branch?
http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi (still
undergoing rebases, and I need to address some of Markus' review
comments, but it's getting closer and still targetted for inclusion in 2.7)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-24 15:40 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 9:15 [Qemu-devel] [PATCH v4 00/11] backup compression Denis V. Lunev
2016-05-31 9:15 ` [Qemu-devel] [PATCH 01/11] block: switch blk_write_compressed() to byte-based interface Denis V. Lunev
2016-06-13 13:01 ` Stefan Hajnoczi
2016-06-13 14:23 ` Eric Blake
2016-06-22 12:25 ` Pavel Butsykin
2016-06-28 10:53 ` Kevin Wolf
2016-06-28 11:32 ` Pavel Butsykin
2016-05-31 9:15 ` [Qemu-devel] [PATCH 02/11] block/io: add bdrv_co_write_compressed Denis V. Lunev
2016-06-13 13:18 ` Stefan Hajnoczi
2016-06-13 14:32 ` Eric Blake
2016-06-22 12:26 ` Pavel Butsykin
2016-06-28 11:09 ` Kevin Wolf
2016-06-28 11:35 ` Pavel Butsykin
2016-05-31 9:15 ` [Qemu-devel] [PATCH 03/11] qcow2: add qcow2_co_write_compressed Denis V. Lunev
2016-06-13 13:18 ` Stefan Hajnoczi
2016-06-13 20:14 ` Eric Blake
2016-06-22 12:27 ` Pavel Butsykin
2016-06-28 11:17 ` Kevin Wolf
2016-06-28 11:30 ` Kevin Wolf
2016-06-28 15:06 ` Pavel Butsykin
2016-05-31 9:15 ` [Qemu-devel] [PATCH 04/11] vmdk: add vmdk_co_write_compressed Denis V. Lunev
2016-06-13 13:18 ` Stefan Hajnoczi
2016-05-31 9:15 ` [Qemu-devel] [PATCH 05/11] qcow: add qcow_co_write_compressed Denis V. Lunev
2016-06-13 13:18 ` Stefan Hajnoczi
2016-05-31 9:15 ` [Qemu-devel] [PATCH 06/11] block: remove BlockDriver.bdrv_write_compressed Denis V. Lunev
2016-06-13 13:19 ` Stefan Hajnoczi
2016-05-31 9:15 ` [Qemu-devel] [PATCH 07/11] block: optimization blk_pwrite_compressed() Denis V. Lunev
2016-06-13 13:11 ` Stefan Hajnoczi
2016-06-13 20:16 ` Eric Blake
2016-06-15 10:22 ` Stefan Hajnoczi
2016-06-24 15:42 ` Eric Blake
2016-06-28 11:47 ` Kevin Wolf
2016-06-28 12:32 ` Pavel Butsykin
2016-06-28 13:05 ` Kevin Wolf
2016-05-31 9:15 ` [Qemu-devel] [PATCH 08/11] drive-backup: added support for data compression Denis V. Lunev
2016-06-13 13:19 ` Stefan Hajnoczi
2016-06-13 20:18 ` Eric Blake
2016-06-23 9:15 ` Pavel Butsykin
2016-06-24 15:39 ` Eric Blake [this message]
2016-06-24 15:50 ` Pavel Butsykin
2016-05-31 9:15 ` [Qemu-devel] [PATCH 09/11] blockdev-backup: " Denis V. Lunev
2016-06-13 13:19 ` Stefan Hajnoczi
2016-06-13 20:19 ` Eric Blake
2016-05-31 9:15 ` [Qemu-devel] [PATCH 10/11] qemu-iotests: test backup compression in 055 Denis V. Lunev
2016-06-13 13:17 ` Stefan Hajnoczi
2016-05-31 9:15 ` [Qemu-devel] [PATCH 11/11] qemu-iotests: add vmdk for " Denis V. Lunev
2016-06-13 13:18 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576D544C.9080804@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbutsykin@virtuozzo.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.