* [PATCH v1 1/1] i2c-i801: make it depend on CONFIG_X86
@ 2016-06-15 13:22 Andy Shevchenko
2016-06-16 9:49 ` Jean Delvare
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2016-06-15 13:22 UTC (permalink / raw)
To: Wolfram Sang, Jean Delvare, linux-i2c; +Cc: Andy Shevchenko
The IP seems not used outside of x86 world, so, make it depend on CONFIG_X86.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/busses/Kconfig | 4 ++--
drivers/i2c/busses/i2c-i801.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index f167021..78609ad 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -89,8 +89,8 @@ config I2C_HIX5HD2
config I2C_I801
tristate "Intel 82801 (ICH/PCH)"
- depends on PCI
- select CHECK_SIGNATURE if X86 && DMI
+ depends on X86 && PCI
+ select CHECK_SIGNATURE if DMI
help
If you say yes to this option, support will be included for the Intel
801 family of mainboard I2C interfaces. Specifically, the following
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index b436963..9dcc417 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -902,7 +902,7 @@ static const struct pci_device_id i801_ids[] = {
MODULE_DEVICE_TABLE(pci, i801_ids);
-#if defined CONFIG_X86 && defined CONFIG_DMI
+#ifdef CONFIG_DMI
static unsigned char apanel_addr;
/* Scan the system ROM for the signature "FJKEYINF" */
@@ -1020,7 +1020,7 @@ static void i801_probe_optional_slaves(struct i801_priv *priv)
#else
static void __init input_apanel_init(void) {}
static void i801_probe_optional_slaves(struct i801_priv *priv) {}
-#endif /* CONFIG_X86 && CONFIG_DMI */
+#endif /* CONFIG_DMI */
#if (defined CONFIG_I2C_MUX_GPIO || defined CONFIG_I2C_MUX_GPIO_MODULE) && \
defined CONFIG_DMI
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] i2c-i801: make it depend on CONFIG_X86
2016-06-15 13:22 [PATCH v1 1/1] i2c-i801: make it depend on CONFIG_X86 Andy Shevchenko
@ 2016-06-16 9:49 ` Jean Delvare
2016-06-17 9:31 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2016-06-16 9:49 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Wolfram Sang, linux-i2c
Hi Andy,
On Wed, 15 Jun 2016 16:22:03 +0300, Andy Shevchenko wrote:
> The IP seems not used outside of x86 world, so, make it depend on CONFIG_X86.
I've seen the ICH10 used on at least one IA64 system (Supermicro I8QBH
mainboard.) So, nack, sorry. However I'd be OK with:
depends on X86 || IA64 || COMPILE_TEST
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/busses/Kconfig | 4 ++--
> drivers/i2c/busses/i2c-i801.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index f167021..78609ad 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -89,8 +89,8 @@ config I2C_HIX5HD2
>
> config I2C_I801
> tristate "Intel 82801 (ICH/PCH)"
> - depends on PCI
> - select CHECK_SIGNATURE if X86 && DMI
> + depends on X86 && PCI
> + select CHECK_SIGNATURE if DMI
> help
> If you say yes to this option, support will be included
> for the Intel 801 family of mainboard I2C interfaces. Specifically,
> the following diff --git a/drivers/i2c/busses/i2c-i801.c
> b/drivers/i2c/busses/i2c-i801.c index b436963..9dcc417 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -902,7 +902,7 @@ static const struct pci_device_id i801_ids[] = {
>
> MODULE_DEVICE_TABLE(pci, i801_ids);
>
> -#if defined CONFIG_X86 && defined CONFIG_DMI
> +#ifdef CONFIG_DMI
> static unsigned char apanel_addr;
>
> /* Scan the system ROM for the signature "FJKEYINF" */
> @@ -1020,7 +1020,7 @@ static void i801_probe_optional_slaves(struct
> i801_priv *priv) #else
> static void __init input_apanel_init(void) {}
> static void i801_probe_optional_slaves(struct i801_priv *priv) {}
> -#endif /* CONFIG_X86 && CONFIG_DMI */
> +#endif /* CONFIG_DMI */
>
> #if (defined CONFIG_I2C_MUX_GPIO || defined
> CONFIG_I2C_MUX_GPIO_MODULE) && \ defined CONFIG_DMI
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] i2c-i801: make it depend on CONFIG_X86
2016-06-16 9:49 ` Jean Delvare
@ 2016-06-17 9:31 ` Andy Shevchenko
2016-06-17 18:59 ` Jean Delvare
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2016-06-17 9:31 UTC (permalink / raw)
To: Jean Delvare; +Cc: Wolfram Sang, linux-i2c
On Thu, 2016-06-16 at 11:49 +0200, Jean Delvare wrote:
> Hi Andy,
>
> On Wed, 15 Jun 2016 16:22:03 +0300, Andy Shevchenko wrote:
> > The IP seems not used outside of x86 world, so, make it depend on
> > CONFIG_X86.
>
> I've seen the ICH10 used on at least one IA64 system (Supermicro I8QBH
> mainboard.) So, nack, sorry. However I'd be OK with:
>
> depends on X86 || IA64 || COMPILE_TEST
I don't like this. Anyway it's good to know that module is used
somewhere else. Thanks.
>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/i2c/busses/Kconfig | 4 ++--
> > drivers/i2c/busses/i2c-i801.c | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index f167021..78609ad 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -89,8 +89,8 @@ config I2C_HIX5HD2
> >
> > config I2C_I801
> > tristate "Intel 82801 (ICH/PCH)"
> > - depends on PCI
> > - select CHECK_SIGNATURE if X86 && DMI
> > + depends on X86 && PCI
> > + select CHECK_SIGNATURE if DMI
> > help
> > If you say yes to this option, support will be included
> > for the Intel 801 family of mainboard I2C interfaces. Specifically,
> > the following diff --git a/drivers/i2c/busses/i2c-i801.c
> > b/drivers/i2c/busses/i2c-i801.c index b436963..9dcc417 100644
> > --- a/drivers/i2c/busses/i2c-i801.c
> > +++ b/drivers/i2c/busses/i2c-i801.c
> > @@ -902,7 +902,7 @@ static const struct pci_device_id i801_ids[] = {
> >
> > MODULE_DEVICE_TABLE(pci, i801_ids);
> >
> > -#if defined CONFIG_X86 && defined CONFIG_DMI
> > +#ifdef CONFIG_DMI
> > static unsigned char apanel_addr;
> >
> > /* Scan the system ROM for the signature "FJKEYINF" */
> > @@ -1020,7 +1020,7 @@ static void i801_probe_optional_slaves(struct
> > i801_priv *priv) #else
> > static void __init input_apanel_init(void) {}
> > static void i801_probe_optional_slaves(struct i801_priv *priv) {}
> > -#endif /* CONFIG_X86 && CONFIG_DMI */
> > +#endif /* CONFIG_DMI */
> >
> > #if (defined CONFIG_I2C_MUX_GPIO || defined
> > CONFIG_I2C_MUX_GPIO_MODULE) && \ defined CONFIG_DMI
>
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] i2c-i801: make it depend on CONFIG_X86
2016-06-17 9:31 ` Andy Shevchenko
@ 2016-06-17 18:59 ` Jean Delvare
2016-06-17 19:05 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2016-06-17 18:59 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Wolfram Sang, linux-i2c
On Fri, 17 Jun 2016 12:31:35 +0300, Andy Shevchenko wrote:
> On Thu, 2016-06-16 at 11:49 +0200, Jean Delvare wrote:
> > Hi Andy,
> >
> > On Wed, 15 Jun 2016 16:22:03 +0300, Andy Shevchenko wrote:
> > > The IP seems not used outside of x86 world, so, make it depend on
> > > CONFIG_X86.
> >
> > I've seen the ICH10 used on at least one IA64 system (Supermicro I8QBH
> > mainboard.) So, nack, sorry. However I'd be OK with:
> >
> > depends on X86 || IA64 || COMPILE_TEST
>
> I don't like this. (...)
May I ask why?
> Anyway it's good to know that module is used
> somewhere else. Thanks.
>
> >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > drivers/i2c/busses/Kconfig | 4 ++--
> > > drivers/i2c/busses/i2c-i801.c | 4 ++--
> > > 2 files changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > > index f167021..78609ad 100644
> > > --- a/drivers/i2c/busses/Kconfig
> > > +++ b/drivers/i2c/busses/Kconfig
> > > @@ -89,8 +89,8 @@ config I2C_HIX5HD2
> > >
> > > config I2C_I801
> > > tristate "Intel 82801 (ICH/PCH)"
> > > - depends on PCI
> > > - select CHECK_SIGNATURE if X86 && DMI
> > > + depends on X86 && PCI
> > > + select CHECK_SIGNATURE if DMI
> > > help
> > > If you say yes to this option, support will be included
> > > for the Intel 801 family of mainboard I2C interfaces. Specifically,
> > > the following diff --git a/drivers/i2c/busses/i2c-i801.c
> > > b/drivers/i2c/busses/i2c-i801.c index b436963..9dcc417 100644
> > > --- a/drivers/i2c/busses/i2c-i801.c
> > > +++ b/drivers/i2c/busses/i2c-i801.c
> > > @@ -902,7 +902,7 @@ static const struct pci_device_id i801_ids[] = {
> > >
> > > MODULE_DEVICE_TABLE(pci, i801_ids);
> > >
> > > -#if defined CONFIG_X86 && defined CONFIG_DMI
> > > +#ifdef CONFIG_DMI
> > > static unsigned char apanel_addr;
> > >
> > > /* Scan the system ROM for the signature "FJKEYINF" */
> > > @@ -1020,7 +1020,7 @@ static void i801_probe_optional_slaves(struct
> > > i801_priv *priv) #else
> > > static void __init input_apanel_init(void) {}
> > > static void i801_probe_optional_slaves(struct i801_priv *priv) {}
> > > -#endif /* CONFIG_X86 && CONFIG_DMI */
> > > +#endif /* CONFIG_DMI */
> > >
> > > #if (defined CONFIG_I2C_MUX_GPIO || defined
> > > CONFIG_I2C_MUX_GPIO_MODULE) && \ defined CONFIG_DMI
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] i2c-i801: make it depend on CONFIG_X86
2016-06-17 18:59 ` Jean Delvare
@ 2016-06-17 19:05 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2016-06-17 19:05 UTC (permalink / raw)
To: Jean Delvare; +Cc: Wolfram Sang, linux-i2c
On Fri, 2016-06-17 at 20:59 +0200, Jean Delvare wrote:
> On Fri, 17 Jun 2016 12:31:35 +0300, Andy Shevchenko wrote:
> > On Thu, 2016-06-16 at 11:49 +0200, Jean Delvare wrote:
> > > depends on X86 || IA64 || COMPILE_TEST
> >
> > I don't like this. (...)
>
> May I ask why?
>From my point of view it's not scalable. If new arch comes you have to
add it here.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-17 19:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-15 13:22 [PATCH v1 1/1] i2c-i801: make it depend on CONFIG_X86 Andy Shevchenko
2016-06-16 9:49 ` Jean Delvare
2016-06-17 9:31 ` Andy Shevchenko
2016-06-17 18:59 ` Jean Delvare
2016-06-17 19:05 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.