All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Brown <broonie@linaro.org>, Mark Brown <broonie@kernel.org>,
	Laurent <laurent.pinchart@ideasonboard.com>,
	Guennadi <g.liakhovetski@gmx.de>,
	Grant Likely <grant.likely@linaro.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Linux-Kernel <linux-kernel@vger.kernel.org>,
	Linux-DT <devicetree@vger.kernel.org>,
	Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2 0/7] of_graph: prepare for ALSA graph support
Date: Mon, 4 Jul 2016 11:07:36 -0500	[thread overview]
Message-ID: <20160704160736.GA25708@rob-hp-laptop> (raw)
In-Reply-To: <87k2h8g7rr.wl%kuninori.morimoto.gx@renesas.com>

On Wed, Jun 29, 2016 at 12:33:15AM +0000, Kuninori Morimoto wrote:
> 
> Hi Rob
> 
> These are v2 of of_graph patch-set
> 
> Now OF graph is mainly used by V4L2 SoC, and ALSA SoC is using
> different style for SoC <-> Codec binding.
> But, for example, HDMI case, V4L2 <-> ALSA need to collaborate,
> and then ALSA SoC needs to adjust to OF graph.
> 
> OTOH, V4L2's "OF graph" position is same as ALSA SoC "sound card" position.
> And ALSA SoC side want to keep existing supported feature on new
> OF graph style. I'm posting this on ALSA SoC ML now.
> 
> Now, current of_graph is indicating port/endpoint,
> but there is no way to understand that it is for video port ? or sound port ?
> or other device port ?

I need to see how you want to use this. I'm not completely convinced 
this is necessary as the port number should be meaningful. For example, 
port 0 is video and port 1 is audio. This information is specific to the 
local parent node which could be problematic if you have generic code 
parsing the local node. However, if you know which local port is audio, 
then you know the remote endpoint's port is also the audio port. 

> For example, HDMI has video port, and sound port.
> Because of this reason, ALSA SoC side can't handle OF graph correctly.
> Thus, this patch-set tries to add new "type" on OF graph.
> 
> And this patch-set includes small feature which are useful for ALSA SoC
> side OF graph support.

In general, all these helpers look okay if you have a user for them.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Kuninori Morimoto
	<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Cc: Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Laurent
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	Guennadi <g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>,
	Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Frank Rowand
	<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Linux-Kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux-DT <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux-ALSA <alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>
Subject: Re: [PATCH v2 0/7] of_graph: prepare for ALSA graph support
Date: Mon, 4 Jul 2016 11:07:36 -0500	[thread overview]
Message-ID: <20160704160736.GA25708@rob-hp-laptop> (raw)
In-Reply-To: <87k2h8g7rr.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

On Wed, Jun 29, 2016 at 12:33:15AM +0000, Kuninori Morimoto wrote:
> 
> Hi Rob
> 
> These are v2 of of_graph patch-set
> 
> Now OF graph is mainly used by V4L2 SoC, and ALSA SoC is using
> different style for SoC <-> Codec binding.
> But, for example, HDMI case, V4L2 <-> ALSA need to collaborate,
> and then ALSA SoC needs to adjust to OF graph.
> 
> OTOH, V4L2's "OF graph" position is same as ALSA SoC "sound card" position.
> And ALSA SoC side want to keep existing supported feature on new
> OF graph style. I'm posting this on ALSA SoC ML now.
> 
> Now, current of_graph is indicating port/endpoint,
> but there is no way to understand that it is for video port ? or sound port ?
> or other device port ?

I need to see how you want to use this. I'm not completely convinced 
this is necessary as the port number should be meaningful. For example, 
port 0 is video and port 1 is audio. This information is specific to the 
local parent node which could be problematic if you have generic code 
parsing the local node. However, if you know which local port is audio, 
then you know the remote endpoint's port is also the audio port. 

> For example, HDMI has video port, and sound port.
> Because of this reason, ALSA SoC side can't handle OF graph correctly.
> Thus, this patch-set tries to add new "type" on OF graph.
> 
> And this patch-set includes small feature which are useful for ALSA SoC
> side OF graph support.

In general, all these helpers look okay if you have a user for them.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-07-04 16:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29  0:33 [PATCH v2 0/7] of_graph: prepare for ALSA graph support Kuninori Morimoto
2016-06-29  0:34 ` [PATCH v2 1/7] Documentation: of: add type property Kuninori Morimoto
2016-06-29  0:34   ` Kuninori Morimoto
2016-06-29  0:35 ` [PATCH v2 2/7] of_graph: add of_graph_get_remote_endpoint() Kuninori Morimoto
2016-06-29  0:35 ` [PATCH v2 3/7] of_graph: add of_graph_port_type_is() Kuninori Morimoto
2016-06-29  0:35 ` [PATCH v2 4/7] of_graph: add of_graph_get_port_parent() Kuninori Morimoto
2016-06-29  0:36 ` [PATCH v2 5/7] of_graph: add of_graph_get_top_port() Kuninori Morimoto
2016-06-29  0:36 ` [PATCH v2 6/7] of_graph: add for_each_of_port() / for_each_of_endpoint_in_port() Kuninori Morimoto
2016-06-29  0:36   ` Kuninori Morimoto
2016-06-29  0:37 ` [PATCH v2 7/7] of_graph: add of_graph_get_endpoint_count() Kuninori Morimoto
2016-06-29  0:37   ` Kuninori Morimoto
2016-06-29  0:39 ` [PATCH v2 0/7] of_graph: prepare for ALSA graph support Mark Brown
2016-06-29  0:39   ` Mark Brown
2016-06-29  1:09   ` Kuninori Morimoto
2016-06-29  1:09     ` Kuninori Morimoto
2016-07-04 16:07 ` Rob Herring [this message]
2016-07-04 16:07   ` Rob Herring
2016-07-04 23:41   ` Kuninori Morimoto
2016-07-04 23:41     ` Kuninori Morimoto
2016-07-05  6:24     ` Kuninori Morimoto
2016-07-05  6:24       ` Kuninori Morimoto
2016-07-05 16:38       ` Rob Herring
2016-07-05 16:49     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704160736.GA25708@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=broonie@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=grant.likely@linaro.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.