All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Rob Herring <robh@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: Laurent <laurent.pinchart@ideasonboard.com>,
	Guennadi <g.liakhovetski@gmx.de>,
	Grant Likely <grant.likely@linaro.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Linux-Kernel <linux-kernel@vger.kernel.org>,
	Linux-DT <devicetree@vger.kernel.org>,
	Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2 0/7] of_graph: prepare for ALSA graph support
Date: Mon, 4 Jul 2016 23:41:48 +0000	[thread overview]
Message-ID: <87wpl13rlf.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20160704160736.GA25708@rob-hp-laptop>


Hi Rob, Mark

Thank you for your feedback

> I need to see how you want to use this. I'm not completely convinced 
> this is necessary as the port number should be meaningful. For example, 
> port 0 is video and port 1 is audio. This information is specific to the 
> local parent node which could be problematic if you have generic code 
> parsing the local node. However, if you know which local port is audio, 
> then you know the remote endpoint's port is also the audio port. 

Yes, as you pointed, sound side (= ALSA SoC) will use generic driver
for sound card which needs to know its total port number.
Then, these patches are needed.

I posted OF graph part only this time, but of course I have total full-set
in my local environment.
But these are ...
 1) cleanup current generic sound driver (= almost 30 patch)
 2) OF graph new feature (= this patch-set) (= almost 10 patch)
 3) OF graph base generic sound driver (= almost 30 patch)
 - ...

I'm posting 1) part to ALSA SoC ML, 2) part to this ML.
1) will take more long term >> Mark ??
If you want to see this patch-set together with use case, then 3) is needed.
If so, I will merge 2) and 3), and post these to this ML and ALSA SoC ML.

Is it OK for you ? >> Rob, Mark
I don't know how to handle it, but I can follow your opinion

> In general, all these helpers look okay if you have a user for them.

Thanks.
As I explained above, it is based on 1) part, but it will takes more
long term.

WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Laurent
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	Guennadi <g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>,
	Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Frank Rowand
	<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Linux-Kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux-DT <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux-ALSA <alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>
Subject: Re: [PATCH v2 0/7] of_graph: prepare for ALSA graph support
Date: Mon, 4 Jul 2016 23:41:48 +0000	[thread overview]
Message-ID: <87wpl13rlf.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20160704160736.GA25708@rob-hp-laptop>


Hi Rob, Mark

Thank you for your feedback

> I need to see how you want to use this. I'm not completely convinced 
> this is necessary as the port number should be meaningful. For example, 
> port 0 is video and port 1 is audio. This information is specific to the 
> local parent node which could be problematic if you have generic code 
> parsing the local node. However, if you know which local port is audio, 
> then you know the remote endpoint's port is also the audio port. 

Yes, as you pointed, sound side (= ALSA SoC) will use generic driver
for sound card which needs to know its total port number.
Then, these patches are needed.

I posted OF graph part only this time, but of course I have total full-set
in my local environment.
But these are ...
 1) cleanup current generic sound driver (= almost 30 patch)
 2) OF graph new feature (= this patch-set) (= almost 10 patch)
 3) OF graph base generic sound driver (= almost 30 patch)
 - ...

I'm posting 1) part to ALSA SoC ML, 2) part to this ML.
1) will take more long term >> Mark ??
If you want to see this patch-set together with use case, then 3) is needed.
If so, I will merge 2) and 3), and post these to this ML and ALSA SoC ML.

Is it OK for you ? >> Rob, Mark
I don't know how to handle it, but I can follow your opinion

> In general, all these helpers look okay if you have a user for them.

Thanks.
As I explained above, it is based on 1) part, but it will takes more
long term.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-07-04 23:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29  0:33 [PATCH v2 0/7] of_graph: prepare for ALSA graph support Kuninori Morimoto
2016-06-29  0:34 ` [PATCH v2 1/7] Documentation: of: add type property Kuninori Morimoto
2016-06-29  0:34   ` Kuninori Morimoto
2016-06-29  0:35 ` [PATCH v2 2/7] of_graph: add of_graph_get_remote_endpoint() Kuninori Morimoto
2016-06-29  0:35 ` [PATCH v2 3/7] of_graph: add of_graph_port_type_is() Kuninori Morimoto
2016-06-29  0:35 ` [PATCH v2 4/7] of_graph: add of_graph_get_port_parent() Kuninori Morimoto
2016-06-29  0:36 ` [PATCH v2 5/7] of_graph: add of_graph_get_top_port() Kuninori Morimoto
2016-06-29  0:36 ` [PATCH v2 6/7] of_graph: add for_each_of_port() / for_each_of_endpoint_in_port() Kuninori Morimoto
2016-06-29  0:36   ` Kuninori Morimoto
2016-06-29  0:37 ` [PATCH v2 7/7] of_graph: add of_graph_get_endpoint_count() Kuninori Morimoto
2016-06-29  0:37   ` Kuninori Morimoto
2016-06-29  0:39 ` [PATCH v2 0/7] of_graph: prepare for ALSA graph support Mark Brown
2016-06-29  0:39   ` Mark Brown
2016-06-29  1:09   ` Kuninori Morimoto
2016-06-29  1:09     ` Kuninori Morimoto
2016-07-04 16:07 ` Rob Herring
2016-07-04 16:07   ` Rob Herring
2016-07-04 23:41   ` Kuninori Morimoto [this message]
2016-07-04 23:41     ` Kuninori Morimoto
2016-07-05  6:24     ` Kuninori Morimoto
2016-07-05  6:24       ` Kuninori Morimoto
2016-07-05 16:38       ` Rob Herring
2016-07-05 16:49     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpl13rlf.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=grant.likely@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.