* [PATCH] dwc_eth_qos: Remove deprecated create_singlethread_workqueue
@ 2016-07-16 8:23 ` Bhaktipriya Shridhar
0 siblings, 0 replies; 3+ messages in thread
From: Bhaktipriya Shridhar @ 2016-07-16 8:23 UTC (permalink / raw)
To: Lars Persson; +Cc: netdev, linux-kernel, Tejun Heo
alloc_workqueue replaces deprecated create_singlethread_workqueue().
A dedicated workqueue has been used since the workitem viz
lp->txtimeout_reinit is involved in reinitialization if a TX timeout
occurs, which is necessary to guarantee forward progress in packet
processing. As a network device can be used during memory reclaim, the
workqueue needs forward progress guarantee under memory pressure.
WQ_MEM_RECLAIM has been set to ensure this.
Since there is only a single work item, explicit concurrency limit is
unnecessary here.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
index 158213c..44c4cd6 100644
--- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c
+++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
@@ -2934,7 +2934,8 @@ static int dwceqos_probe(struct platform_device *pdev)
(unsigned long)ndev);
tasklet_disable(&lp->tx_bdreclaim_tasklet);
- lp->txtimeout_handler_wq = create_singlethread_workqueue(DRIVER_NAME);
+ lp->txtimeout_handler_wq = alloc_workqueue(DRIVER_NAME,
+ WQ_MEM_RECLAIM, 0);
INIT_WORK(&lp->txtimeout_reinit, dwceqos_reinit_for_txtimeout);
platform_set_drvdata(pdev, ndev);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] dwc_eth_qos: Remove deprecated create_singlethread_workqueue
@ 2016-07-16 8:23 ` Bhaktipriya Shridhar
0 siblings, 0 replies; 3+ messages in thread
From: Bhaktipriya Shridhar @ 2016-07-16 8:23 UTC (permalink / raw)
To: Lars Persson; +Cc: netdev, linux-kernel, Tejun Heo
alloc_workqueue replaces deprecated create_singlethread_workqueue().
A dedicated workqueue has been used since the workitem viz
lp->txtimeout_reinit is involved in reinitialization if a TX timeout
occurs, which is necessary to guarantee forward progress in packet
processing. As a network device can be used during memory reclaim, the
workqueue needs forward progress guarantee under memory pressure.
WQ_MEM_RECLAIM has been set to ensure this.
Since there is only a single work item, explicit concurrency limit is
unnecessary here.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
index 158213c..44c4cd6 100644
--- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c
+++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c
@@ -2934,7 +2934,8 @@ static int dwceqos_probe(struct platform_device *pdev)
(unsigned long)ndev);
tasklet_disable(&lp->tx_bdreclaim_tasklet);
- lp->txtimeout_handler_wq = create_singlethread_workqueue(DRIVER_NAME);
+ lp->txtimeout_handler_wq = alloc_workqueue(DRIVER_NAME,
+ WQ_MEM_RECLAIM, 0);
INIT_WORK(&lp->txtimeout_reinit, dwceqos_reinit_for_txtimeout);
platform_set_drvdata(pdev, ndev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dwc_eth_qos: Remove deprecated create_singlethread_workqueue
2016-07-16 8:23 ` Bhaktipriya Shridhar
(?)
@ 2016-07-18 5:27 ` David Miller
-1 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2016-07-18 5:27 UTC (permalink / raw)
To: bhaktipriya96; +Cc: lars.persson, netdev, linux-kernel, tj
From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date: Sat, 16 Jul 2016 13:53:28 +0530
> alloc_workqueue replaces deprecated create_singlethread_workqueue().
>
> A dedicated workqueue has been used since the workitem viz
> lp->txtimeout_reinit is involved in reinitialization if a TX timeout
> occurs, which is necessary to guarantee forward progress in packet
> processing. As a network device can be used during memory reclaim, the
> workqueue needs forward progress guarantee under memory pressure.
> WQ_MEM_RECLAIM has been set to ensure this.
>
> Since there is only a single work item, explicit concurrency limit is
> unnecessary here.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-18 5:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-16 8:23 [PATCH] dwc_eth_qos: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-07-16 8:23 ` Bhaktipriya Shridhar
2016-07-18 5:27 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.