[PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers

[PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers

[Sergei Shtylyov]

Hello.

   Here's a set of 2 patches against DaveM's 'net.git' repo fixing up the DMA
channel reporting by 'ifconfig'...

[1/2] ravb: fix DMA channel misreporting
[2/2] sh_eth: fix DMA channel misreporting

MBR, Sergei

[PATCH 1/2] ravb: fix DMA channel misreporting

[Sergei Shtylyov]

Currently 'ifconfig' for the Ethernet devices handled by this driver  shows
"DMA chan: ff" while the driver doesn't use any DMA channels. Not assigning
a value to 'net_device::dma' causes 'ifconfig'  to  correctly not report  a
DMA channel.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 drivers/net/ethernet/renesas/ravb_main.c |    1 -
 1 file changed, 1 deletion(-)

Index: net/drivers/net/ethernet/renesas/ravb_main.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/ravb_main.c
+++ net/drivers/net/ethernet/renesas/ravb_main.c
@@ -1909,7 +1909,6 @@ static int ravb_probe(struct platform_de
 
 	/* The Ether-specific entries in the device structure. */
 	ndev->base_addr = res->start;
-	ndev->dma = -1;
 
 	chip_id = (enum ravb_chip_id)of_device_get_match_data(&pdev->dev);
 

[PATCH 2/2] sh_eth: fix DMA channel misreporting

[Sergei Shtylyov]

Currently 'ifconfig' for the Ethernet devices handled by this driver  shows
"DMA chan: ff" while the driver doesn't use any DMA channels. Not assigning
a value to 'net_device::dma' causes 'ifconfig'  to  correctly not report  a
DMA channel.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 drivers/net/ethernet/renesas/sh_eth.c |    1 -
 1 file changed, 1 deletion(-)

Index: net/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net/drivers/net/ethernet/renesas/sh_eth.c
@@ -2996,7 +2996,6 @@ static int sh_eth_drv_probe(struct platf
 	if (devno < 0)
 		devno = 0;
 
-	ndev->dma = -1;
 	ret = platform_get_irq(pdev, 0);
 	if (ret < 0)
 		goto out_release;

Re: [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers

[David Miller]

From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Sun, 17 Jul 2016 16:06:24 +0300

>    Here's a set of 2 patches against DaveM's 'net.git' repo fixing
> up the DMA channel reporting by 'ifconfig'...

Is some fixing some ifconfig output that is effectively meaningless
appropriate for 'net'?  Sounds like 'net-next' material to me.

Re: [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers

[Sergei Shtylyov]

Hello.

On 07/18/2016 09:24 AM, David Miller wrote:

>>    Here's a set of 2 patches against DaveM's 'net.git' repo fixing
>> up the DMA channel reporting by 'ifconfig'...
>
> Is some fixing some ifconfig output that is effectively meaningless
> appropriate for 'net'?

    I just don't know any more users of SIOCGIFMAP ioctl... ip?
    It seems to  also be used in net/core/rtnetlink.c...

> Sounds like 'net-next' material to me.

    Up to you, of course.

MBR, Sergei

Re: [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers

[David Miller]

From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Mon, 18 Jul 2016 17:13:02 +0300

> Hello.
> 
> On 07/18/2016 09:24 AM, David Miller wrote:
> 
>>>    Here's a set of 2 patches against DaveM's 'net.git' repo fixing
>>> up the DMA channel reporting by 'ifconfig'...
>>
>> Is some fixing some ifconfig output that is effectively meaningless
>> appropriate for 'net'?
> 
>    I just don't know any more users of SIOCGIFMAP ioctl... ip?
>    It seems to  also be used in net/core/rtnetlink.c...

Who cares who uses it.  The important thing to ask is what in the
world could they do with the value?

DMA masks have no meaning or usage since ISA times.

Re: [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers

[David Miller]

From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Sun, 17 Jul 2016 16:06:24 +0300

>    Here's a set of 2 patches against DaveM's 'net.git' repo fixing
> up the DMA channel reporting by 'ifconfig'...

Seires applied to net-next.