* [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers
@ 2016-07-17 13:06 Sergei Shtylyov
2016-07-17 13:08 ` [PATCH 1/2] ravb: fix DMA channel misreporting Sergei Shtylyov
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2016-07-17 13:06 UTC (permalink / raw)
To: netdev; +Cc: linux-renesas-soc
Hello.
Here's a set of 2 patches against DaveM's 'net.git' repo fixing up the DMA
channel reporting by 'ifconfig'...
[1/2] ravb: fix DMA channel misreporting
[2/2] sh_eth: fix DMA channel misreporting
MBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] ravb: fix DMA channel misreporting
2016-07-17 13:06 [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers Sergei Shtylyov
@ 2016-07-17 13:08 ` Sergei Shtylyov
2016-07-17 13:09 ` [PATCH 2/2] sh_eth: " Sergei Shtylyov
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2016-07-17 13:08 UTC (permalink / raw)
To: netdev; +Cc: linux-renesas-soc
Currently 'ifconfig' for the Ethernet devices handled by this driver shows
"DMA chan: ff" while the driver doesn't use any DMA channels. Not assigning
a value to 'net_device::dma' causes 'ifconfig' to correctly not report a
DMA channel.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/renesas/ravb_main.c | 1 -
1 file changed, 1 deletion(-)
Index: net/drivers/net/ethernet/renesas/ravb_main.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/ravb_main.c
+++ net/drivers/net/ethernet/renesas/ravb_main.c
@@ -1909,7 +1909,6 @@ static int ravb_probe(struct platform_de
/* The Ether-specific entries in the device structure. */
ndev->base_addr = res->start;
- ndev->dma = -1;
chip_id = (enum ravb_chip_id)of_device_get_match_data(&pdev->dev);
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 2/2] sh_eth: fix DMA channel misreporting
2016-07-17 13:06 [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers Sergei Shtylyov
2016-07-17 13:08 ` [PATCH 1/2] ravb: fix DMA channel misreporting Sergei Shtylyov
@ 2016-07-17 13:09 ` Sergei Shtylyov
2016-07-18 6:24 ` [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers David Miller
2016-07-19 23:01 ` David Miller
3 siblings, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2016-07-17 13:09 UTC (permalink / raw)
To: netdev; +Cc: linux-renesas-soc
Currently 'ifconfig' for the Ethernet devices handled by this driver shows
"DMA chan: ff" while the driver doesn't use any DMA channels. Not assigning
a value to 'net_device::dma' causes 'ifconfig' to correctly not report a
DMA channel.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/renesas/sh_eth.c | 1 -
1 file changed, 1 deletion(-)
Index: net/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net/drivers/net/ethernet/renesas/sh_eth.c
@@ -2996,7 +2996,6 @@ static int sh_eth_drv_probe(struct platf
if (devno < 0)
devno = 0;
- ndev->dma = -1;
ret = platform_get_irq(pdev, 0);
if (ret < 0)
goto out_release;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers
2016-07-17 13:06 [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers Sergei Shtylyov
2016-07-17 13:08 ` [PATCH 1/2] ravb: fix DMA channel misreporting Sergei Shtylyov
2016-07-17 13:09 ` [PATCH 2/2] sh_eth: " Sergei Shtylyov
@ 2016-07-18 6:24 ` David Miller
2016-07-18 14:13 ` Sergei Shtylyov
2016-07-19 23:01 ` David Miller
3 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2016-07-18 6:24 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, linux-renesas-soc
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Sun, 17 Jul 2016 16:06:24 +0300
> Here's a set of 2 patches against DaveM's 'net.git' repo fixing
> up the DMA channel reporting by 'ifconfig'...
Is some fixing some ifconfig output that is effectively meaningless
appropriate for 'net'? Sounds like 'net-next' material to me.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers
2016-07-18 6:24 ` [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers David Miller
@ 2016-07-18 14:13 ` Sergei Shtylyov
2016-07-18 19:57 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2016-07-18 14:13 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-renesas-soc
Hello.
On 07/18/2016 09:24 AM, David Miller wrote:
>> Here's a set of 2 patches against DaveM's 'net.git' repo fixing
>> up the DMA channel reporting by 'ifconfig'...
>
> Is some fixing some ifconfig output that is effectively meaningless
> appropriate for 'net'?
I just don't know any more users of SIOCGIFMAP ioctl... ip?
It seems to also be used in net/core/rtnetlink.c...
> Sounds like 'net-next' material to me.
Up to you, of course.
MBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers
2016-07-18 14:13 ` Sergei Shtylyov
@ 2016-07-18 19:57 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2016-07-18 19:57 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, linux-renesas-soc
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Mon, 18 Jul 2016 17:13:02 +0300
> Hello.
>
> On 07/18/2016 09:24 AM, David Miller wrote:
>
>>> Here's a set of 2 patches against DaveM's 'net.git' repo fixing
>>> up the DMA channel reporting by 'ifconfig'...
>>
>> Is some fixing some ifconfig output that is effectively meaningless
>> appropriate for 'net'?
>
> I just don't know any more users of SIOCGIFMAP ioctl... ip?
> It seems to also be used in net/core/rtnetlink.c...
Who cares who uses it. The important thing to ask is what in the
world could they do with the value?
DMA masks have no meaning or usage since ISA times.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers
2016-07-17 13:06 [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers Sergei Shtylyov
` (2 preceding siblings ...)
2016-07-18 6:24 ` [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers David Miller
@ 2016-07-19 23:01 ` David Miller
3 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2016-07-19 23:01 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, linux-renesas-soc
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Sun, 17 Jul 2016 16:06:24 +0300
> Here's a set of 2 patches against DaveM's 'net.git' repo fixing
> up the DMA channel reporting by 'ifconfig'...
Seires applied to net-next.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-07-19 23:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-17 13:06 [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers Sergei Shtylyov
2016-07-17 13:08 ` [PATCH 1/2] ravb: fix DMA channel misreporting Sergei Shtylyov
2016-07-17 13:09 ` [PATCH 2/2] sh_eth: " Sergei Shtylyov
2016-07-18 6:24 ` [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers David Miller
2016-07-18 14:13 ` Sergei Shtylyov
2016-07-18 19:57 ` David Miller
2016-07-19 23:01 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.