From: Joonsoo Kim <iamjoonsoo.kim@lge.com> To: Xishi Qiu <qiuxishi@huawei.com> Cc: Vlastimil Babka <vbabka@suse.cz>, David Rientjes <rientjes@google.com>, Andrew Morton <akpm@linux-foundation.org>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target() Date: Tue, 19 Jul 2016 15:50:42 +0900 [thread overview] Message-ID: <20160719065042.GC17479@js1304-P5Q-DELUXE> (raw) In-Reply-To: <578C93CF.50509@huawei.com> On Mon, Jul 18, 2016 at 04:31:11PM +0800, Xishi Qiu wrote: > On 2016/7/18 16:05, Vlastimil Babka wrote: > > > On 07/18/2016 10:00 AM, Xishi Qiu wrote: > >> On 2016/7/18 13:51, Joonsoo Kim wrote: > >> > >>> On Fri, Jul 15, 2016 at 10:47:06AM +0800, Xishi Qiu wrote: > >>>> alloc_migrate_target() is called from migrate_pages(), and the page > >>>> is always from user space, so we can add __GFP_HIGHMEM directly. > >>> > >>> No, all migratable pages are not from user space. For example, > >>> blockdev file cache has __GFP_MOVABLE and migratable but it has no > >>> __GFP_HIGHMEM and __GFP_USER. > >>> > >> > >> Hi Joonsoo, > >> > >> So the original code "gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE;" > >> is not correct? > > > > It's not incorrect. GFP_USER just specifies some reclaim flags, and may perhaps restrict allocation through __GFP_HARDWALL, where the original > > page could have been allocated without the restriction. But it doesn't put the place in an unexpected address range, as placing a non-highmem page into highmem could. __GFP_MOVABLE then just controls a heuristic for placement within a zone. > > > >>> And, zram's memory isn't GFP_HIGHUSER_MOVABLE but has __GFP_MOVABLE. > >>> > >> > >> Can we distinguish __GFP_MOVABLE or GFP_HIGHUSER_MOVABLE when doing > >> mem-hotplug? > > > > I don't understand the question here, can you rephrase with more detail? Thanks. > > > > Hi Joonsoo, Above is answered by Vlastimil. :) > When we do memory offline, and the zone is movable zone, > can we use "alloc_pages_node(nid, GFP_HIGHUSER_MOVABLE, 0);" to alloc a > new page? the nid is the next node. I don't know much about memory offline, but, AFAIK, memory offline could happen on non-movable zone like as ZONE_NORMAL. Perhaps, you can add "if zone of the page is movable zone then alloc with GFP_HIGHUSER_MOVABLE". Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joonsoo Kim <iamjoonsoo.kim@lge.com> To: Xishi Qiu <qiuxishi@huawei.com> Cc: Vlastimil Babka <vbabka@suse.cz>, David Rientjes <rientjes@google.com>, Andrew Morton <akpm@linux-foundation.org>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target() Date: Tue, 19 Jul 2016 15:50:42 +0900 [thread overview] Message-ID: <20160719065042.GC17479@js1304-P5Q-DELUXE> (raw) In-Reply-To: <578C93CF.50509@huawei.com> On Mon, Jul 18, 2016 at 04:31:11PM +0800, Xishi Qiu wrote: > On 2016/7/18 16:05, Vlastimil Babka wrote: > > > On 07/18/2016 10:00 AM, Xishi Qiu wrote: > >> On 2016/7/18 13:51, Joonsoo Kim wrote: > >> > >>> On Fri, Jul 15, 2016 at 10:47:06AM +0800, Xishi Qiu wrote: > >>>> alloc_migrate_target() is called from migrate_pages(), and the page > >>>> is always from user space, so we can add __GFP_HIGHMEM directly. > >>> > >>> No, all migratable pages are not from user space. For example, > >>> blockdev file cache has __GFP_MOVABLE and migratable but it has no > >>> __GFP_HIGHMEM and __GFP_USER. > >>> > >> > >> Hi Joonsoo, > >> > >> So the original code "gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE;" > >> is not correct? > > > > It's not incorrect. GFP_USER just specifies some reclaim flags, and may perhaps restrict allocation through __GFP_HARDWALL, where the original > > page could have been allocated without the restriction. But it doesn't put the place in an unexpected address range, as placing a non-highmem page into highmem could. __GFP_MOVABLE then just controls a heuristic for placement within a zone. > > > >>> And, zram's memory isn't GFP_HIGHUSER_MOVABLE but has __GFP_MOVABLE. > >>> > >> > >> Can we distinguish __GFP_MOVABLE or GFP_HIGHUSER_MOVABLE when doing > >> mem-hotplug? > > > > I don't understand the question here, can you rephrase with more detail? Thanks. > > > > Hi Joonsoo, Above is answered by Vlastimil. :) > When we do memory offline, and the zone is movable zone, > can we use "alloc_pages_node(nid, GFP_HIGHUSER_MOVABLE, 0);" to alloc a > new page? the nid is the next node. I don't know much about memory offline, but, AFAIK, memory offline could happen on non-movable zone like as ZONE_NORMAL. Perhaps, you can add "if zone of the page is movable zone then alloc with GFP_HIGHUSER_MOVABLE". Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-19 6:46 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-15 2:47 [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target() Xishi Qiu 2016-07-15 2:47 ` Xishi Qiu 2016-07-15 2:51 ` [PATCH 2/2] mem-hotplug: use different mempolicy in alloc_migrate_target() Xishi Qiu 2016-07-15 2:51 ` Xishi Qiu 2016-07-18 8:00 ` Vlastimil Babka 2016-07-18 8:00 ` Vlastimil Babka 2016-07-18 5:51 ` [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target() Joonsoo Kim 2016-07-18 5:51 ` Joonsoo Kim 2016-07-18 7:45 ` Vlastimil Babka 2016-07-18 7:45 ` Vlastimil Babka 2016-07-18 8:00 ` Xishi Qiu 2016-07-18 8:00 ` Xishi Qiu 2016-07-18 8:05 ` Vlastimil Babka 2016-07-18 8:05 ` Vlastimil Babka 2016-07-18 8:31 ` Xishi Qiu 2016-07-18 8:31 ` Xishi Qiu 2016-07-19 6:50 ` Joonsoo Kim [this message] 2016-07-19 6:50 ` Joonsoo Kim 2016-07-19 7:18 ` Xishi Qiu 2016-07-19 7:18 ` Xishi Qiu 2016-07-19 19:05 ` David Rientjes 2016-07-19 19:05 ` David Rientjes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160719065042.GC17479@js1304-P5Q-DELUXE \ --to=iamjoonsoo.kim@lge.com \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=n-horiguchi@ah.jp.nec.com \ --cc=qiuxishi@huawei.com \ --cc=rientjes@google.com \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.