All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target()
Date: Tue, 19 Jul 2016 12:05:13 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1607191204320.52203@chino.kir.corp.google.com> (raw)
In-Reply-To: <578DD44F.3040507@huawei.com>

On Tue, 19 Jul 2016, Xishi Qiu wrote:

> Memory offline could happen on both movable zone and non-movable zone, and we
> can offline the whole node if the zone is movable_zone(the node only has one
> movable_zone), and if the zone is normal_zone, we cannot offline the whole node,
> because some kernel memory can't be migrated.
> 
> So how about change alloc_migrate_target() to alloc memory from the next node
> with GFP_HIGHUSER_MOVABLE, if the offline zone is movable_zone.
> 

I think sharing alloc_migrate_target as a migration callback may not be 
worth it; CMA and memory offline are distinct usecases and probably 
deserve their own callbacks.

WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target()
Date: Tue, 19 Jul 2016 12:05:13 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1607191204320.52203@chino.kir.corp.google.com> (raw)
In-Reply-To: <578DD44F.3040507@huawei.com>

On Tue, 19 Jul 2016, Xishi Qiu wrote:

> Memory offline could happen on both movable zone and non-movable zone, and we
> can offline the whole node if the zone is movable_zone(the node only has one
> movable_zone), and if the zone is normal_zone, we cannot offline the whole node,
> because some kernel memory can't be migrated.
> 
> So how about change alloc_migrate_target() to alloc memory from the next node
> with GFP_HIGHUSER_MOVABLE, if the offline zone is movable_zone.
> 

I think sharing alloc_migrate_target as a migration callback may not be 
worth it; CMA and memory offline are distinct usecases and probably 
deserve their own callbacks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-07-19 19:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  2:47 [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target() Xishi Qiu
2016-07-15  2:47 ` Xishi Qiu
2016-07-15  2:51 ` [PATCH 2/2] mem-hotplug: use different mempolicy in alloc_migrate_target() Xishi Qiu
2016-07-15  2:51   ` Xishi Qiu
2016-07-18  8:00   ` Vlastimil Babka
2016-07-18  8:00     ` Vlastimil Babka
2016-07-18  5:51 ` [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target() Joonsoo Kim
2016-07-18  5:51   ` Joonsoo Kim
2016-07-18  7:45   ` Vlastimil Babka
2016-07-18  7:45     ` Vlastimil Babka
2016-07-18  8:00   ` Xishi Qiu
2016-07-18  8:00     ` Xishi Qiu
2016-07-18  8:05     ` Vlastimil Babka
2016-07-18  8:05       ` Vlastimil Babka
2016-07-18  8:31       ` Xishi Qiu
2016-07-18  8:31         ` Xishi Qiu
2016-07-19  6:50         ` Joonsoo Kim
2016-07-19  6:50           ` Joonsoo Kim
2016-07-19  7:18           ` Xishi Qiu
2016-07-19  7:18             ` Xishi Qiu
2016-07-19 19:05             ` David Rientjes [this message]
2016-07-19 19:05               ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1607191204320.52203@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=qiuxishi@huawei.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.