From: Johannes Weiner <hannes@cmpxchg.org> To: Mel Gorman <mgorman@techsingularity.net> Cc: Andrew Morton <akpm@linux-foundation.org>, Minchan Kim <minchan@kernel.org>, Michal Hocko <mhocko@suse.cz>, Vlastimil Babka <vbabka@suse.cz>, Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 4/5] mm: consider per-zone inactive ratio to deactivate Date: Thu, 21 Jul 2016 11:52:59 -0400 [thread overview] Message-ID: <20160721155259.GB30303@cmpxchg.org> (raw) In-Reply-To: <1469110261-7365-5-git-send-email-mgorman@techsingularity.net> On Thu, Jul 21, 2016 at 03:11:00PM +0100, Mel Gorman wrote: > @@ -1981,6 +1982,32 @@ static bool inactive_list_is_low(struct lruvec *lruvec, bool file) > inactive = lruvec_lru_size(lruvec, file * LRU_FILE); > active = lruvec_lru_size(lruvec, file * LRU_FILE + LRU_ACTIVE); > > + /* > + * For global reclaim on zone-constrained allocations, it is necessary > + * to check if rotations are required for lowmem to be reclaimed. This s/rotation/deactivation/ > + * calculates the inactive/active pages available in eligible zones. > + */ > + if (global_reclaim(sc)) { > + struct pglist_data *pgdat = lruvec_pgdat(lruvec); > + int zid; > + > + for (zid = sc->reclaim_idx + 1; zid < MAX_NR_ZONES; zid++) { The emphasis on global vs. memcg reclaim is somewhat strange, because this is only about excluding pages from the balancing math that will be skipped. Memcg reclaim is never zone-restricted, but if it were, it would make sense to exclude the skipped pages there as well. Indeed, for memcg reclaim sc->reclaim_idx+1 is always MAX_NR_ZONES, and so the for loop alone will do the right thing. Can you please drop the global_reclaim() branch, the sc function parameter, and the "global reclaim" from the comment? Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org> To: Mel Gorman <mgorman@techsingularity.net> Cc: Andrew Morton <akpm@linux-foundation.org>, Minchan Kim <minchan@kernel.org>, Michal Hocko <mhocko@suse.cz>, Vlastimil Babka <vbabka@suse.cz>, Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 4/5] mm: consider per-zone inactive ratio to deactivate Date: Thu, 21 Jul 2016 11:52:59 -0400 [thread overview] Message-ID: <20160721155259.GB30303@cmpxchg.org> (raw) In-Reply-To: <1469110261-7365-5-git-send-email-mgorman@techsingularity.net> On Thu, Jul 21, 2016 at 03:11:00PM +0100, Mel Gorman wrote: > @@ -1981,6 +1982,32 @@ static bool inactive_list_is_low(struct lruvec *lruvec, bool file) > inactive = lruvec_lru_size(lruvec, file * LRU_FILE); > active = lruvec_lru_size(lruvec, file * LRU_FILE + LRU_ACTIVE); > > + /* > + * For global reclaim on zone-constrained allocations, it is necessary > + * to check if rotations are required for lowmem to be reclaimed. This s/rotation/deactivation/ > + * calculates the inactive/active pages available in eligible zones. > + */ > + if (global_reclaim(sc)) { > + struct pglist_data *pgdat = lruvec_pgdat(lruvec); > + int zid; > + > + for (zid = sc->reclaim_idx + 1; zid < MAX_NR_ZONES; zid++) { The emphasis on global vs. memcg reclaim is somewhat strange, because this is only about excluding pages from the balancing math that will be skipped. Memcg reclaim is never zone-restricted, but if it were, it would make sense to exclude the skipped pages there as well. Indeed, for memcg reclaim sc->reclaim_idx+1 is always MAX_NR_ZONES, and so the for loop alone will do the right thing. Can you please drop the global_reclaim() branch, the sc function parameter, and the "global reclaim" from the comment? Thanks -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-21 15:55 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-21 14:10 [PATCH 0/5] Candidate fixes for premature OOM kills with node-lru v2 Mel Gorman 2016-07-21 14:10 ` Mel Gorman 2016-07-21 14:10 ` [PATCH 1/5] mm: add per-zone lru list stat Mel Gorman 2016-07-21 14:10 ` Mel Gorman 2016-07-22 15:51 ` Johannes Weiner 2016-07-22 15:51 ` Johannes Weiner 2016-07-21 14:10 ` [PATCH 2/5] mm, vmscan: Remove highmem_file_pages Mel Gorman 2016-07-21 14:10 ` Mel Gorman 2016-07-22 15:53 ` Johannes Weiner 2016-07-22 15:53 ` Johannes Weiner 2016-07-25 8:09 ` Minchan Kim 2016-07-25 8:09 ` Minchan Kim 2016-07-25 9:23 ` [PATCH] mm, vmscan: remove highmem_file_pages -fix Mel Gorman 2016-07-25 9:23 ` Mel Gorman 2016-07-21 14:10 ` [PATCH 3/5] mm: Remove reclaim and compaction retry approximations Mel Gorman 2016-07-21 14:10 ` Mel Gorman 2016-07-22 15:57 ` Johannes Weiner 2016-07-22 15:57 ` Johannes Weiner 2016-07-25 8:18 ` Minchan Kim 2016-07-25 8:18 ` Minchan Kim 2016-07-21 14:11 ` [PATCH 4/5] mm: consider per-zone inactive ratio to deactivate Mel Gorman 2016-07-21 14:11 ` Mel Gorman 2016-07-21 15:52 ` Johannes Weiner [this message] 2016-07-21 15:52 ` Johannes Weiner 2016-07-21 14:11 ` [PATCH 5/5] mm, vmscan: Account for skipped pages as a partial scan Mel Gorman 2016-07-21 14:11 ` Mel Gorman 2016-07-22 16:02 ` Johannes Weiner 2016-07-22 16:02 ` Johannes Weiner 2016-07-25 8:39 ` Minchan Kim 2016-07-25 8:39 ` Minchan Kim 2016-07-25 9:52 ` Mel Gorman 2016-07-25 9:52 ` Mel Gorman 2016-07-26 8:16 ` Joonsoo Kim 2016-07-26 8:16 ` Joonsoo Kim 2016-07-26 8:26 ` Joonsoo Kim 2016-07-26 8:26 ` Joonsoo Kim 2016-07-26 8:11 ` [PATCH 0/5] Candidate fixes for premature OOM kills with node-lru v2 Joonsoo Kim 2016-07-26 8:11 ` Joonsoo Kim 2016-07-26 12:50 ` Mel Gorman 2016-07-26 12:50 ` Mel Gorman 2016-07-28 6:44 ` Joonsoo Kim 2016-07-28 6:44 ` Joonsoo Kim 2016-07-28 10:27 ` Mel Gorman 2016-07-28 10:27 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160721155259.GB30303@cmpxchg.org \ --to=hannes@cmpxchg.org \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@techsingularity.net \ --cc=mhocko@suse.cz \ --cc=minchan@kernel.org \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.