From: "Ville Syrjälä" <ville.syrjala@linux.intel.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Daniel Vetter <daniel.vetter@intel.com>, DRI mailing list <dri-devel@lists.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [git pull] drm for v4.8 Date: Tue, 2 Aug 2016 21:34:04 +0300 [thread overview] Message-ID: <20160802183404.GD4329@intel.com> (raw) In-Reply-To: <CAKMK7uHC45n3UqzVhv46u6irzHwAdQgGvrASfBQAJCmNDtwhbQ@mail.gmail.com> On Tue, Aug 02, 2016 at 08:01:14PM +0200, Daniel Vetter wrote: > On Tue, Aug 2, 2016 at 6:40 PM, Linus Torvalds > <torvalds@linux-foundation.org> wrote: > > On Tue, Aug 2, 2016 at 4:10 AM, Ville Syrjälä > > <ville.syrjala@linux.intel.com> wrote: > >> > >> So PSR seems more likely. The underruns might point at some watermark > >> fail though :( > >> > >> I have a couple of pending PSR patches you may want to try as well, > >> if i915.enable_psr=0 helps. > >> > >> First set is here: > >> git://github.com/vsyrjala/linux.git psr_setup_time_2 > >> This should be perfectly safe to go in actually, as it will only result > >> in disabling PSR with certain panels. > > > > This first git pull fixes it for me, as far as I can tell. I'm not > > sure that the problem is 100% reproducible, but I booted into each > > kernel twice, and the current git tree is broken, while with your > > psr_setup_time_2 branch pulled it works. So it does seem to be the > > fix. > > > >> The second set is here: > >> git://github.com/vsyrjala/linux.git psr_fixes_2 > > > > I didn't even test that one. > > > > Should I just pull that psr_setup_time2 branch for real? I'd like to > > get a real pull request with explanations etc, but other than that it > > looks good to go. > > Hm, I reviewed all the patches from Ville already. I gues they were > stuck because we didn't have someone who reported that it's fixed, > plus they lacked an ack from Dave for the 2 core patches. + they were part of a series that included a rotten apple responsible for a BAT regression > tbh I'd just > apply them all to drm-intel-fixes and then send out a pull for that > (there's two more bugfix patches on it which missed Dave's main pull > by a notch). Dave/Jani? > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Ville Syrjälä Intel OTC
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: Daniel Vetter <daniel.vetter@intel.com>, Linus Torvalds <torvalds@linux-foundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, DRI mailing list <dri-devel@lists.freedesktop.org> Subject: Re: [git pull] drm for v4.8 Date: Tue, 2 Aug 2016 21:34:04 +0300 [thread overview] Message-ID: <20160802183404.GD4329@intel.com> (raw) In-Reply-To: <CAKMK7uHC45n3UqzVhv46u6irzHwAdQgGvrASfBQAJCmNDtwhbQ@mail.gmail.com> On Tue, Aug 02, 2016 at 08:01:14PM +0200, Daniel Vetter wrote: > On Tue, Aug 2, 2016 at 6:40 PM, Linus Torvalds > <torvalds@linux-foundation.org> wrote: > > On Tue, Aug 2, 2016 at 4:10 AM, Ville Syrjälä > > <ville.syrjala@linux.intel.com> wrote: > >> > >> So PSR seems more likely. The underruns might point at some watermark > >> fail though :( > >> > >> I have a couple of pending PSR patches you may want to try as well, > >> if i915.enable_psr=0 helps. > >> > >> First set is here: > >> git://github.com/vsyrjala/linux.git psr_setup_time_2 > >> This should be perfectly safe to go in actually, as it will only result > >> in disabling PSR with certain panels. > > > > This first git pull fixes it for me, as far as I can tell. I'm not > > sure that the problem is 100% reproducible, but I booted into each > > kernel twice, and the current git tree is broken, while with your > > psr_setup_time_2 branch pulled it works. So it does seem to be the > > fix. > > > >> The second set is here: > >> git://github.com/vsyrjala/linux.git psr_fixes_2 > > > > I didn't even test that one. > > > > Should I just pull that psr_setup_time2 branch for real? I'd like to > > get a real pull request with explanations etc, but other than that it > > looks good to go. > > Hm, I reviewed all the patches from Ville already. I gues they were > stuck because we didn't have someone who reported that it's fixed, > plus they lacked an ack from Dave for the 2 core patches. + they were part of a series that included a rotten apple responsible for a BAT regression > tbh I'd just > apply them all to drm-intel-fixes and then send out a pull for that > (there's two more bugfix patches on it which missed Dave's main pull > by a notch). Dave/Jani? > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-02 18:35 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-02 1:32 [git pull] drm for v4.8 Dave Airlie 2016-08-02 1:32 ` Dave Airlie 2016-08-02 2:26 ` Linus Torvalds 2016-08-02 2:26 ` Linus Torvalds 2016-08-02 8:00 ` Daniel Vetter 2016-08-02 8:00 ` Daniel Vetter 2016-08-02 8:10 ` Ville Syrjälä 2016-08-02 8:10 ` Ville Syrjälä 2016-08-02 11:28 ` Linus Torvalds 2016-08-02 11:28 ` Linus Torvalds 2016-08-02 12:22 ` Jani Nikula 2016-08-02 12:22 ` Jani Nikula 2016-08-02 16:40 ` Linus Torvalds 2016-08-02 16:40 ` Linus Torvalds 2016-08-02 18:01 ` Daniel Vetter 2016-08-02 18:01 ` Daniel Vetter 2016-08-02 18:34 ` Ville Syrjälä [this message] 2016-08-02 18:34 ` Ville Syrjälä 2016-08-02 11:47 ` Jiri Kosina 2016-08-02 12:19 ` Jiri Kosina 2016-08-02 12:27 ` Jani Nikula 2016-08-02 12:27 ` Jani Nikula 2016-08-02 12:49 ` Jiri Kosina 2016-08-02 7:03 Михаил Гаврилов
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160802183404.GD4329@intel.com \ --to=ville.syrjala@linux.intel.com \ --cc=daniel.vetter@intel.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.