From: Lee Jones <lee.jones@linaro.org> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kernel@stlinux.com, patrice.chotard@st.com, ohad@wizery.com, bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org, loic.pallardy@st.com, Lee Jones <lee.jones@linaro.org> Subject: [PATCH 1/9] remoteproc: core: Ensure error message is clear Date: Thu, 4 Aug 2016 10:21:45 +0100 [thread overview] Message-ID: <20160804092153.23032-2-lee.jones@linaro.org> (raw) In-Reply-To: <20160804092153.23032-1-lee.jones@linaro.org> Before this patch, the dma_alloc_coherent() failure path printed out: "dma_alloc_coherent err: 16760832" ... alluding to the Linux error code being 16760832, but seeing as Linux error codes are all negative, this looks like a signed/unsigned issue. In fact, the message is trying to print the length of the requested memory region. Let's clear that up. While we're at it, let's standardise the way 'len' is printed. In all other locations 'len' is in hex prefixed by a '0x' for clarity. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/remoteproc/remoteproc_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index aea29a75c..3566dc9 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -581,7 +581,7 @@ static int rproc_handle_carveout(struct rproc *rproc, return -EINVAL; } - dev_dbg(dev, "carveout rsc: da %x, pa %x, len %x, flags %x\n", + dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n", rsc->da, rsc->pa, rsc->len, rsc->flags); carveout = kzalloc(sizeof(*carveout), GFP_KERNEL); @@ -590,7 +590,8 @@ static int rproc_handle_carveout(struct rproc *rproc, va = dma_alloc_coherent(dev->parent, rsc->len, &dma, GFP_KERNEL); if (!va) { - dev_err(dev->parent, "dma_alloc_coherent err: %d\n", rsc->len); + dev_err(dev->parent, + "failed to allocate dma memory: len 0x%x\n", rsc->len); ret = -ENOMEM; goto free_carv; } -- 2.9.0
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/9] remoteproc: core: Ensure error message is clear Date: Thu, 4 Aug 2016 10:21:45 +0100 [thread overview] Message-ID: <20160804092153.23032-2-lee.jones@linaro.org> (raw) In-Reply-To: <20160804092153.23032-1-lee.jones@linaro.org> Before this patch, the dma_alloc_coherent() failure path printed out: "dma_alloc_coherent err: 16760832" ... alluding to the Linux error code being 16760832, but seeing as Linux error codes are all negative, this looks like a signed/unsigned issue. In fact, the message is trying to print the length of the requested memory region. Let's clear that up. While we're at it, let's standardise the way 'len' is printed. In all other locations 'len' is in hex prefixed by a '0x' for clarity. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/remoteproc/remoteproc_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index aea29a75c..3566dc9 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -581,7 +581,7 @@ static int rproc_handle_carveout(struct rproc *rproc, return -EINVAL; } - dev_dbg(dev, "carveout rsc: da %x, pa %x, len %x, flags %x\n", + dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n", rsc->da, rsc->pa, rsc->len, rsc->flags); carveout = kzalloc(sizeof(*carveout), GFP_KERNEL); @@ -590,7 +590,8 @@ static int rproc_handle_carveout(struct rproc *rproc, va = dma_alloc_coherent(dev->parent, rsc->len, &dma, GFP_KERNEL); if (!va) { - dev_err(dev->parent, "dma_alloc_coherent err: %d\n", rsc->len); + dev_err(dev->parent, + "failed to allocate dma memory: len 0x%x\n", rsc->len); ret = -ENOMEM; goto free_carv; } -- 2.9.0
next prev parent reply other threads:[~2016-08-04 9:21 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-04 9:21 [PATCH 0/9] remoteproc: Allow platform-specific drivers to request resources Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-04 9:21 ` Lee Jones [this message] 2016-08-04 9:21 ` [PATCH 1/9] remoteproc: core: Ensure error message is clear Lee Jones 2016-08-09 17:28 ` Bjorn Andersson 2016-08-09 17:28 ` Bjorn Andersson 2016-08-09 18:12 ` Lee Jones 2016-08-09 18:12 ` Lee Jones 2016-08-10 20:11 ` Suman Anna 2016-08-10 20:11 ` Suman Anna 2016-08-10 20:11 ` Suman Anna 2016-08-11 7:36 ` Lee Jones 2016-08-11 7:36 ` Lee Jones 2016-08-11 7:36 ` Lee Jones 2016-08-11 19:19 ` Bjorn Andersson 2016-08-11 19:19 ` Bjorn Andersson 2016-08-11 19:19 ` Bjorn Andersson 2016-08-11 20:09 ` Suman Anna 2016-08-11 20:09 ` Suman Anna 2016-08-11 20:09 ` Suman Anna 2016-08-04 9:21 ` [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-09 17:32 ` Bjorn Andersson 2016-08-09 17:32 ` Bjorn Andersson 2016-08-09 18:12 ` Lee Jones 2016-08-09 18:12 ` Lee Jones 2016-08-04 9:21 ` [PATCH 3/9] remoteproc: core: Remove pointless OOM print Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-09 17:36 ` Bjorn Andersson 2016-08-09 17:36 ` Bjorn Andersson 2016-08-09 18:10 ` Lee Jones 2016-08-09 18:10 ` Lee Jones 2016-08-10 17:47 ` Bjorn Andersson 2016-08-10 17:47 ` Bjorn Andersson 2016-08-04 9:21 ` [PATCH 4/9] remoteproc: core: New API to add new resources to the resource table Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-04 14:00 ` Lee Jones 2016-08-04 14:00 ` Lee Jones 2016-08-08 13:41 ` loic pallardy 2016-08-08 13:41 ` loic pallardy 2016-08-08 13:41 ` loic pallardy 2016-08-09 12:48 ` Lee Jones 2016-08-09 12:48 ` Lee Jones 2016-08-04 9:21 ` [PATCH 5/9] remoteproc: core: Add function to amend an existing resource table entry Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-04 9:21 ` [PATCH 6/9] remoteproc: core: Add function to append a new " Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-11 7:51 ` loic pallardy 2016-08-11 7:51 ` loic pallardy 2016-08-11 7:51 ` loic pallardy 2016-08-11 20:20 ` Bjorn Andersson 2016-08-11 20:20 ` Bjorn Andersson 2016-08-12 11:54 ` loic pallardy 2016-08-12 11:54 ` loic pallardy 2016-08-12 11:54 ` loic pallardy 2016-08-04 9:21 ` [PATCH 7/9] remoteproc: core: Add function to over-ride current resource table Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-08 13:47 ` loic pallardy 2016-08-08 13:47 ` loic pallardy 2016-08-08 13:47 ` loic pallardy 2016-08-09 12:46 ` Lee Jones 2016-08-09 12:46 ` Lee Jones 2016-08-04 9:21 ` [PATCH 8/9] remoteproc: core: Skip resource table integrity checks if there are amendments Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-09 17:40 ` Bjorn Andersson 2016-08-09 17:40 ` Bjorn Andersson 2016-08-04 9:21 ` [PATCH 9/9] remoteproc: core: Support empty resource tables Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-05 7:38 ` Lee Jones 2016-08-05 7:38 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160804092153.23032-2-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=kernel@stlinux.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=loic.pallardy@st.com \ --cc=ohad@wizery.com \ --cc=patrice.chotard@st.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.