From: Lee Jones <lee.jones@linaro.org> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kernel@stlinux.com, patrice.chotard@st.com, ohad@wizery.com, bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org, loic.pallardy@st.com, Lee Jones <lee.jones@linaro.org> Subject: [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints Date: Thu, 4 Aug 2016 10:21:46 +0100 [thread overview] Message-ID: <20160804092153.23032-3-lee.jones@linaro.org> (raw) In-Reply-To: <20160804092153.23032-1-lee.jones@linaro.org> Trivial patch to clean up a couple of minor misgivings. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/remoteproc/remoteproc_core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 3566dc9..5654a81 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -457,8 +457,8 @@ static int rproc_handle_trace(struct rproc *rproc, struct fw_rsc_trace *rsc, rproc->num_traces++; - dev_dbg(dev, "%s added: va %p, da 0x%x, len 0x%x\n", name, ptr, - rsc->da, rsc->len); + dev_dbg(dev, "%s added: va %p, da 0x%x, len 0x%x\n", + name, ptr, rsc->da, rsc->len); return 0; } @@ -581,8 +581,8 @@ static int rproc_handle_carveout(struct rproc *rproc, return -EINVAL; } - dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n", - rsc->da, rsc->pa, rsc->len, rsc->flags); + dev_dbg(dev, "carveout rsc: name: %s, da %x, pa %x, len 0x%x, flags %x\n", + rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags); carveout = kzalloc(sizeof(*carveout), GFP_KERNEL); if (!carveout) @@ -700,7 +700,7 @@ static rproc_handle_resource_t rproc_loading_handlers[RSC_LAST] = { [RSC_CARVEOUT] = (rproc_handle_resource_t)rproc_handle_carveout, [RSC_DEVMEM] = (rproc_handle_resource_t)rproc_handle_devmem, [RSC_TRACE] = (rproc_handle_resource_t)rproc_handle_trace, - [RSC_VDEV] = NULL, /* VDEVs were handled upon registrarion */ + [RSC_VDEV] = NULL, /* VDEVs were handled upon registration */ }; static rproc_handle_resource_t rproc_vdev_handler[RSC_LAST] = { @@ -918,7 +918,7 @@ static void rproc_fw_config_virtio(const struct firmware *fw, void *context) * Create a copy of the resource table. When a virtio device starts * and calls vring_new_virtqueue() the address of the allocated vring * will be stored in the cached_table. Before the device is started, - * cached_table will be copied into devic memory. + * cached_table will be copied into device memory. */ rproc->cached_table = kmemdup(table, tablesz, GFP_KERNEL); if (!rproc->cached_table) -- 2.9.0
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints Date: Thu, 4 Aug 2016 10:21:46 +0100 [thread overview] Message-ID: <20160804092153.23032-3-lee.jones@linaro.org> (raw) In-Reply-To: <20160804092153.23032-1-lee.jones@linaro.org> Trivial patch to clean up a couple of minor misgivings. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/remoteproc/remoteproc_core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 3566dc9..5654a81 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -457,8 +457,8 @@ static int rproc_handle_trace(struct rproc *rproc, struct fw_rsc_trace *rsc, rproc->num_traces++; - dev_dbg(dev, "%s added: va %p, da 0x%x, len 0x%x\n", name, ptr, - rsc->da, rsc->len); + dev_dbg(dev, "%s added: va %p, da 0x%x, len 0x%x\n", + name, ptr, rsc->da, rsc->len); return 0; } @@ -581,8 +581,8 @@ static int rproc_handle_carveout(struct rproc *rproc, return -EINVAL; } - dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n", - rsc->da, rsc->pa, rsc->len, rsc->flags); + dev_dbg(dev, "carveout rsc: name: %s, da %x, pa %x, len 0x%x, flags %x\n", + rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags); carveout = kzalloc(sizeof(*carveout), GFP_KERNEL); if (!carveout) @@ -700,7 +700,7 @@ static rproc_handle_resource_t rproc_loading_handlers[RSC_LAST] = { [RSC_CARVEOUT] = (rproc_handle_resource_t)rproc_handle_carveout, [RSC_DEVMEM] = (rproc_handle_resource_t)rproc_handle_devmem, [RSC_TRACE] = (rproc_handle_resource_t)rproc_handle_trace, - [RSC_VDEV] = NULL, /* VDEVs were handled upon registrarion */ + [RSC_VDEV] = NULL, /* VDEVs were handled upon registration */ }; static rproc_handle_resource_t rproc_vdev_handler[RSC_LAST] = { @@ -918,7 +918,7 @@ static void rproc_fw_config_virtio(const struct firmware *fw, void *context) * Create a copy of the resource table. When a virtio device starts * and calls vring_new_virtqueue() the address of the allocated vring * will be stored in the cached_table. Before the device is started, - * cached_table will be copied into devic memory. + * cached_table will be copied into device memory. */ rproc->cached_table = kmemdup(table, tablesz, GFP_KERNEL); if (!rproc->cached_table) -- 2.9.0
next prev parent reply other threads:[~2016-08-04 9:21 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-04 9:21 [PATCH 0/9] remoteproc: Allow platform-specific drivers to request resources Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-04 9:21 ` [PATCH 1/9] remoteproc: core: Ensure error message is clear Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-09 17:28 ` Bjorn Andersson 2016-08-09 17:28 ` Bjorn Andersson 2016-08-09 18:12 ` Lee Jones 2016-08-09 18:12 ` Lee Jones 2016-08-10 20:11 ` Suman Anna 2016-08-10 20:11 ` Suman Anna 2016-08-10 20:11 ` Suman Anna 2016-08-11 7:36 ` Lee Jones 2016-08-11 7:36 ` Lee Jones 2016-08-11 7:36 ` Lee Jones 2016-08-11 19:19 ` Bjorn Andersson 2016-08-11 19:19 ` Bjorn Andersson 2016-08-11 19:19 ` Bjorn Andersson 2016-08-11 20:09 ` Suman Anna 2016-08-11 20:09 ` Suman Anna 2016-08-11 20:09 ` Suman Anna 2016-08-04 9:21 ` Lee Jones [this message] 2016-08-04 9:21 ` [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints Lee Jones 2016-08-09 17:32 ` Bjorn Andersson 2016-08-09 17:32 ` Bjorn Andersson 2016-08-09 18:12 ` Lee Jones 2016-08-09 18:12 ` Lee Jones 2016-08-04 9:21 ` [PATCH 3/9] remoteproc: core: Remove pointless OOM print Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-09 17:36 ` Bjorn Andersson 2016-08-09 17:36 ` Bjorn Andersson 2016-08-09 18:10 ` Lee Jones 2016-08-09 18:10 ` Lee Jones 2016-08-10 17:47 ` Bjorn Andersson 2016-08-10 17:47 ` Bjorn Andersson 2016-08-04 9:21 ` [PATCH 4/9] remoteproc: core: New API to add new resources to the resource table Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-04 14:00 ` Lee Jones 2016-08-04 14:00 ` Lee Jones 2016-08-08 13:41 ` loic pallardy 2016-08-08 13:41 ` loic pallardy 2016-08-08 13:41 ` loic pallardy 2016-08-09 12:48 ` Lee Jones 2016-08-09 12:48 ` Lee Jones 2016-08-04 9:21 ` [PATCH 5/9] remoteproc: core: Add function to amend an existing resource table entry Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-04 9:21 ` [PATCH 6/9] remoteproc: core: Add function to append a new " Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-11 7:51 ` loic pallardy 2016-08-11 7:51 ` loic pallardy 2016-08-11 7:51 ` loic pallardy 2016-08-11 20:20 ` Bjorn Andersson 2016-08-11 20:20 ` Bjorn Andersson 2016-08-12 11:54 ` loic pallardy 2016-08-12 11:54 ` loic pallardy 2016-08-12 11:54 ` loic pallardy 2016-08-04 9:21 ` [PATCH 7/9] remoteproc: core: Add function to over-ride current resource table Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-08 13:47 ` loic pallardy 2016-08-08 13:47 ` loic pallardy 2016-08-08 13:47 ` loic pallardy 2016-08-09 12:46 ` Lee Jones 2016-08-09 12:46 ` Lee Jones 2016-08-04 9:21 ` [PATCH 8/9] remoteproc: core: Skip resource table integrity checks if there are amendments Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-09 17:40 ` Bjorn Andersson 2016-08-09 17:40 ` Bjorn Andersson 2016-08-04 9:21 ` [PATCH 9/9] remoteproc: core: Support empty resource tables Lee Jones 2016-08-04 9:21 ` Lee Jones 2016-08-05 7:38 ` Lee Jones 2016-08-05 7:38 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160804092153.23032-3-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=kernel@stlinux.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=loic.pallardy@st.com \ --cc=ohad@wizery.com \ --cc=patrice.chotard@st.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.