From: James Hogan <james.hogan@imgtec.com> To: Mel Gorman <mgorman@techsingularity.net> Cc: Andrew Morton <akpm@linux-foundation.org>, Linux-MM <linux-mm@kvack.org>, Rik van Riel <riel@surriel.com>, Vlastimil Babka <vbabka@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, Minchan Kim <minchan@kernel.org>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, LKML <linux-kernel@vger.kernel.org>, metag <linux-metag@vger.kernel.org> Subject: Re: [PATCH 03/34] mm, vmscan: move LRU lists to node Date: Fri, 5 Aug 2016 11:52:57 +0100 [thread overview] Message-ID: <20160805105256.GH19514@jhogan-linux.le.imgtec.org> (raw) In-Reply-To: <20160805084115.GO2799@techsingularity.net> [-- Attachment #1: Type: text/plain, Size: 2789 bytes --] On Fri, Aug 05, 2016 at 09:41:15AM +0100, Mel Gorman wrote: > On Thu, Aug 04, 2016 at 09:59:17PM +0100, James Hogan wrote: > > > Signed-off-by: Mel Gorman <mgorman@techsingularity.net> > > > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > > > Acked-by: Vlastimil Babka <vbabka@suse.cz> > > > > This breaks boot on metag architecture: > > Oops: err 0007 (Data access general read/write fault) addr 00233008 [#1] > > > > It appears to be in node_page_state_snapshot() (via > > pgdat_reclaimable()), and have come via mm_init. Here's the relevant > > bit of the backtrace: > > > > node_page_state_snapshot@0x4009c884(enum node_stat_item item = > > ???, struct pglist_data * pgdat = ???) + 0x48 > > pgdat_reclaimable(struct pglist_data * pgdat = 0x402517a0) > > show_free_areas(unsigned int filter = 0) + 0x2cc > > show_mem(unsigned int filter = 0) + 0x18 > > mm_init@0x4025c3d4() > > start_kernel() + 0x204 > > > > __per_cpu_offset[0] == 0x233000 (close to bad addr), > > pgdat->per_cpu_nodestats = NULL. and setup_per_cpu_pageset() > > definitely hasn't been called yet (mm_init is called before > > setup_per_cpu_pageset()). > > > > Any ideas what the correct solution is (and why presumably others > > haven't seen the same issue on other architectures?). > > > > metag calls show_mem in mem_init() before the pagesets are initialised. Indeed, I didn't spot yesterday evening that this appears to be different to other arches. > What's surprising is that it worked for the zone stats as it appears > that calling zone_reclaimable() from that context should also have > broken. Did anything change recently that would have avoided the > zone->pageset dereference in zone_reclaimable() before? It appears that zone_pcp_init() was already setting zone->pageset to &boot_pageset, via paging_init(): zone_pcp_init@0x40265d54(struct zone * zone = ???) free_area_init_core@0x40265c18(struct pglist_data * pgdat = ???) + 0x138 free_area_init_node(int nid = 0, unsigned long * zones_size = ???, unsigned long node_start_pfn = ???, unsigned long * zholes_size = ???) + 0x1a0 free_area_init_nodes(unsigned long * max_zone_pfn = ???) + 0x440 paging_init(unsigned long mem_end = 0x4fe00000) + 0x378 setup_arch(char ** cmdline_p = 0x4024e038) + 0x2b8 start_kernel() + 0x54 setup_arch() is called prior to mm_init(), which explains why it wasn't crashing before. > The easiest option would be to not call show_mem from arch code until > after the pagesets are setup. Since no other arches seem to do show_mem earily during boot like metag, and doing so doesn't really add much value, I'm happy to remove it anyway. However could your change break other things and need fixing anyway? Thanks! James [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> To: Mel Gorman <mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org> Cc: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Linux-MM <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>, Rik van Riel <riel-ebMLmSuQjDVBDgjK7y7TUQ@public.gmane.org>, Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org>, Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, Minchan Kim <minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Joonsoo Kim <iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org>, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, metag <linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 03/34] mm, vmscan: move LRU lists to node Date: Fri, 5 Aug 2016 11:52:57 +0100 [thread overview] Message-ID: <20160805105256.GH19514@jhogan-linux.le.imgtec.org> (raw) In-Reply-To: <20160805084115.GO2799-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 2868 bytes --] On Fri, Aug 05, 2016 at 09:41:15AM +0100, Mel Gorman wrote: > On Thu, Aug 04, 2016 at 09:59:17PM +0100, James Hogan wrote: > > > Signed-off-by: Mel Gorman <mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org> > > > Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org> > > > Acked-by: Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org> > > > > This breaks boot on metag architecture: > > Oops: err 0007 (Data access general read/write fault) addr 00233008 [#1] > > > > It appears to be in node_page_state_snapshot() (via > > pgdat_reclaimable()), and have come via mm_init. Here's the relevant > > bit of the backtrace: > > > > node_page_state_snapshot@0x4009c884(enum node_stat_item item = > > ???, struct pglist_data * pgdat = ???) + 0x48 > > pgdat_reclaimable(struct pglist_data * pgdat = 0x402517a0) > > show_free_areas(unsigned int filter = 0) + 0x2cc > > show_mem(unsigned int filter = 0) + 0x18 > > mm_init@0x4025c3d4() > > start_kernel() + 0x204 > > > > __per_cpu_offset[0] == 0x233000 (close to bad addr), > > pgdat->per_cpu_nodestats = NULL. and setup_per_cpu_pageset() > > definitely hasn't been called yet (mm_init is called before > > setup_per_cpu_pageset()). > > > > Any ideas what the correct solution is (and why presumably others > > haven't seen the same issue on other architectures?). > > > > metag calls show_mem in mem_init() before the pagesets are initialised. Indeed, I didn't spot yesterday evening that this appears to be different to other arches. > What's surprising is that it worked for the zone stats as it appears > that calling zone_reclaimable() from that context should also have > broken. Did anything change recently that would have avoided the > zone->pageset dereference in zone_reclaimable() before? It appears that zone_pcp_init() was already setting zone->pageset to &boot_pageset, via paging_init(): zone_pcp_init@0x40265d54(struct zone * zone = ???) free_area_init_core@0x40265c18(struct pglist_data * pgdat = ???) + 0x138 free_area_init_node(int nid = 0, unsigned long * zones_size = ???, unsigned long node_start_pfn = ???, unsigned long * zholes_size = ???) + 0x1a0 free_area_init_nodes(unsigned long * max_zone_pfn = ???) + 0x440 paging_init(unsigned long mem_end = 0x4fe00000) + 0x378 setup_arch(char ** cmdline_p = 0x4024e038) + 0x2b8 start_kernel() + 0x54 setup_arch() is called prior to mm_init(), which explains why it wasn't crashing before. > The easiest option would be to not call show_mem from arch code until > after the pagesets are setup. Since no other arches seem to do show_mem earily during boot like metag, and doing so doesn't really add much value, I'm happy to remove it anyway. However could your change break other things and need fixing anyway? Thanks! James [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-05 10:53 UTC|newest] Thread overview: 220+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-08 9:34 [PATCH 00/34] Move LRU page reclaim from zones to nodes v9 Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-08 9:34 ` [PATCH 01/34] mm, vmstat: add infrastructure for per-node vmstats Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-08-03 19:13 ` Reza Arbab 2016-08-03 19:13 ` Reza Arbab 2016-07-08 9:34 ` [PATCH 02/34] mm, vmscan: move lru_lock to the node Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 11:06 ` Balbir Singh 2016-07-12 11:06 ` Balbir Singh 2016-07-12 11:18 ` Mel Gorman 2016-07-12 11:18 ` Mel Gorman 2016-07-13 5:50 ` Balbir Singh 2016-07-13 5:50 ` Balbir Singh 2016-07-13 8:39 ` Vlastimil Babka 2016-07-13 8:39 ` Vlastimil Babka 2016-07-08 9:34 ` [PATCH 03/34] mm, vmscan: move LRU lists to node Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-08-04 20:59 ` James Hogan 2016-08-04 20:59 ` James Hogan 2016-08-04 20:59 ` James Hogan 2016-08-05 8:41 ` Mel Gorman 2016-08-05 8:41 ` Mel Gorman 2016-08-05 10:52 ` James Hogan [this message] 2016-08-05 10:52 ` James Hogan 2016-08-05 11:55 ` Mel Gorman 2016-08-05 11:55 ` Mel Gorman 2016-08-05 11:55 ` Mel Gorman 2016-08-05 12:02 ` James Hogan 2016-08-05 12:02 ` James Hogan 2016-07-08 9:34 ` [PATCH 04/34] mm, mmzone: clarify the usage of zone padding Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 13:49 ` Johannes Weiner 2016-07-12 13:49 ` Johannes Weiner 2016-07-08 9:34 ` [PATCH 05/34] mm, vmscan: begin reclaiming pages on a per-node basis Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 13:54 ` Johannes Weiner 2016-07-12 13:54 ` Johannes Weiner 2016-07-14 9:19 ` Vlastimil Babka 2016-07-14 9:19 ` Vlastimil Babka 2016-07-08 9:34 ` [PATCH 06/34] mm, vmscan: have kswapd only scan based on the highest requested zone Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 14:05 ` Johannes Weiner 2016-07-12 14:05 ` Johannes Weiner 2016-07-13 8:37 ` Mel Gorman 2016-07-13 8:37 ` Mel Gorman 2016-07-08 9:34 ` [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-08-29 9:38 ` Srikar Dronamraju 2016-08-29 9:38 ` Srikar Dronamraju 2016-08-30 12:07 ` Mel Gorman 2016-08-30 12:07 ` Mel Gorman 2016-08-30 14:25 ` Srikar Dronamraju 2016-08-30 14:25 ` Srikar Dronamraju 2016-08-30 15:00 ` Mel Gorman 2016-08-30 15:00 ` Mel Gorman 2016-08-31 6:09 ` Srikar Dronamraju 2016-08-31 6:09 ` Srikar Dronamraju 2016-08-31 8:49 ` Mel Gorman 2016-08-31 8:49 ` Mel Gorman 2016-08-31 11:09 ` Michal Hocko 2016-08-31 11:09 ` Michal Hocko 2016-08-31 12:46 ` Mel Gorman 2016-08-31 12:46 ` Mel Gorman 2016-08-31 17:33 ` Srikar Dronamraju 2016-08-31 17:33 ` Srikar Dronamraju 2016-07-08 9:34 ` [PATCH 08/34] mm, vmscan: remove balance gap Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 14:06 ` Johannes Weiner 2016-07-12 14:06 ` Johannes Weiner 2016-07-08 9:34 ` [PATCH 09/34] mm, vmscan: simplify the logic deciding whether kswapd sleeps Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-08 9:34 ` [PATCH 10/34] mm, vmscan: by default have direct reclaim only shrink once per node Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-08 9:34 ` [PATCH 11/34] mm, vmscan: remove duplicate logic clearing node congestion and dirty state Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 14:22 ` Johannes Weiner 2016-07-12 14:22 ` Johannes Weiner 2016-07-13 8:40 ` Mel Gorman 2016-07-13 8:40 ` Mel Gorman 2016-07-14 9:45 ` Vlastimil Babka 2016-07-14 9:45 ` Vlastimil Babka 2016-07-08 9:34 ` [PATCH 12/34] mm: vmscan: do not reclaim from kswapd if there is any eligible zone Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 14:29 ` Johannes Weiner 2016-07-12 14:29 ` Johannes Weiner 2016-07-13 8:47 ` Mel Gorman 2016-07-13 8:47 ` Mel Gorman 2016-07-13 12:28 ` Johannes Weiner 2016-07-13 12:28 ` Johannes Weiner 2016-07-08 9:34 ` [PATCH 13/34] mm, vmscan: make shrink_node decisions more node-centric Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 14:32 ` Johannes Weiner 2016-07-12 14:32 ` Johannes Weiner 2016-07-13 8:48 ` Mel Gorman 2016-07-13 8:48 ` Mel Gorman 2016-07-08 9:34 ` [PATCH 14/34] mm, memcg: move memcg limit enforcement from zones to nodes Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 14:38 ` Johannes Weiner 2016-07-12 14:38 ` Johannes Weiner 2016-07-08 9:34 ` [PATCH 15/34] mm, workingset: make working set detection node-aware Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-08 9:34 ` [PATCH 16/34] mm, page_alloc: consider dirtyable memory in terms of nodes Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-08 9:34 ` [PATCH 17/34] mm: move page mapped accounting to the node Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 14:42 ` Johannes Weiner 2016-07-12 14:42 ` Johannes Weiner 2016-07-08 9:34 ` [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 14:58 ` Johannes Weiner 2016-07-12 14:58 ` Johannes Weiner 2016-07-13 8:55 ` Mel Gorman 2016-07-13 8:55 ` Mel Gorman 2016-07-13 13:04 ` Johannes Weiner 2016-07-13 13:04 ` Johannes Weiner 2016-07-13 13:37 ` Mel Gorman 2016-07-13 13:37 ` Mel Gorman 2016-07-13 21:13 ` Andrew Morton 2016-07-13 21:13 ` Andrew Morton 2016-07-15 10:46 ` Mel Gorman 2016-07-15 10:46 ` Mel Gorman 2016-07-15 22:35 ` Andrew Morton 2016-07-15 22:35 ` Andrew Morton 2016-07-18 13:34 ` Johannes Weiner 2016-07-18 13:34 ` Johannes Weiner 2016-07-14 1:27 ` Minchan Kim 2016-07-14 1:27 ` Minchan Kim 2016-07-08 9:34 ` [PATCH 19/34] mm: move most file-based accounting to the node Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 15:11 ` Johannes Weiner 2016-07-12 15:11 ` Johannes Weiner 2016-07-08 9:34 ` [PATCH 20/34] mm: move vmscan writes and file write " Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 15:15 ` Johannes Weiner 2016-07-12 15:15 ` Johannes Weiner 2016-07-08 9:34 ` [PATCH 21/34] mm, vmscan: only wakeup kswapd once per node for the requested classzone Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 17:18 ` Johannes Weiner 2016-07-12 17:18 ` Johannes Weiner 2016-07-08 9:34 ` [PATCH 22/34] mm, page_alloc: wake kswapd based on the highest eligible zone Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 17:24 ` Johannes Weiner 2016-07-12 17:24 ` Johannes Weiner 2016-07-14 10:05 ` Vlastimil Babka 2016-07-14 10:05 ` Vlastimil Babka 2016-07-08 9:34 ` [PATCH 23/34] mm: convert zone_reclaim to node_reclaim Mel Gorman 2016-07-08 9:34 ` Mel Gorman 2016-07-12 17:28 ` Johannes Weiner 2016-07-12 17:28 ` Johannes Weiner 2016-07-08 9:35 ` [PATCH 24/34] mm, vmscan: avoid passing in classzone_idx unnecessarily to shrink_node Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-12 17:31 ` Johannes Weiner 2016-07-12 17:31 ` Johannes Weiner 2016-07-14 10:09 ` Vlastimil Babka 2016-07-14 10:09 ` Vlastimil Babka 2016-07-08 9:35 ` [PATCH 25/34] mm, vmscan: avoid passing in classzone_idx unnecessarily to compaction_ready Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-12 18:01 ` Johannes Weiner 2016-07-12 18:01 ` Johannes Weiner 2016-07-14 12:12 ` Vlastimil Babka 2016-07-14 12:12 ` Vlastimil Babka 2016-07-08 9:35 ` [PATCH 26/34] mm, vmscan: avoid passing in remaining unnecessarily to prepare_kswapd_sleep Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-12 18:06 ` Johannes Weiner 2016-07-12 18:06 ` Johannes Weiner 2016-07-14 12:48 ` Vlastimil Babka 2016-07-14 12:48 ` Vlastimil Babka 2016-07-08 9:35 ` [PATCH 27/34] mm, vmscan: Have kswapd reclaim from all zones if reclaiming and buffer_heads_over_limit Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-12 18:10 ` Johannes Weiner 2016-07-12 18:10 ` Johannes Weiner 2016-07-14 12:54 ` Vlastimil Babka 2016-07-14 12:54 ` Vlastimil Babka 2016-07-08 9:35 ` [PATCH 28/34] mm, vmscan: add classzone information to tracepoints Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-12 18:13 ` Johannes Weiner 2016-07-12 18:13 ` Johannes Weiner 2016-07-08 9:35 ` [PATCH 29/34] mm, page_alloc: remove fair zone allocation policy Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-12 18:18 ` Johannes Weiner 2016-07-12 18:18 ` Johannes Weiner 2016-07-08 9:35 ` [PATCH 30/34] mm: page_alloc: cache the last node whose dirty limit is reached Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-12 18:43 ` Johannes Weiner 2016-07-12 18:43 ` Johannes Weiner 2016-07-08 9:35 ` [PATCH 31/34] mm: vmstat: replace __count_zone_vm_events with a zone id equivalent Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-12 19:10 ` Johannes Weiner 2016-07-12 19:10 ` Johannes Weiner 2016-07-08 9:35 ` [PATCH 32/34] mm: vmstat: account per-zone stalls and pages skipped during reclaim Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-12 19:06 ` Johannes Weiner 2016-07-12 19:06 ` Johannes Weiner 2016-07-08 9:35 ` [PATCH 33/34] mm, vmstat: print node-based stats in zoneinfo file Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-12 19:18 ` Johannes Weiner 2016-07-12 19:18 ` Johannes Weiner 2016-07-14 12:56 ` Vlastimil Babka 2016-07-14 12:56 ` Vlastimil Babka 2016-07-08 9:35 ` [PATCH 34/34] mm, vmstat: remove zone and node double accounting by approximating retries Mel Gorman 2016-07-08 9:35 ` Mel Gorman 2016-07-14 13:40 ` Vlastimil Babka 2016-07-14 13:40 ` Vlastimil Babka 2016-07-15 7:48 ` Mel Gorman 2016-07-15 7:48 ` Mel Gorman 2016-07-15 12:20 ` Vlastimil Babka 2016-07-15 12:20 ` Vlastimil Babka 2016-08-19 13:12 ` [PATCH 00/34] Move LRU page reclaim from zones to nodes v9 Andrea Arcangeli 2016-08-19 13:12 ` Andrea Arcangeli 2016-08-19 13:23 ` Vlastimil Babka 2016-08-19 13:23 ` Vlastimil Babka 2016-08-19 13:55 ` Andrea Arcangeli 2016-08-19 13:55 ` Andrea Arcangeli 2016-08-19 14:53 ` Mel Gorman 2016-08-19 14:53 ` Mel Gorman 2016-08-19 15:32 ` Andrea Arcangeli 2016-08-19 15:32 ` Andrea Arcangeli 2016-08-19 15:55 ` Mel Gorman 2016-08-19 15:55 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160805105256.GH19514@jhogan-linux.le.imgtec.org \ --to=james.hogan@imgtec.com \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=iamjoonsoo.kim@lge.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-metag@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@techsingularity.net \ --cc=minchan@kernel.org \ --cc=riel@surriel.com \ --cc=vbabka@suse.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.